From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53587C433DF for ; Thu, 14 May 2020 07:57:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C4C220575 for ; Thu, 14 May 2020 07:57:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C4C220575 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 740EB89E1D; Thu, 14 May 2020 07:57:54 +0000 (UTC) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8ADB589DFC for ; Thu, 14 May 2020 07:57:52 +0000 (UTC) IronPort-SDR: cOLUnG7ilpu06lItR/mphR193Ee0N/YIGxXJ6z2yG2OO27XKGg5eKsDb87J+ukBcqhEpwfS5le tgTSiG4rrJ8Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2020 00:57:52 -0700 IronPort-SDR: G0xGa8WCYyB0AftXjVyXvJS6RjfP4IsqQQFDXw+dxZm2Ks2bZZdHn3tMIufzHD0SD5yaUcDCqc 7DCpiyv3D1iA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,390,1583222400"; d="scan'208";a="297946166" Received: from gaia.fi.intel.com ([10.237.72.192]) by fmsmga002.fm.intel.com with ESMTP; 14 May 2020 00:57:51 -0700 Received: by gaia.fi.intel.com (Postfix, from userid 1000) id 9FF615C1DC1; Thu, 14 May 2020 10:55:38 +0300 (EEST) From: Mika Kuoppala To: Chris Wilson , intel-gfx@lists.freedesktop.org In-Reply-To: <20200513074809.18194-16-chris@chris-wilson.co.uk> References: <20200513074809.18194-1-chris@chris-wilson.co.uk> <20200513074809.18194-16-chris@chris-wilson.co.uk> Date: Thu, 14 May 2020 10:55:38 +0300 Message-ID: <87y2pvt0g5.fsf@gaia.fi.intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 16/24] drm/i915/selftests: Always call the provided engine->emit_init_breadcrumb X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chris Wilson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Chris Wilson writes: > While this does not appear to fix any issues, the backend itself knows > when it wants to emit a breadcrumb, so let it make the final call. > > Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/selftests/i915_perf.c | 3 +-- > drivers/gpu/drm/i915/selftests/igt_spinner.c | 3 +-- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/selftests/i915_perf.c b/drivers/gpu/drm/i915/selftests/i915_perf.c > index 5608fab98d5d..ca0c9dbab713 100644 > --- a/drivers/gpu/drm/i915/selftests/i915_perf.c > +++ b/drivers/gpu/drm/i915/selftests/i915_perf.c > @@ -221,8 +221,7 @@ static int live_noa_delay(void *arg) > goto out; > } > > - if (rq->engine->emit_init_breadcrumb && > - i915_request_timeline(rq)->has_initial_breadcrumb) { > + if (rq->engine->emit_init_breadcrumb) { > err = rq->engine->emit_init_breadcrumb(rq); > if (err) { > i915_request_add(rq); > diff --git a/drivers/gpu/drm/i915/selftests/igt_spinner.c b/drivers/gpu/drm/i915/selftests/igt_spinner.c > index 9ad4ab088466..e35ba5f9e73f 100644 > --- a/drivers/gpu/drm/i915/selftests/igt_spinner.c > +++ b/drivers/gpu/drm/i915/selftests/igt_spinner.c > @@ -169,8 +169,7 @@ igt_spinner_create_request(struct igt_spinner *spin, > > intel_gt_chipset_flush(engine->gt); > > - if (engine->emit_init_breadcrumb && > - i915_request_timeline(rq)->has_initial_breadcrumb) { > + if (engine->emit_init_breadcrumb) { > err = engine->emit_init_breadcrumb(rq); > if (err) > goto cancel_rq; > -- > 2.20.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx