From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Date: Thu, 27 Feb 2020 10:31:15 +0000 Subject: Re: [PATCH 00/18] genirq: Remove setup_irq() Message-Id: <87y2somido.fsf@nanos.tec.linutronix.de> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: afzal mohammed , linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, x86@kernel.org, linux-sh@vger.kernel.org, linux-s390@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-parisc@vger.kernel.org, linux-mips@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-ia64@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-c6x-dev@linux-c6x.org, linux-omap@vger.kernel.org, linux-alpha@vger.kernel.org Cc: Julia Lawall , Michal Marek , Nicolas Palix , Gilles Muller Afzal, afzal mohammed writes: > While trying to understand internals of irq handling, came across a > thread [1] in which tglx was referring to avoid usage of setup_irq(). > Existing callers of setup_irq() reached mostly via 'init_IRQ()' & > 'time_init()', while memory allocators are ready by 'mm_init()'. > > Hence instances of setup_irq() is replaced by request_irq() & > setup_irq() (along with remove_irq()) definition deleted in the last > patch. > > Seldom remove_irq() usage has been observed coupled with setup_irq(), > wherever that has been found, it too has been replaced by free_irq(). thanks a lot for tackling this! Vs. merging this series, I suggest the following approach: - Resubmit the individual changes as single patches or small series to the relevant maintainers and subsystem mailing lists. They have no dependency on a core change and can be applied where they belong to. - After 5.6-rc6, verify which parts have made their way into linux-next and resubmit the ignored ones as a series to me along with the removal of the core parts. That way we can avoid conflicting changes between subsystems and the tip irq/core branch as much as possible. Thanks, tglx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD877C4BA3B for ; Thu, 27 Feb 2020 10:31:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A537324692 for ; Thu, 27 Feb 2020 10:31:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728794AbgB0Kbc (ORCPT ); Thu, 27 Feb 2020 05:31:32 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:33892 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728680AbgB0Kbb (ORCPT ); Thu, 27 Feb 2020 05:31:31 -0500 Received: from p5de0bf0b.dip0.t-ipconnect.de ([93.224.191.11] helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1j7GRn-0007Oi-T2; Thu, 27 Feb 2020 11:31:15 +0100 Received: by nanos.tec.linutronix.de (Postfix, from userid 1000) id 4CE0E10409C; Thu, 27 Feb 2020 11:31:15 +0100 (CET) From: Thomas Gleixner To: afzal mohammed , linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, x86@kernel.org, linux-sh@vger.kernel.org, linux-s390@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-parisc@vger.kernel.org, linux-mips@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-ia64@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-c6x-dev@linux-c6x.org, linux-omap@vger.kernel.org, linux-alpha@vger.kernel.org Cc: Julia Lawall , Gilles Muller , Nicolas Palix , Michal Marek Subject: Re: [PATCH 00/18] genirq: Remove setup_irq() In-Reply-To: References: Date: Thu, 27 Feb 2020 11:31:15 +0100 Message-ID: <87y2somido.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org Afzal, afzal mohammed writes: > While trying to understand internals of irq handling, came across a > thread [1] in which tglx was referring to avoid usage of setup_irq(). > Existing callers of setup_irq() reached mostly via 'init_IRQ()' & > 'time_init()', while memory allocators are ready by 'mm_init()'. > > Hence instances of setup_irq() is replaced by request_irq() & > setup_irq() (along with remove_irq()) definition deleted in the last > patch. > > Seldom remove_irq() usage has been observed coupled with setup_irq(), > wherever that has been found, it too has been replaced by free_irq(). thanks a lot for tackling this! Vs. merging this series, I suggest the following approach: - Resubmit the individual changes as single patches or small series to the relevant maintainers and subsystem mailing lists. They have no dependency on a core change and can be applied where they belong to. - After 5.6-rc6, verify which parts have made their way into linux-next and resubmit the ignored ones as a series to me along with the removal of the core parts. That way we can avoid conflicting changes between subsystems and the tip irq/core branch as much as possible. Thanks, tglx From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: Re: [PATCH 00/18] genirq: Remove setup_irq() Date: Thu, 27 Feb 2020 11:31:15 +0100 Message-ID: <87y2somido.fsf@nanos.tec.linutronix.de> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ynAR1FfssG9UvbQNF4vSnFz9Qe0K3E5jRaYKFF5aOCA=; b=qyMKGmeW50JgPW 8VuYJXSnwhZSvRwWaRROaORI0usatvKl03L4GDZLUPpt30cKtrpNqaNLEtNX1wA7z9wOkQGQQ6fyP k4+0OFq/cQKvQJPSTHdDRvcVZbPyOsPZ+D+343OAvmumbzSvkQ52nqVOrxFRmRjH9TyG0kkwVr0MW Lwnesrhk9qi3+eGvAMLPgQJw5rlkmCJpbZOXJWzEUnoc6+XNV0WQlP5K33dgezyG/Sa4WyLHsCDOF VwRsg4aq0Qayd78y4c8Id/OLjk0or/qHrda2yxm543kD7ct7wwg/tF1UW29Ocwj11efTpPvxAZG3u 3M28dwf/nt3gOyuPb4lA==; In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane-mx.org@lists.infradead.org To: afzal mohammed , linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, x86@kernel.org, linux-sh@vger.kernel.org, linux-s390@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-parisc@vger.kernel.org, linux-mips@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-ia64@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-c6x-dev@linux-c6x.org, linux-omap@vger.kernel.org, linux-alpha@vger.kernel.org Cc: Julia Lawall , Michal Marek , Nicolas Palix , Gilles Muller Afzal, afzal mohammed writes: > While trying to understand internals of irq handling, came across a > thread [1] in which tglx was referring to avoid usage of setup_irq(). > Existing callers of setup_irq() reached mostly via 'init_IRQ()' & > 'time_init()', while memory allocators are ready by 'mm_init()'. > > Hence instances of setup_irq() is replaced by request_irq() & > setup_irq() (along with remove_irq()) definition deleted in the last > patch. > > Seldom remove_irq() usage has been observed coupled with setup_irq(), > wherever that has been found, it too has been replaced by free_irq(). thanks a lot for tackling this! Vs. merging this series, I suggest the following approach: - Resubmit the individual changes as single patches or small series to the relevant maintainers and subsystem mailing lists. They have no dependency on a core change and can be applied where they belong to. - After 5.6-rc6, verify which parts have made their way into linux-next and resubmit the ignored ones as a series to me along with the removal of the core parts. That way we can avoid conflicting changes between subsystems and the tip irq/core branch as much as possible. Thanks, tglx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 567D8C4BA3B for ; Thu, 27 Feb 2020 10:31:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 86C4024692 for ; Thu, 27 Feb 2020 10:31:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qyMKGmeW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 86C4024692 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ynAR1FfssG9UvbQNF4vSnFz9Qe0K3E5jRaYKFF5aOCA=; b=qyMKGmeW50JgPW 8VuYJXSnwhZSvRwWaRROaORI0usatvKl03L4GDZLUPpt30cKtrpNqaNLEtNX1wA7z9wOkQGQQ6fyP k4+0OFq/cQKvQJPSTHdDRvcVZbPyOsPZ+D+343OAvmumbzSvkQ52nqVOrxFRmRjH9TyG0kkwVr0MW Lwnesrhk9qi3+eGvAMLPgQJw5rlkmCJpbZOXJWzEUnoc6+XNV0WQlP5K33dgezyG/Sa4WyLHsCDOF VwRsg4aq0Qayd78y4c8Id/OLjk0or/qHrda2yxm543kD7ct7wwg/tF1UW29Ocwj11efTpPvxAZG3u 3M28dwf/nt3gOyuPb4lA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j7GS2-0006HS-0h; Thu, 27 Feb 2020 10:31:30 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j7GRz-0006Gg-9a; Thu, 27 Feb 2020 10:31:28 +0000 Received: from p5de0bf0b.dip0.t-ipconnect.de ([93.224.191.11] helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1j7GRn-0007Oi-T2; Thu, 27 Feb 2020 11:31:15 +0100 Received: by nanos.tec.linutronix.de (Postfix, from userid 1000) id 4CE0E10409C; Thu, 27 Feb 2020 11:31:15 +0100 (CET) From: Thomas Gleixner To: afzal mohammed , linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, x86@kernel.org, linux-sh@vger.kernel.org, linux-s390@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-parisc@vger.kernel.org, linux-mips@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-ia64@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-c6x-dev@linux-c6x.org, linux-omap@vger.kernel.org, linux-alpha@vger.kernel.org Subject: Re: [PATCH 00/18] genirq: Remove setup_irq() In-Reply-To: References: Date: Thu, 27 Feb 2020 11:31:15 +0100 Message-ID: <87y2somido.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1, SHORTCIRCUIT=-0.0001 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200227_023127_478130_4050FAB3 X-CRM114-Status: GOOD ( 10.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Julia Lawall , Michal Marek , Nicolas Palix , Gilles Muller Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Afzal, afzal mohammed writes: > While trying to understand internals of irq handling, came across a > thread [1] in which tglx was referring to avoid usage of setup_irq(). > Existing callers of setup_irq() reached mostly via 'init_IRQ()' & > 'time_init()', while memory allocators are ready by 'mm_init()'. > > Hence instances of setup_irq() is replaced by request_irq() & > setup_irq() (along with remove_irq()) definition deleted in the last > patch. > > Seldom remove_irq() usage has been observed coupled with setup_irq(), > wherever that has been found, it too has been replaced by free_irq(). thanks a lot for tackling this! Vs. merging this series, I suggest the following approach: - Resubmit the individual changes as single patches or small series to the relevant maintainers and subsystem mailing lists. They have no dependency on a core change and can be applied where they belong to. - After 5.6-rc6, verify which parts have made their way into linux-next and resubmit the ignored ones as a series to me along with the removal of the core parts. That way we can avoid conflicting changes between subsystems and the tip irq/core branch as much as possible. Thanks, tglx _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel