Re: [alsa-devel] [PATCH 6/6] ASoC: soc-core: add snd_soc_stream_stop()

[Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>]

Hi Pierre-Louis

> >> I noticed that soc_compr_free_fe(), dpcm_fe_dai_shutdown() are directly
> >> calling SND_SOC_DAPM_STREAM_STOP without caring pmdown time / delayed work.
> >> Can we use snd_soc_dapm_stream_stop() for these, too ?
> > 
> > That does seem like an oversight...
> 
> What would the rationale for deferring a FE shutdown though?
> 
> IIRC in the Intel machine drivers we only use .pm_ignore_downtime to
> backends to keep some clocks on, and even that is questionable (the
> clock dependencies should be properly modeled instead of hidden with
> an obscure dailink setting). When I asked why exactly this flag was
> set in most cases the reason why 'because others did so in the
> past'...

Not only "ignore_pmdown_time", but many flags are used
for such reasons, I guess...
But, it is "driver side setting issue", and same things happen
even if we have properly modeled clock dependencies, I guess unfortunately...

From framework side point of view, it should care settings anyway
if it was added/selected even though if it was added by copy-and-paste.
"Following settings case-by-case" is a little bit strange for me.
Maybe FE which has ignore_pmdown_time has some rationale, somehow ?

So, I will post v2 which renames function name that is pointed from you.
And, post additional patch which cares above +2 STREAM_STOP.
Feel free to post NACK it if you don't like it.
Then, Mark can just ignore it.

Thank you for your help !!
Best regards
---
Kuninori Morimoto
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel