From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f195.google.com ([209.85.215.195]:42426 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725268AbfKTHmz (ORCPT ); Wed, 20 Nov 2019 02:42:55 -0500 Received: by mail-pg1-f195.google.com with SMTP id q17so12901885pgt.9 for ; Tue, 19 Nov 2019 23:42:54 -0800 (PST) From: Daniel Axtens Subject: Re: [PATCH v2 1/2] kasan: support instrumented bitops combined with generic bitops In-Reply-To: <87a78xgu8o.fsf@dja-thinkpad.axtens.net> References: <20190820024941.12640-1-dja@axtens.net> <877e6vutiu.fsf@dja-thinkpad.axtens.net> <878sp57z44.fsf@dja-thinkpad.axtens.net> <87a78xgu8o.fsf@dja-thinkpad.axtens.net> Date: Wed, 20 Nov 2019 18:42:50 +1100 Message-ID: <87y2wbf0xx.fsf@dja-thinkpad.axtens.net> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-s390-owner@vger.kernel.org List-ID: To: Marco Elver Cc: christophe.leroy@c-s.fr, linux-s390@vger.kernel.org, linux-arch , the arch/x86 maintainers , linuxppc-dev@lists.ozlabs.org, kasan-dev > But the docs do seem to indicate that it's atomic (for whatever that > means for a single read operation?), so you are right, it should live in > instrumented-atomic.h. Actually, on further inspection, test_bit has lived in bitops/non-atomic.h since it was added in 4117b02132d1 ("[PATCH] bitops: generic __{,test_and_}{set,clear,change}_bit() and test_bit()") So to match that, the wrapper should live in instrumented-non-atomic.h too. If test_bit should move, that would need to be a different patch. But I don't really know if it makes too much sense to stress about a read operation, as opposed to a read/modify/write... Regards, Daniel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Axtens Subject: Re: [PATCH v2 1/2] kasan: support instrumented bitops combined with generic bitops Date: Wed, 20 Nov 2019 18:42:50 +1100 Message-ID: <87y2wbf0xx.fsf@dja-thinkpad.axtens.net> References: <20190820024941.12640-1-dja@axtens.net> <877e6vutiu.fsf@dja-thinkpad.axtens.net> <878sp57z44.fsf@dja-thinkpad.axtens.net> <87a78xgu8o.fsf@dja-thinkpad.axtens.net> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <87a78xgu8o.fsf@dja-thinkpad.axtens.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: Marco Elver Cc: linux-s390@vger.kernel.org, the arch/x86 maintainers , kasan-dev , linux-arch , linuxppc-dev@lists.ozlabs.org List-Id: linux-arch.vger.kernel.org > But the docs do seem to indicate that it's atomic (for whatever that > means for a single read operation?), so you are right, it should live in > instrumented-atomic.h. Actually, on further inspection, test_bit has lived in bitops/non-atomic.h since it was added in 4117b02132d1 ("[PATCH] bitops: generic __{,test_and_}{set,clear,change}_bit() and test_bit()") So to match that, the wrapper should live in instrumented-non-atomic.h too. If test_bit should move, that would need to be a different patch. But I don't really know if it makes too much sense to stress about a read operation, as opposed to a read/modify/write... Regards, Daniel