From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: Re: [PATCH 12/23] ASoC: ak4118: use
	devm_snd_soc_register_component()
Date: 27 Jun 2019 16:51:15 +0900
Message-ID: <87y31nh3j0.wl-kuninori.morimoto.gx@renesas.com>
References: <8736jvkcy1.wl-kuninori.morimoto.gx@renesas.com>
 <87lfxniybh.wl-kuninori.morimoto.gx@renesas.com>
 <20190627094356.51ed48b4@xxx>
Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from relmlie5.idc.renesas.com (relmlor1.renesas.com
 [210.160.252.171])
 by alsa1.perex.cz (Postfix) with ESMTP id 15823F80C0B
 for <alsa-devel@alsa-project.org>; Thu, 27 Jun 2019 09:51:18 +0200 (CEST)
In-Reply-To: <20190627094356.51ed48b4@xxx>
List-Unsubscribe: <https://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <https://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: "Alsa-devel" <alsa-devel-bounces@alsa-project.org>
To: Amadeusz =?ISO-8859-2?Q?S=B3awi=F1ski?= <amadeuszx.slawinski@linux.intel.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>, Mark Brown <broonie@kernel.org>
List-Id: alsa-devel@alsa-project.org


Hi Amadeusz

Thank you for your feedback.
This patch is focusing to using devm_xxx().
Removing empty funcion can be other patch series.
But, I can create v2 to remove empty funcion, of course.
I'm very open. Mark what is your opinion ?

> On 27 Jun 2019 11:00:50 +0900
> Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote:
> 
> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > 
> > We have devm_xxx version of snd_soc_register_component,
> > let's use it.
> > 
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > ---
> >  sound/soc/codecs/ak4118.c | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> > 
> > diff --git a/sound/soc/codecs/ak4118.c b/sound/soc/codecs/ak4118.c
> > index ce419e8..efbe2d6 100644
> > --- a/sound/soc/codecs/ak4118.c
> > +++ b/sound/soc/codecs/ak4118.c
> > @@ -400,13 +400,12 @@ static int ak4118_i2c_probe(struct i2c_client
> > *i2c, return ret;
> >  	}
> >  
> > -	return snd_soc_register_component(&i2c->dev,
> > &soc_component_drv_ak4118,
> > -					  &ak4118_dai, 1);
> > +	return devm_snd_soc_register_component(&i2c->dev,
> > +				&soc_component_drv_ak4118,
> > &ak4118_dai, 1); }
> >  
> >  static int ak4118_i2c_remove(struct i2c_client *i2c)
> >  {
> > -	snd_soc_unregister_component(&i2c->dev);
> >  	return 0;
> >  }
> >  
> 
> Remove whole function.