All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: Yury Kotov <yury-kotov@yandex-team.ru>
Cc: Laurent Vivier <lvivier@redhat.com>,
	Thomas Huth <thuth@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	qemu-devel@nongnu.org, yc-core@yandex-team.ru,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] migration: Fix fd protocol for incoming defer
Date: Tue, 28 May 2019 10:26:12 +0200	[thread overview]
Message-ID: <87y32r6l3v.fsf@trasno.org> (raw)
In-Reply-To: <20190527093350.28567-2-yury-kotov@yandex-team.ru> (Yury Kotov's message of "Mon, 27 May 2019 12:33:49 +0300")

Yury Kotov <yury-kotov@yandex-team.ru> wrote:
> Currently, incoming migration through fd supports only command-line case:
> E.g.
>     fork();
>     fd = open();
>     exec("qemu ... -incoming fd:%d", fd);
>
> It's possible to use add-fd commands to pass fd for migration, but it's
> invalid case. add-fd works with fdset but not with particular fds.
>
> To work with getfd in incoming defer it's enough to use monitor_fd_param
> instead of strtol. monitor_fd_param supports both cases:
> * fd:123
> * fd:fd_name (added by getfd).
>
> Signed-off-by: Yury Kotov <yury-kotov@yandex-team.ru>

Reviewed-by: Juan Quintela <quintela@redhat.com>

Not only that, it also improves error messages.


  reply	other threads:[~2019-05-28  8:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-27  9:33 [Qemu-devel] [PATCH 0/2] Deferred incoming migration through fd Yury Kotov
2019-05-27  9:33 ` [Qemu-devel] [PATCH 1/2] migration: Fix fd protocol for incoming defer Yury Kotov
2019-05-28  8:26   ` Juan Quintela [this message]
2019-05-27  9:33 ` [Qemu-devel] [PATCH 2/2] migration-test: Add a test for fd protocol Yury Kotov
2019-05-27  9:41   ` Yury Kotov
2019-05-27  9:51   ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y32r6l3v.fsf@trasno.org \
    --to=quintela@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=yc-core@yandex-team.ru \
    --cc=yury-kotov@yandex-team.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.