Re: [PATCH 11/46] watchdog: digicolor_wdt: drop warning after registering device

[Baruch Siach <baruch@tkos.co.il>]

Hi Wolfram,

On Sun, May 19 2019, Wolfram Sang wrote:
> The core will print out details now.

devm_watchdog_register_device() might return -ENOMEM when devres_alloc()
fails without printing anything. You might consider that a non-issue
since small memory allocation never fail in practice[1].

But then __watchdog_unregister_device() does some sanity checks,
potentially returning -EINVAL without any print:

        if (wdd == NULL || wdd->info == NULL || wdd->ops == NULL)
                return -EINVAL;

        /* Mandatory operations need to be supported */
        if (!wdd->ops->start || (!wdd->ops->stop && !wdd->max_hw_heartbeat_ms))
                return -EINVAL;

Do you consider that not important/likely enough to be worth an error
message in the driver?

baruch

[1] https://lwn.net/Articles/627419/

> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>  drivers/watchdog/digicolor_wdt.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/watchdog/digicolor_wdt.c b/drivers/watchdog/digicolor_wdt.c
> index 8af6e9a67d0d..33cda95bd238 100644
> --- a/drivers/watchdog/digicolor_wdt.c
> +++ b/drivers/watchdog/digicolor_wdt.c
> @@ -141,13 +141,7 @@ static int dc_wdt_probe(struct platform_device *pdev)
>  	watchdog_set_restart_priority(&dc_wdt_wdd, 128);
>  	watchdog_init_timeout(&dc_wdt_wdd, timeout, dev);
>  	watchdog_stop_on_reboot(&dc_wdt_wdd);
> -	ret = devm_watchdog_register_device(dev, &dc_wdt_wdd);
> -	if (ret) {
> -		dev_err(dev, "Failed to register watchdog device");
> -		return ret;
> -	}
> -
> -	return 0;
> +	return devm_watchdog_register_device(dev, &dc_wdt_wdd);
>  }
>  
>  static const struct of_device_id dc_wdt_of_match[] = {


-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -