From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 951E120248 for ; Sat, 16 Mar 2019 20:14:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726776AbfCPUON (ORCPT ); Sat, 16 Mar 2019 16:14:13 -0400 Received: from guitar.tcltek.co.il ([192.115.133.116]:56132 "EHLO mx.tkos.co.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726573AbfCPUON (ORCPT ); Sat, 16 Mar 2019 16:14:13 -0400 Received: from tarshish (unknown [10.0.8.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.tkos.co.il (Postfix) with ESMTPS id 90E6D440441; Sat, 16 Mar 2019 22:13:53 +0200 (IST) References: <8e28e622af4143b13a9bfa5c7a6df33d8baf1b5e.camel@perches.com> <87zhpuzjke.fsf@tarshish> User-agent: mu4e 1.0; emacs 26.1 From: Baruch Siach To: Joe Perches Cc: git@vger.kernel.org, Rasmus Villemoes Subject: Re: [PATCH] send-email: don't cc *-by lines with '-' prefix In-reply-to: Date: Sat, 16 Mar 2019 22:14:10 +0200 Message-ID: <87y35eziel.fsf@tarshish> MIME-Version: 1.0 Content-Type: text/plain Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Hi Joe, On Sat, Mar 16 2019, Joe Perches wrote: > On Sat, 2019-03-16 at 21:49 +0200, Baruch Siach wrote: >> On Sat, Mar 16 2019, Joe Perches wrote: >> > On Sat, 2019-03-16 at 21:26 +0200, Baruch Siach wrote: >> > > Since commit ef0cc1df90f6b ("send-email: also pick up cc addresses from >> > > -by trailers") in git version 2.20, git send-email adds to cc list >> > > addresses from all *-by lines. As a side effect a line with >> > > '-Signed-off-by' is now also added to cc. This makes send-email pick >> > > lines from patches that remove patch files from the git repo. This is >> > > common in the Buildroot project that often removes (and adds) patch >> > > files that have 'Signed-off-by' in their patch description part. >> > >> > Why is such a line used and why shouldn't an author >> > of a to-be-removed patch be cc'd? >> >> These lines are currently used because the '^([a-z-]*-by)' regexp >> matches. > > That part I already understood. > > I am not a buildroot user. > >> Buildroot is a tool that build various software packages. The patches >> being removed are usually for packages that Buildroot patches to fix the >> build. These patches are often pulled from upstream git repo of >> respective package. When the package version updates, the patch is >> dropped. >> >> We don't cc patch authors when we add the patch in the first place, >> because the regexp does not match '+Signed-off-by'. I see not reason to >> cc them when we remove the patch. > > So buildroot uses '+Signed-off-by:' and '-Signed-off-by:' lines > for some internal purpose? > > Why? > > https://buildroot.org/downloads/manual/manual.html > > doesn't mention it. No. Patches to the Buildroot project often add or remove patch files. See this one for example: http://lists.busybox.net/pipermail/buildroot/2019-March/244762.html In this case 'git send-email' added Peter Korsgaard to cc because a patch file with his sign-off is removed. (mbox) Adding cc: Baruch Siach from line 'From: Baruch Siach ' (body) Adding cc: Petr Vorel from line 'Cc: Petr Vorel ' (body) Adding cc: Baruch Siach from line 'Signed-off-by: Baruch Siach ' (body) Adding cc: Peter Korsgaard from line '-Signed-off-by: Peter Korsgaard ' The same Buildroot patch also adds a patch file that carries a number of sign-off lines. But 'git send-email didn't add these addresses to cc. In both cases I see not point in adding these addresses to cc, since they have little to do with the Buildroot patch. But only patch removal triggers the regexp. baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -