From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:33084) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwJC7-0001qP-5b for qemu-devel@nongnu.org; Tue, 19 Feb 2019 23:09:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gwJ5N-0002Mr-Tb for qemu-devel@nongnu.org; Tue, 19 Feb 2019 23:02:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42206) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gwJ5N-0002Ma-Lj for qemu-devel@nongnu.org; Tue, 19 Feb 2019 23:02:17 -0500 From: Markus Armbruster References: <1550603704-22474-1-git-send-email-aleksandar.markovic@rt-rk.com> Date: Wed, 20 Feb 2019 05:02:14 +0100 In-Reply-To: <1550603704-22474-1-git-send-email-aleksandar.markovic@rt-rk.com> (Aleksandar Markovic's message of "Tue, 19 Feb 2019 20:15:04 +0100") Message-ID: <87y36bjeex.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] target/mips: implement QMP query-cpu-definitions command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aleksandar Markovic Cc: qemu-devel@nongnu.org, natalia.fursova@ispras.ru, arikalo@wavecomp.com, mdroth@linux.vnet.ibm.com, dovgaluk@ispras.ru, amarkovic@wavecomp.com, marcandre.lureau@redhat.com, philmd@redhat.com, aurelien@aurel32.net Aleksandar Markovic writes: > From: Pavel Dovgalyuk > > This patch enables QMP-based querying of the available CPU types for > MIPS and MIPS64 platforms. > > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Aleksandar Markovic > Reviewed-by: Philippe Mathieu-Daud=C3=A9 > Tested-by: Philippe Mathieu-Daud=C3=A9 Almost identical to the ARM code. Factoring out the common core doesn't seem worth the bother for just two copies. Perhaps if we grow more copies. Reviewed-by: Markus Armbruster