From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751941AbeEGCmy (ORCPT ); Sun, 6 May 2018 22:42:54 -0400 Received: from ozlabs.org ([203.11.71.1]:53639 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751852AbeEGCmw (ORCPT ); Sun, 6 May 2018 22:42:52 -0400 Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au From: Michael Ellerman To: "Naveen N. Rao" , linuxppc-dev@ozlabs.org Cc: linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk Subject: Re: [PATCH 1/6] powerpc/syscalls: Switch trivial cases to SYSCALL_DEFINE In-Reply-To: <1525446080.ih4a1c8i42.naveen@linux.ibm.com> References: <20180502132051.28861-1-mpe@ellerman.id.au> <1525446080.ih4a1c8i42.naveen@linux.ibm.com> Date: Mon, 07 May 2018 12:42:50 +1000 Message-ID: <87y3gw6v9x.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Naveen N. Rao" writes: > Michael Ellerman wrote: >> From: Al Viro >> >> Signed-off-by: Al Viro >> --- >> arch/powerpc/kernel/pci_32.c | 6 +++--- >> arch/powerpc/kernel/pci_64.c | 4 ++-- >> arch/powerpc/mm/subpage-prot.c | 4 +++- >> arch/powerpc/platforms/cell/spu_syscalls.c | 3 ++- >> 4 files changed, 10 insertions(+), 7 deletions(-) >> > > I suppose we can also do this for switch_endian? Yeah. It'd nice to have an automated test that every syscall is available via FTRACE_SYSCALLS, I just haven't got around to writing one. cheers > diff --git a/arch/powerpc/kernel/syscalls.c b/arch/powerpc/kernel/syscalls.c > index 466216506eb2..290265f2700c 100644 > --- a/arch/powerpc/kernel/syscalls.c > +++ b/arch/powerpc/kernel/syscalls.c > @@ -123,7 +123,7 @@ long ppc_fadvise64_64(int fd, int advice, u32 offset_high, u32 offset_low, > (u64)len_high << 32 | len_low, advice); > } > > -long sys_switch_endian(void) > +SYSCALL_DEFINE0(switch_endian) > { > struct thread_info *ti; > > > - Naveen