From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36778) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fByNr-0003gF-RS for qemu-devel@nongnu.org; Fri, 27 Apr 2018 04:05:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fByNq-0008HX-Up for qemu-devel@nongnu.org; Fri, 27 Apr 2018 04:05:35 -0400 From: Markus Armbruster References: <1521452376-25099-1-git-send-email-thuth@redhat.com> <87bme62nu0.fsf@dusky.pond.sub.org> <068649bc-1546-6fc5-3e41-63512196cbf8@redhat.com> <20180427003215.GU29865@localhost.localdomain> <87o9i5uplt.fsf@dusky.pond.sub.org> <9ffb47aa-1fe9-0e0a-3013-bf48ff71d695@redhat.com> Date: Fri, 27 Apr 2018 10:05:19 +0200 In-Reply-To: <9ffb47aa-1fe9-0e0a-3013-bf48ff71d695@redhat.com> (Thomas Huth's message of "Fri, 27 Apr 2018 09:31:25 +0200") Message-ID: <87y3h9qdkw.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [RFC PATCH] tests/device-introspect: Test devices with all machines, not only with "none" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: Eduardo Habkost , qemu-arm@nongnu.org, qemu-ppc@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Thomas Huth writes: > On 27.04.2018 08:31, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >>> On Thu, Apr 26, 2018 at 05:20:25PM +0200, Thomas Huth wrote: >>>> On 26.04.2018 13:45, Markus Armbruster wrote: >>>>> Thomas Huth writes: >>>> [...] >>>>>> @@ -260,6 +263,26 @@ static void test_abstract_interfaces(void) >>>>>> qtest_end(); >>>>>> } >>>>>> >>>>>> +static void add_machine_test_case(const char *mname) >>>>>> +{ >>>>>> + char *path, *args; >>>>>> + >>>>>> + /* Ignore blacklisted machines */ >>>>>> + if (g_str_equal("xenfv", mname) || g_str_equal("xenpv", mname)) { >>>>>> + return; >>>>>> + } >>>>>> + >>>>>> + path = g_strdup_printf("device/introspect/concrete-defaults-%s", mname); >>>>>> + args = g_strdup_printf("-machine %s", mname); >>>>>> + qtest_add_data_func(path, args, test_device_intro_concrete); >>>>> >>>>> This runs test_device_intro_concrete() with "-machine M" for all machine >>>>> types M, in SPEED=slow mode. >>>>> >>>>>> + g_free(path); >>>>>> + >>>>>> + path = g_strdup_printf("device/introspect/concrete-nodefaults-%s", mname); >>>>>> + args = g_strdup_printf("-nodefaults -machine %s", mname); >>>>>> + qtest_add_data_func(path, args, test_device_intro_concrete); >>>>> >>>>> This runs test_device_intro_concrete() with "-nodefaults -machine M" for >>>>> all machine types M, in SPEED=slow mode. >>>>> >>>>> Has "without -nodefaults" exposed additional bugs? >>>> >>>> After testing this with all machines, I had to discover that >>>> "-nodefaults" does not work so easily: A lot of the embedded machines >>>> (especially the ARM machines) simply refuse to work with "-nodefaults" >>>> and exit immediately instead. E.g.: >>>> >>>> $ arm-softmmu/qemu-system-arm -nodefaults -nographic -M n810,accel=qtest >>>> qemu-system-arm: missing SecureDigital device >> >> These are all bugs. --nodefaults is supposed to suppress *optional* >> devices, not mandatory ones. > > Even if we fix all the issues, there is still another cosmetic problem: > Since there are no entries in nd_table[], all the boards with embedded > NICs start to spill out "warning: nic XYZ has no peer". Should we simply > suppress that warning in qtest mode? Makes sense to me.