From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753041AbdKIAtz (ORCPT ); Wed, 8 Nov 2017 19:49:55 -0500 Received: from ozlabs.org ([103.22.144.67]:34569 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752182AbdKIAty (ORCPT ); Wed, 8 Nov 2017 19:49:54 -0500 From: Michael Ellerman To: "Tobin C. Harding" Cc: kernel-hardening@lists.openwall.com, "Jason A. Donenfeld" , "Theodore Ts'o" , Linus Torvalds , Kees Cook , Paolo Bonzini , Tycho Andersen , "Roberts\, William C" , Tejun Heo , Jordan Glover , Greg KH , Petr Mladek , Joe Perches , Ian Campbell , Sergey Senozhatsky , Catalin Marinas , Will Deacon , Steven Rostedt , Chris Fries , Dave Weinstein , Daniel Micay , Djalal Harouni , linux-kernel@vger.kernel.org, Network Development , David Miller Subject: Re: [kernel-hardening] [PATCH v4] scripts: add leaking_addresses.pl In-Reply-To: <20171108224832.GD27823@eros> References: <1510050731-32446-1-git-send-email-me@tobin.cc> <87k1z12cof.fsf@concordia.ellerman.id.au> <20171108224832.GD27823@eros> Date: Thu, 09 Nov 2017 11:49:52 +1100 Message-ID: <87y3ng1djj.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Tobin C. Harding" writes: > On Wed, Nov 08, 2017 at 11:10:56PM +1100, Michael Ellerman wrote: >> "Tobin C. Harding" writes: > [snip] > > Hi Michael, > > I'm working an adding support for ppc64 to leaking_addresses.pl, I've > added the kernel address regular expression that you suggested. Thanks! > I'd like to add the false positive for vsyscall addresses. Excuse my > ignorance but does PowerPC use a constant address range for vsyscall like x86_64 > does? The ppc64 machine I have access to does not output anything for > > $ cat /proc/PID/tasks/PID/smaps or > $ cat /proc/PID/tasks/PID/maps No we only have the vdso style vsyscall, which is mapped at user addresses and is subject to ASLR, so you shouldn't need to worry about it. cheers From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Ellerman Subject: Re: [kernel-hardening] [PATCH v4] scripts: add leaking_addresses.pl Date: Thu, 09 Nov 2017 11:49:52 +1100 Message-ID: <87y3ng1djj.fsf@concordia.ellerman.id.au> References: <1510050731-32446-1-git-send-email-me@tobin.cc> <87k1z12cof.fsf@concordia.ellerman.id.au> <20171108224832.GD27823@eros> Mime-Version: 1.0 Content-Type: text/plain Cc: kernel-hardening@lists.openwall.com, "Jason A. Donenfeld" , Theodore Ts'o , Linus Torvalds , Kees Cook , Paolo Bonzini , Tycho Andersen , "Roberts\, William C" , Tejun Heo , Jordan Glover , Greg KH , Petr Mladek , Joe Perches , Ian Campbell , Sergey Senozhatsky , Catalin Marinas , Will Deacon , Steven Rostedt , Chris Fries , Dave Weinstein Return-path: In-Reply-To: <20171108224832.GD27823@eros> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org "Tobin C. Harding" writes: > On Wed, Nov 08, 2017 at 11:10:56PM +1100, Michael Ellerman wrote: >> "Tobin C. Harding" writes: > [snip] > > Hi Michael, > > I'm working an adding support for ppc64 to leaking_addresses.pl, I've > added the kernel address regular expression that you suggested. Thanks! > I'd like to add the false positive for vsyscall addresses. Excuse my > ignorance but does PowerPC use a constant address range for vsyscall like x86_64 > does? The ppc64 machine I have access to does not output anything for > > $ cat /proc/PID/tasks/PID/smaps or > $ cat /proc/PID/tasks/PID/maps No we only have the vdso style vsyscall, which is mapped at user addresses and is subject to ASLR, so you shouldn't need to worry about it. cheers From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Ellerman In-Reply-To: <20171108224832.GD27823@eros> References: <1510050731-32446-1-git-send-email-me@tobin.cc> <87k1z12cof.fsf@concordia.ellerman.id.au> <20171108224832.GD27823@eros> Date: Thu, 09 Nov 2017 11:49:52 +1100 Message-ID: <87y3ng1djj.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [kernel-hardening] [PATCH v4] scripts: add leaking_addresses.pl To: "Tobin C. Harding" Cc: kernel-hardening@lists.openwall.com, "Jason A. Donenfeld" , Theodore Ts'o , Linus Torvalds , Kees Cook , Paolo Bonzini , Tycho Andersen , "Roberts, William C" , Tejun Heo , Jordan Glover , Greg KH , Petr Mladek , Joe Perches , Ian Campbell , Sergey Senozhatsky , Catalin Marinas , Will Deacon , Steven Rostedt , Chris Fries , Dave Weinstein , Daniel Micay , Djalal Harouni , linux-kernel@vger.kernel.org, Network Development , David Miller List-ID: "Tobin C. Harding" writes: > On Wed, Nov 08, 2017 at 11:10:56PM +1100, Michael Ellerman wrote: >> "Tobin C. Harding" writes: > [snip] > > Hi Michael, > > I'm working an adding support for ppc64 to leaking_addresses.pl, I've > added the kernel address regular expression that you suggested. Thanks! > I'd like to add the false positive for vsyscall addresses. Excuse my > ignorance but does PowerPC use a constant address range for vsyscall like x86_64 > does? The ppc64 machine I have access to does not output anything for > > $ cat /proc/PID/tasks/PID/smaps or > $ cat /proc/PID/tasks/PID/maps No we only have the vdso style vsyscall, which is mapped at user addresses and is subject to ASLR, so you shouldn't need to worry about it. cheers