From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 1/2] drm/i915: Introduce execlist_port_* accessors Date: Fri, 20 Oct 2017 15:53:22 +0300 Message-ID: <87y3o6gev1.fsf@gaia.fi.intel.com> References: <20171019143942.909-1-mika.kuoppala@linux.intel.com> <1508495678.5349.31.camel@linux.intel.com> <87efpyhy4d.fsf@gaia.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id BF9AA6EC44 for ; Fri, 20 Oct 2017 12:54:34 +0000 (UTC) In-Reply-To: <87efpyhy4d.fsf@gaia.fi.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Joonas Lahtinen , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org TWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBsaW51eC5pbnRlbC5jb20+IHdyaXRlczoKCj4g Sm9vbmFzIExhaHRpbmVuIDxqb29uYXMubGFodGluZW5AbGludXguaW50ZWwuY29tPiB3cml0ZXM6 Cj4KPj4gT24gVGh1LCAyMDE3LTEwLTE5IGF0IDE3OjM5ICswMzAwLCBNaWthIEt1b3BwYWxhIHdy b3RlOgo+Pj4gRnJvbTogTWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBpbnRlbC5jb20+Cj4+ PiAKPj4+IEluc3RlYWQgb2YgdHJ1c3RpbmcgdGhhdCBmaXJzdCBhdmFpbGFibGUgcG9ydCBpcyBh dCBpbmRleCAwLAo+Pj4gdXNlIGFjY2Vzc29yIHRvIGhpZGUgdGhpcy4gVGhpcyBpcyBhIHByZXBh cmF0aW9uIGZvciBhCj4+PiBmb2xsb3dpbmcgcGF0Y2hlcyB3aGVyZSBoZWFkIGNhbiBiZSBhdCBh cmJpdHJhcnkgbG9jYXRpb24KPj4+IGluIHRoZSBwb3J0IGFycmF5Lgo+Pj4gCj4+PiB2MjogaW1w cm92ZWQgY29tbWl0IG1lc3NhZ2UsIGVsc3BfcmVhZHkgcmVhZGFiaWxpdHkgKENocmlzKQo+Pj4g djM6IHMvZXhlY2xpc3RfcG9ydF9pbmRleC9leGVjbGlzdF9wb3J0IChDaHJpcykKPj4+IHY0OiBy ZWJhc2UgdG8gbmV3IG5hbWluZwo+Pj4gdjU6IGZpeCBwb3J0X25leHQgaW5kZXhpbmcKPj4+IAo+ Pj4gQ2M6IE1pY2hhxYIgV2luaWFyc2tpIDxtaWNoYWwud2luaWFyc2tpQGludGVsLmNvbT4KPj4+ IENjOiBKb29uYXMgTGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRlbC5jb20+Cj4+ PiBDYzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4+PiBTaWduZWQt b2ZmLWJ5OiBNaWthIEt1b3BwYWxhIDxtaWthLmt1b3BwYWxhQGludGVsLmNvbT4KPj4KPj4gPFNO SVA+Cj4+Cj4+PiBAQCAtNTYxLDE1ICs1NjMsMjAgQEAgc3RhdGljIHZvaWQgcG9ydF9hc3NpZ24o c3RydWN0IGV4ZWNsaXN0X3BvcnQgKnBvcnQsCj4+PiAgc3RhdGljIHZvaWQgaTkxNV9ndWNfZGVx dWV1ZShzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4+PiAgewo+Pj4gIAlzdHJ1Y3Qg aW50ZWxfZW5naW5lX2V4ZWNsaXN0cyAqIGNvbnN0IGV4ZWNsaXN0cyA9ICZlbmdpbmUtPmV4ZWNs aXN0czsKPj4+IC0Jc3RydWN0IGV4ZWNsaXN0X3BvcnQgKnBvcnQgPSBleGVjbGlzdHMtPnBvcnQ7 Cj4+PiArCXN0cnVjdCBleGVjbGlzdF9wb3J0ICpwb3J0Owo+Pj4gIAlzdHJ1Y3QgZHJtX2k5MTVf Z2VtX3JlcXVlc3QgKmxhc3QgPSBOVUxMOwo+Pj4gLQljb25zdCBzdHJ1Y3QgZXhlY2xpc3RfcG9y dCAqIGNvbnN0IGxhc3RfcG9ydCA9Cj4+PiAtCQkmZXhlY2xpc3RzLT5wb3J0W2V4ZWNsaXN0cy0+ cG9ydF9tYXNrXTsKPj4+ICAJYm9vbCBzdWJtaXQgPSBmYWxzZTsKPj4+ICAJc3RydWN0IHJiX25v ZGUgKnJiOwo+Pj4gIAo+Pj4gLQlpZiAocG9ydF9pc3NldChwb3J0KSkKPj4+IC0JCXBvcnQrKzsK Pj4+ICsJcG9ydCA9IGV4ZWNsaXN0c19wb3J0X2hlYWQoZXhlY2xpc3RzKTsKPj4+ICsKPj4+ICsJ LyoKPj4+ICsJICogV2UgZG9uJ3QgY29hbGVzY2UgaW50byBsYXN0IHN1Ym1pdHRlZCBwb3J0IHdp dGggZ3VjLgo+Pj4gKwkgKiBGaW5kIGZpcnN0IGZyZWUgcG9ydCwgdGhpcyBpcyBzYWZlIGFzIHdl IGRvbnQgZGVxdWV1ZSB3aXRob3V0Cj4+PiArCSAqIGF0bGVhc3QgbGFzdCBwb3J0IGZyZWUuCj4+ Cj4+ICJhdCBsZWFzdCIgKyAidGhlIgo+Pgo+PiA8U05JUD4KPj4KPj4+IEBAIC01NTcsNiArNTU3 LDkgQEAgc3RhdGljIHZvaWQgZXhlY2xpc3RzX2RlcXVldWUoc3RydWN0IGludGVsX2VuZ2luZV9j cyAqZW5naW5lKQo+Pj4gIAlpZiAoIXJiKQo+Pj4gIAkJZ290byB1bmxvY2s7Cj4+PiAgCj4+PiAr CXBvcnQgPSBleGVjbGlzdHNfcG9ydF9oZWFkKGV4ZWNsaXN0cyk7Cj4+PiArCWxhc3QgPSBwb3J0 X3JlcXVlc3QocG9ydCk7Cj4+PiArCj4+PiAgCWlmIChsYXN0KSB7Cj4+PiAgCQkvKgo+Pj4gIAkJ ICogRG9uJ3QgcmVzdWJtaXQgb3Igc3dpdGNoIHVudGlsIGFsbCBvdXRzdGFuZGluZwo+Pj4gQEAg LTU2NCw3ICs1NjcsNyBAQCBzdGF0aWMgdm9pZCBleGVjbGlzdHNfZGVxdWV1ZShzdHJ1Y3QgaW50 ZWxfZW5naW5lX2NzICplbmdpbmUpCj4+PiAgCQkgKiBrbm93IHRoZSBuZXh0IHByZWVtcHRpb24g c3RhdHVzIHdlIHNlZSBjb3JyZXNwb25kcwo+Pj4gIAkJICogdG8gdGhpcyBFTFNQIHVwZGF0ZS4K Pj4+ICAJCSAqLwo+Pj4gLQkJaWYgKHBvcnRfY291bnQoJnBvcnRbMF0pID4gMSkKPj4+ICsJCWlm IChwb3J0X2NvdW50KHBvcnQpID4gMSkKPj4+ICAJCQlnb3RvIHVubG9jazsKPj4+ICAKPj4+ICAJ CWlmIChjYW5fcHJlZW1wdChlbmdpbmUpICYmCj4+PiBAQCAtNTk4LDcgKzYwMSw3IEBAIHN0YXRp YyB2b2lkIGV4ZWNsaXN0c19kZXF1ZXVlKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkK Pj4+ICAJCQkgKiB0aGUgZHJpdmVyIGlzIHVuYWJsZSB0byBrZWVwIHVwIHRoZSBzdXBwbHkgb2Yg bmV3Cj4+PiAgCQkJICogd29yaykuCj4+PiAgCQkJICovCj4+PiAtCQkJaWYgKHBvcnRfY291bnQo JnBvcnRbMV0pKQo+Pj4gKwkJCWlmIChwb3J0X2NvdW50KGV4ZWNsaXN0c19wb3J0X25leHQoZXhl Y2xpc3RzLCBwb3J0KSkpCj4+PiAgCQkJCWdvdG8gdW5sb2NrOwo+Pj4gIAo+Pj4gIAkJCS8qIFdh SWRsZUxpdGVSZXN0b3JlOmJkdyxza2wKPj4+IEBAIC02MzQsNyArNjM3LDcgQEAgc3RhdGljIHZv aWQgZXhlY2xpc3RzX2RlcXVldWUoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+Pj4g IAkJCQkgKiBjb21iaW5lIHRoaXMgcmVxdWVzdCB3aXRoIHRoZSBsYXN0LCB0aGVuIHdlCj4+PiAg CQkJCSAqIGFyZSBkb25lLgo+Pj4gIAkJCQkgKi8KPj4+IC0JCQkJaWYgKHBvcnQgPT0gbGFzdF9w b3J0KSB7Cj4+PiArCQkJCWlmIChwb3J0ID09IGV4ZWNsaXN0c19wb3J0X3RhaWwoZXhlY2xpc3Rz KSkgewo+Pj4gIAkJCQkJX19saXN0X2RlbF9tYW55KCZwLT5yZXF1ZXN0cywKPj4+ICAJCQkJCQkJ JnJxLT5wcmlvdHJlZS5saW5rKTsKPj4KPj4gTm90aGluZyB0byBmaXggcmVsYXRlZCB0byB0aGlz IHBhdGNoLCBidXQgSSB3YXMgc3VyZSBuZXh0IGh1bmsgd2FzCj4+IGdvaW5nIHRvIGVzY2FwZSBt eSBzY3JlZW4gOikgTWF5YmUgd2UgbmVlZCB0byBjdXQgdGhlIGluZGVudHMgYSBiaXQuCj4+Cj4K PiBJIGhhdmUgbm90aWNlZCB0aGUgc2FtZS4gQnV0IEkgZGlkbid0IGZlZWwgbGlrZSBhdHRhY2tp bmcgdGhpcyBsb29wCj4gdW50aWwgZXZlcnl0aGluZyBpcyBpbiBwbGFjZSBhbmQgd29ya2luZy4K Pgo+Pj4gQEAgLTg5MCw3ICs5MDIsNyBAQCBzdGF0aWMgdm9pZCBpbnRlbF9scmNfaXJxX2hhbmRs ZXIodW5zaWduZWQgbG9uZyBkYXRhKQo+Pj4gIAkJCX0KPj4+ICAKPj4+ICAJCQkvKiBBZnRlciB0 aGUgZmluYWwgZWxlbWVudCwgdGhlIGh3IHNob3VsZCBiZSBpZGxlICovCj4+PiAtCQkJR0VNX0JV R19PTihwb3J0X2NvdW50KHBvcnQpID09IDAgJiYKPj4+ICsJCQlHRU1fQlVHX09OKHBvcnRfY291 bnQoZXhlY2xpc3RzX3BvcnRfaGVhZChleGVjbGlzdHMpKSA9PSAwICYmCj4+PiAgCQkJCSAgICEo c3RhdHVzICYgR0VOOF9DVFhfU1RBVFVTX0FDVElWRV9JRExFKSk7Cj4+Cj4+IFdoeSBkaWQgeW91 IHN0b3AgdHJ1c3RpbmcgcG9ydCB2YXJpYWJsZSBoZXJlPwo+Pgo+Cj4gV2UgZGlkIGFzc2luZyBp dCBwcmUgbG9vcCBiZWZvcmUuIE5vdyB3ZSBkbyBpdCBpbnNpZGUgdGhlIGxvb3AuIEFsc28KPiBJ IHRob3VnaHQgSSBtYWRlIGEgZmF2b3VyIGZvciByZWFkZXIgKGFuZCBmb3IgdGhlIGJ1ZyB0cmlh Z2VyCj4gYXMgR0VNX0JVR19PTiBtaWdodCBzb29uIHNob3cgY29uZGl0aW9uIGluIGRtZXNnKSAK PiB0byBub3RlIHRoYXQgaXQgaXMgYWx3YXlzIHRoZSBmaXJzdCBwb3J0IGNvdW50IHdlIGFzc2Vy dAo+IGZvciBpZGxlbmVzcy4KCk15IGFwb2xvZ2llcy4gTm93IHJlcmVhZGluZyB0aGlzIGl0IGlz IGluZGVlZCB0aGF0IGxhc3QgcG9ydApjb3VudCB3ZSBuZWVkIHRvIGNoZWNrIGZvciBodyBpZGxl bmVzcy4KCi1NaWthCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eAo=