From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753070AbdADJQm (ORCPT ); Wed, 4 Jan 2017 04:16:42 -0500 Received: from mail-wj0-f195.google.com ([209.85.210.195]:34482 "EHLO mail-wj0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752283AbdADJQj (ORCPT ); Wed, 4 Jan 2017 04:16:39 -0500 From: Ioan-Adrian Ratiu To: Takashi Iwai Cc: perex@perex.cz, o-takashi@sakamocchi.jp, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] ALSA: usb-audio: Fix irq/process data synchronization In-Reply-To: References: <20170102155031.3638-1-adi@adirat.com> <20170102155031.3638-2-adi@adirat.com> Date: Wed, 04 Jan 2017 11:15:58 +0200 Message-ID: <87y3yrdw35.fsf@adiPC.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 04 Jan 2017, Takashi Iwai wrote: > On Mon, 02 Jan 2017 16:50:30 +0100, > Ioan-Adrian Ratiu wrote: >> >> --- a/sound/usb/pcm.c >> +++ b/sound/usb/pcm.c > (snip) >> @@ -850,7 +850,7 @@ static int snd_usb_pcm_prepare(struct snd_pcm_substream *substream) >> /* for playback, submit the URBs now; otherwise, the first hwptr_done >> * updates for all URBs would happen at the same time when starting */ >> if (subs->direction == SNDRV_PCM_STREAM_PLAYBACK) >> - ret = start_endpoints(subs, true); >> + return start_endpoints(subs); > > Here you miss the unlock below. > >> >> unlock: >> snd_usb_unlock_shutdown(subs->stream->chip); > > ... and this must be the reason of the hang up at disconnection, where > the driver ways forever at wait_event() in usb_audio_disconnect(). > > Could you fix this and resubmit v3? Other than that, it looks OK. Sure, I'll resubmit v3 by tonight hopefully. Thank you for taking a look at this, I didn't have a chance to look it again since I posted v2. Ionel > > > thanks, > > Takashi