From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753628AbcGYSfF (ORCPT ); Mon, 25 Jul 2016 14:35:05 -0400 Received: from out01.mta.xmission.com ([166.70.13.231]:43592 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753174AbcGYSe7 (ORCPT ); Mon, 25 Jul 2016 14:34:59 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: Stanislav Kinsburskiy Cc: , , , , , , , , , , , , , , References: <20160712152940.24895.61315.stgit@localhost.localdomain> <8a863273-c571-63d6-c0c3-637dff5645a3@virtuozzo.com> Date: Mon, 25 Jul 2016 13:21:51 -0500 In-Reply-To: <8a863273-c571-63d6-c0c3-637dff5645a3@virtuozzo.com> (Stanislav Kinsburskiy's message of "Mon, 25 Jul 2016 17:48:33 +0200") Message-ID: <87y44pbmtc.fsf@x220.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1bRkiJ-0005ui-0h;;;mid=<87y44pbmtc.fsf@x220.int.ebiederm.org>;;;hst=in02.mta.xmission.com;;;ip=67.3.204.119;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX19TWfNijUbxRXLmE9QXlSxxJ885d9OTnSo= X-SA-Exim-Connect-IP: 67.3.204.119 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.7 XMSubLong Long Subject * 0.0 TVD_RCVD_IP Message was received from an IP address * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5000] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa07 1397; Body=1 Fuz1=1 Fuz2=1] * 1.2 XMSubMetaSxObfu_02 Obfuscated Sexy AdVerb * 1.0 XMSubMetaSx_00 1+ Sexy Words X-Spam-DCC: XMission; sa07 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: **;Stanislav Kinsburskiy X-Spam-Relay-Country: X-Spam-Timing: total 551 ms - load_scoreonly_sql: 0.04 (0.0%), signal_user_changed: 3.9 (0.7%), b_tie_ro: 3.0 (0.5%), parse: 0.69 (0.1%), extract_message_metadata: 14 (2.5%), get_uri_detail_list: 1.17 (0.2%), tests_pri_-1000: 7 (1.2%), tests_pri_-950: 1.14 (0.2%), tests_pri_-900: 0.98 (0.2%), tests_pri_-400: 21 (3.8%), check_bayes: 20 (3.6%), b_tokenize: 5 (1.0%), b_tok_get_all: 8 (1.4%), b_comp_prob: 1.86 (0.3%), b_tok_touch_all: 3.0 (0.5%), b_finish: 0.63 (0.1%), tests_pri_0: 496 (89.9%), check_dkim_signature: 0.47 (0.1%), check_dkim_adsp: 2.8 (0.5%), tests_pri_500: 5 (0.9%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH] prctl: remove one-shot limitation for changing exe link X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Stanislav Kinsburskiy writes: > Gentlemen, > > Looks like there are no objections to this patch. There has been objection. The only justification for the change that has been put forward is someone doing a restore lazily. I don't see a reason why you can't call prctl_set_mm_exe_file until you have the file in place instead of a place holder that sounds like a trivial solution to any restore issues. The truth is an unlimited settable exe link is essentially meaningless, as you can't depend on it for anything. One shot seems the best compromise I have seen put forward between the definite checkpoint/restart requirement to set the this value and the general need to have something that makes sense and people can depend on for system management. Also there is a big fat bug in prctl_set_mm_exe_file. It doesn't validate that the new file is a actually mmaped executable. We would definitely need that to be fixed before even considering removing the limit. Right now all I see is people involved in the implementation details of their own little feature So for the patch I am responding to: Nacked-by: "Eric W. Biederman" Plus the merge window is open so no one is taking any patches right now. It is the time to take what has already been staged and get that code merged. Eric