From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 02/16] drm/i915: Make {vlv, chv}_{disable, update}_pll() more similar Date: Wed, 30 Mar 2016 16:31:04 +0300 Message-ID: <87y490149z.fsf@intel.com> References: <1458052809-23426-1-git-send-email-ville.syrjala@linux.intel.com> <1458052809-23426-3-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 813E36E7F4 for ; Wed, 30 Mar 2016 13:31:09 +0000 (UTC) In-Reply-To: <1458052809-23426-3-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org Cc: Deepak M List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAxNSBNYXIgMjAxNiwgdmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20gd3JvdGU6 Cj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4K Pgo+IFRoZSBWTFYgYW5kIENIViBEUExMIGRpc2FibGUgYW5kIHVwZGF0ZSBhcmUgYWxtb3N0IGlk ZW50aWNhbCBpbgo+IGhvdyB0aGUgRFBMTC9EUExMX01EIHJlZ2lzdGVycyBuZWVkIHRvIGJlIHNl dCB1cC4gQnV0IHRoZSBjb2RlCj4gbG9va3MgbW9yZSBkaWZmZXJlbnQgdGhhbiBpdCByZWFsbHkg aXMuIFRyeSB0byBicmluZyB0aGVtIGludG8KPiBsaW5lLgo+Cj4gdjI6IHMvY2h2X3VwZGF0ZV9w bGwvY2h2X2NvbXB1dGVfZHBsbC8KPgo+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8 dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2Rpc3BsYXkuYyB8IDYzICsrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0t LS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMjUgaW5zZXJ0aW9ucygrKSwgMzggZGVsZXRpb25zKC0p Cj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXggMjI5MzBmMDU0NTdj Li40MTRlZDUwMDdlNjAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4g QEAgLTE3NTksMTYgKzE3NTksMTMgQEAgc3RhdGljIHZvaWQgdmx2X2Rpc2FibGVfcGxsKHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgZW51bSBwaXBlIHBpcGUpCj4gIAkvKiBNYWtl IHN1cmUgdGhlIHBpcGUgaXNuJ3Qgc3RpbGwgcmVseWluZyBvbiB1cyAqLwo+ICAJYXNzZXJ0X3Bp cGVfZGlzYWJsZWQoZGV2X3ByaXYsIHBpcGUpOwo+ICAKPiAtCS8qCj4gLQkgKiBMZWF2ZSBpbnRl Z3JhdGVkIGNsb2NrIHNvdXJjZSBhbmQgcmVmZXJlbmNlIGNsb2NrIGVuYWJsZWQgZm9yIHBpcGUg Qi4KPiAtCSAqIFRoZSBsYXR0ZXIgaXMgbmVlZGVkIGZvciBWR0EgaG90cGx1ZyAvIG1hbnVhbCBk ZXRlY3Rpb24uCj4gLQkgKi8KClNvLCB5b3UgY2hhbmdlIHRoaXMgdG8ga2VlcCB0aGUgcmVmZXJl bmNlIGNsb2NrIGVuYWJsZWQgZm9yIGJvdGgKcGlwZXMuIERlc2VydmVzIGEgbWVudGlvbiBpbiB0 aGUgY29tbWl0IG1lc3NhZ2UuIEFGQUlDVCBpdCdzIHRoZSBvbmx5CmZ1bmN0aW9uYWwgY2hhbmdl IGluIHRoZSBwYXRjaC4KCk90aGVyIHRoYW4gdGhhdCwKClJldmlld2VkLWJ5OiBKYW5pIE5pa3Vs YSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgoKCj4gLQl2YWwgPSBEUExMX1ZHQV9NT0RFX0RJUzsK PiAtCWlmIChwaXBlID09IFBJUEVfQikKPiAtCQl2YWwgPSBEUExMX0lOVEVHUkFURURfQ1JJX0NM S19WTFYgfCBEUExMX1JFRl9DTEtfRU5BQkxFX1ZMVjsKPiArCXZhbCA9IERQTExfSU5URUdSQVRF RF9SRUZfQ0xLX1ZMViB8Cj4gKwkJRFBMTF9SRUZfQ0xLX0VOQUJMRV9WTFYgfCBEUExMX1ZHQV9N T0RFX0RJUzsKPiArCWlmIChwaXBlICE9IFBJUEVfQSkKPiArCQl2YWwgfD0gRFBMTF9JTlRFR1JB VEVEX0NSSV9DTEtfVkxWOwo+ICsKPiAgCUk5MTVfV1JJVEUoRFBMTChwaXBlKSwgdmFsKTsKPiAg CVBPU1RJTkdfUkVBRChEUExMKHBpcGUpKTsKPiAtCj4gIH0KPiAgCj4gIHN0YXRpYyB2b2lkIGNo dl9kaXNhYmxlX3BsbChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGVudW0gcGlw ZSBwaXBlKQo+IEBAIC0xNzc5LDExICsxNzc2LDExIEBAIHN0YXRpYyB2b2lkIGNodl9kaXNhYmxl X3BsbChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGVudW0gcGlwZSBwaXBlKQo+ ICAJLyogTWFrZSBzdXJlIHRoZSBwaXBlIGlzbid0IHN0aWxsIHJlbHlpbmcgb24gdXMgKi8KPiAg CWFzc2VydF9waXBlX2Rpc2FibGVkKGRldl9wcml2LCBwaXBlKTsKPiAgCj4gLQkvKiBTZXQgUExM IGVuID0gMCAqLwo+ICAJdmFsID0gRFBMTF9TU0NfUkVGX0NMS19DSFYgfAo+ICAJCURQTExfUkVG X0NMS19FTkFCTEVfVkxWIHwgRFBMTF9WR0FfTU9ERV9ESVM7Cj4gIAlpZiAocGlwZSAhPSBQSVBF X0EpCj4gIAkJdmFsIHw9IERQTExfSU5URUdSQVRFRF9DUklfQ0xLX1ZMVjsKPiArCj4gIAlJOTE1 X1dSSVRFKERQTEwocGlwZSksIHZhbCk7Cj4gIAlQT1NUSU5HX1JFQUQoRFBMTChwaXBlKSk7Cj4g IAo+IEBAIC03MjQwLDI0ICs3MjM3LDI3IEBAIHZvaWQgaW50ZWxfZHBfc2V0X21fbihzdHJ1Y3Qg aW50ZWxfY3J0YyAqY3J0YywgZW51bSBsaW5rX21fbl9zZXQgbV9uKQo+ICBzdGF0aWMgdm9pZCB2 bHZfY29tcHV0ZV9kcGxsKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+ICAJCQkgICAgIHN0cnVj dCBpbnRlbF9jcnRjX3N0YXRlICpwaXBlX2NvbmZpZykKPiAgewo+IC0JdTMyIGRwbGwsIGRwbGxf bWQ7Cj4gKwlwaXBlX2NvbmZpZy0+ZHBsbF9od19zdGF0ZS5kcGxsID0gRFBMTF9JTlRFR1JBVEVE X1JFRl9DTEtfVkxWIHwKPiArCQlEUExMX1JFRl9DTEtfRU5BQkxFX1ZMViB8IERQTExfVkdBX01P REVfRElTIHwKPiArCQlEUExMX1ZDT19FTkFCTEUgfCBEUExMX0VYVF9CVUZGRVJfRU5BQkxFX1ZM VjsKPiArCWlmIChjcnRjLT5waXBlICE9IFBJUEVfQSkKPiArCQlwaXBlX2NvbmZpZy0+ZHBsbF9o d19zdGF0ZS5kcGxsIHw9IERQTExfSU5URUdSQVRFRF9DUklfQ0xLX1ZMVjsKPiAgCj4gLQkvKgo+ IC0JICogRW5hYmxlIERQSU8gY2xvY2sgaW5wdXQuIFdlIHNob3VsZCBuZXZlciBkaXNhYmxlIHRo ZSByZWZlcmVuY2UKPiAtCSAqIGNsb2NrIGZvciBwaXBlIEIsIHNpbmNlIFZHQSBob3RwbHVnIC8g bWFudWFsIGRldGVjdGlvbiBkZXBlbmRzCj4gLQkgKiBvbiBpdC4KPiAtCSAqLwo+IC0JZHBsbCA9 IERQTExfRVhUX0JVRkZFUl9FTkFCTEVfVkxWIHwgRFBMTF9SRUZfQ0xLX0VOQUJMRV9WTFYgfAo+ IC0JCURQTExfVkdBX01PREVfRElTIHwgRFBMTF9JTlRFR1JBVEVEX1JFRl9DTEtfVkxWOwo+IC0J LyogV2Ugc2hvdWxkIG5ldmVyIGRpc2FibGUgdGhpcywgc2V0IGl0IGhlcmUgZm9yIHN0YXRlIHRy YWNraW5nICovCj4gLQlpZiAoY3J0Yy0+cGlwZSA9PSBQSVBFX0IpCj4gLQkJZHBsbCB8PSBEUExM X0lOVEVHUkFURURfQ1JJX0NMS19WTFY7Cj4gLQlkcGxsIHw9IERQTExfVkNPX0VOQUJMRTsKPiAt CXBpcGVfY29uZmlnLT5kcGxsX2h3X3N0YXRlLmRwbGwgPSBkcGxsOwo+ICsJcGlwZV9jb25maWct PmRwbGxfaHdfc3RhdGUuZHBsbF9tZCA9Cj4gKwkJKHBpcGVfY29uZmlnLT5waXhlbF9tdWx0aXBs aWVyIC0gMSkgPDwgRFBMTF9NRF9VRElfTVVMVElQTElFUl9TSElGVDsKPiArfQo+ICsKPiArc3Rh dGljIHZvaWQgY2h2X2NvbXB1dGVfZHBsbChzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPiArCQkJ ICAgICBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9jb25maWcpCj4gK3sKPiArCXBpcGVf Y29uZmlnLT5kcGxsX2h3X3N0YXRlLmRwbGwgPSBEUExMX1NTQ19SRUZfQ0xLX0NIViB8Cj4gKwkJ RFBMTF9SRUZfQ0xLX0VOQUJMRV9WTFYgfCBEUExMX1ZHQV9NT0RFX0RJUyB8Cj4gKwkJRFBMTF9W Q09fRU5BQkxFOwo+ICsJaWYgKGNydGMtPnBpcGUgIT0gUElQRV9BKQo+ICsJCXBpcGVfY29uZmln LT5kcGxsX2h3X3N0YXRlLmRwbGwgfD0gRFBMTF9JTlRFR1JBVEVEX0NSSV9DTEtfVkxWOwo+ICAK PiAtCWRwbGxfbWQgPSAocGlwZV9jb25maWctPnBpeGVsX211bHRpcGxpZXIgLSAxKQo+IC0JCTw8 IERQTExfTURfVURJX01VTFRJUExJRVJfU0hJRlQ7Cj4gLQlwaXBlX2NvbmZpZy0+ZHBsbF9od19z dGF0ZS5kcGxsX21kID0gZHBsbF9tZDsKPiArCXBpcGVfY29uZmlnLT5kcGxsX2h3X3N0YXRlLmRw bGxfbWQgPQo+ICsJCShwaXBlX2NvbmZpZy0+cGl4ZWxfbXVsdGlwbGllciAtIDEpIDw8IERQTExf TURfVURJX01VTFRJUExJRVJfU0hJRlQ7Cj4gIH0KPiAgCj4gIHN0YXRpYyB2b2lkIHZsdl9wcmVw YXJlX3BsbChzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPiBAQCAtNzM1MSwxOSArNzM1MSw2IEBA IHN0YXRpYyB2b2lkIHZsdl9wcmVwYXJlX3BsbChzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPiAg CW11dGV4X3VubG9jaygmZGV2X3ByaXYtPnNiX2xvY2spOwo+ICB9Cj4gIAo+IC1zdGF0aWMgdm9p ZCBjaHZfY29tcHV0ZV9kcGxsKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+IC0JCQkgICAgIHN0 cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpwaXBlX2NvbmZpZykKPiAtewo+IC0JcGlwZV9jb25maWct PmRwbGxfaHdfc3RhdGUuZHBsbCA9IERQTExfU1NDX1JFRl9DTEtfQ0hWIHwKPiAtCQlEUExMX1JF Rl9DTEtfRU5BQkxFX1ZMViB8IERQTExfVkdBX01PREVfRElTIHwKPiAtCQlEUExMX1ZDT19FTkFC TEU7Cj4gLQlpZiAoY3J0Yy0+cGlwZSAhPSBQSVBFX0EpCj4gLQkJcGlwZV9jb25maWctPmRwbGxf aHdfc3RhdGUuZHBsbCB8PSBEUExMX0lOVEVHUkFURURfQ1JJX0NMS19WTFY7Cj4gLQo+IC0JcGlw ZV9jb25maWctPmRwbGxfaHdfc3RhdGUuZHBsbF9tZCA9Cj4gLQkJKHBpcGVfY29uZmlnLT5waXhl bF9tdWx0aXBsaWVyIC0gMSkgPDwgRFBMTF9NRF9VRElfTVVMVElQTElFUl9TSElGVDsKPiAtfQo+ IC0KPiAgc3RhdGljIHZvaWQgY2h2X3ByZXBhcmVfcGxsKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRj LAo+ICAJCQkgICAgY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKnBpcGVfY29uZmlnKQo+ ICB7CgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVy Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdm eCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=