From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753992AbbLSN0d (ORCPT ); Sat, 19 Dec 2015 08:26:33 -0500 Received: from smtp05.smtpout.orange.fr ([80.12.242.127]:56310 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753690AbbLSN0b (ORCPT ); Sat, 19 Dec 2015 08:26:31 -0500 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Sat, 19 Dec 2015 14:26:29 +0100 X-ME-IP: 109.222.211.19 From: Robert Jarzmik To: Sergei Ianovich Cc: linux-kernel@vger.kernel.org, Kevin Hilman , Arnd Bergmann , linux-arm-kernel@lists.infradead.org (moderated list:ARM PORT), linux-serial@vger.kernel.org (open list:SERIAL DRIVERS) Subject: Re: [PATCH v4 1/2] serial: rewrite pxa2xx-uart to use 8250_core References: <1387309071-22382-1-git-send-email-ynvich@gmail.com> <1449700088-28076-1-git-send-email-ynvich@gmail.com> <1449700088-28076-2-git-send-email-ynvich@gmail.com> <8737uyhaji.fsf@belgarion.home> X-URL: http://belgarath.falguerolles.org/ Date: Sat, 19 Dec 2015 14:26:28 +0100 In-Reply-To: <8737uyhaji.fsf@belgarion.home> (Robert Jarzmik's message of "Sat, 19 Dec 2015 13:45:21 +0100") Message-ID: <87y4cqfu2j.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Robert Jarzmik writes: > Sergei Ianovich writes: > >> pxa2xx-uart was a separate uart platform driver. It was declaring >> the same device names and numbers as 8250 driver. As a result, >> it was impossible to use 8250 driver on PXA SoCs. >> >> Upon closer examination pxa2xx-uart turned out to be a clone of >> 8250_core driver. >> >> Workaround for Erratum #19 according to Marvel(R) PXA270M Processor >> Specification Update (April 19, 2010) is dropped. 8250_core reads >> from FIFO immediately after checking DR bit in LSR. >> >> Signed-off-by: Sergei Ianovich >> Reviewed-by: Heikki Krogerus >> Reviewed-by: James Cameron >> Acked-by: Greg Kroah-Hartman > Tested-by: Robert Jarzmik Shrunk the list, the following is rather mach-pxa specific. Actually there is a small glitch ... Have a look at arch/arm/mach-pxa/viper.c, line 490: #ifndef CONFIG_SERIAL_PXA ... But that can be handled in an subsequent patch to keep your acks and reviews. Cheers. -- Robert From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Jarzmik Subject: Re: [PATCH v4 1/2] serial: rewrite pxa2xx-uart to use 8250_core Date: Sat, 19 Dec 2015 14:26:28 +0100 Message-ID: <87y4cqfu2j.fsf@belgarion.home> References: <1387309071-22382-1-git-send-email-ynvich@gmail.com> <1449700088-28076-1-git-send-email-ynvich@gmail.com> <1449700088-28076-2-git-send-email-ynvich@gmail.com> <8737uyhaji.fsf@belgarion.home> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <8737uyhaji.fsf@belgarion.home> (Robert Jarzmik's message of "Sat, 19 Dec 2015 13:45:21 +0100") Sender: linux-kernel-owner@vger.kernel.org To: Sergei Ianovich Cc: linux-kernel@vger.kernel.org, Kevin Hilman , Arnd Bergmann , "moderated list:ARM PORT" , "open list:SERIAL DRIVERS" List-Id: linux-serial@vger.kernel.org Robert Jarzmik writes: > Sergei Ianovich writes: > >> pxa2xx-uart was a separate uart platform driver. It was declaring >> the same device names and numbers as 8250 driver. As a result, >> it was impossible to use 8250 driver on PXA SoCs. >> >> Upon closer examination pxa2xx-uart turned out to be a clone of >> 8250_core driver. >> >> Workaround for Erratum #19 according to Marvel(R) PXA270M Processor >> Specification Update (April 19, 2010) is dropped. 8250_core reads >> from FIFO immediately after checking DR bit in LSR. >> >> Signed-off-by: Sergei Ianovich >> Reviewed-by: Heikki Krogerus >> Reviewed-by: James Cameron >> Acked-by: Greg Kroah-Hartman > Tested-by: Robert Jarzmik Shrunk the list, the following is rather mach-pxa specific. Actually there is a small glitch ... Have a look at arch/arm/mach-pxa/viper.c, line 490: #ifndef CONFIG_SERIAL_PXA ... But that can be handled in an subsequent patch to keep your acks and reviews. Cheers. -- Robert From mboxrd@z Thu Jan 1 00:00:00 1970 From: robert.jarzmik@free.fr (Robert Jarzmik) Date: Sat, 19 Dec 2015 14:26:28 +0100 Subject: [PATCH v4 1/2] serial: rewrite pxa2xx-uart to use 8250_core In-Reply-To: <8737uyhaji.fsf@belgarion.home> (Robert Jarzmik's message of "Sat, 19 Dec 2015 13:45:21 +0100") References: <1387309071-22382-1-git-send-email-ynvich@gmail.com> <1449700088-28076-1-git-send-email-ynvich@gmail.com> <1449700088-28076-2-git-send-email-ynvich@gmail.com> <8737uyhaji.fsf@belgarion.home> Message-ID: <87y4cqfu2j.fsf@belgarion.home> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Robert Jarzmik writes: > Sergei Ianovich writes: > >> pxa2xx-uart was a separate uart platform driver. It was declaring >> the same device names and numbers as 8250 driver. As a result, >> it was impossible to use 8250 driver on PXA SoCs. >> >> Upon closer examination pxa2xx-uart turned out to be a clone of >> 8250_core driver. >> >> Workaround for Erratum #19 according to Marvel(R) PXA270M Processor >> Specification Update (April 19, 2010) is dropped. 8250_core reads >> from FIFO immediately after checking DR bit in LSR. >> >> Signed-off-by: Sergei Ianovich >> Reviewed-by: Heikki Krogerus >> Reviewed-by: James Cameron >> Acked-by: Greg Kroah-Hartman > Tested-by: Robert Jarzmik Shrunk the list, the following is rather mach-pxa specific. Actually there is a small glitch ... Have a look at arch/arm/mach-pxa/viper.c, line 490: #ifndef CONFIG_SERIAL_PXA ... But that can be handled in an subsequent patch to keep your acks and reviews. Cheers. -- Robert