From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57848)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1Zz0UO-0000gC-9T
	for qemu-devel@nongnu.org; Wed, 18 Nov 2015 06:01:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1Zz0UK-00026O-6D
	for qemu-devel@nongnu.org; Wed, 18 Nov 2015 06:01:24 -0500
Received: from mx1.redhat.com ([209.132.183.28]:45360)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1Zz0UK-00026J-0n
	for qemu-devel@nongnu.org; Wed, 18 Nov 2015 06:01:20 -0500
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <1447751311-2317-4-git-send-email-den@openvz.org> (Denis
	V. Lunev's message of "Tue, 17 Nov 2015 12:08:23 +0300")
References: <1447751311-2317-1-git-send-email-den@openvz.org>
	<1447751311-2317-4-git-send-email-den@openvz.org>
Date: Wed, 18 Nov 2015 12:01:05 +0100
Message-ID: <87y4dvo9la.fsf@emacs.mitica>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 03/11] snapshot: create
	bdrv_all_delete_snapshot helper
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Denis V. Lunev" <den@openvz.org>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, stefanha@redhat.com

"Denis V. Lunev" <den@openvz.org> wrote:
> to delete snapshots from all loaded block drivers.
>
> The patch also ensures proper locking.
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Reviewed-by: Fam Zheng <famz@redhat.com>
> CC: Juan Quintela <quintela@redhat.com>
> CC: Kevin Wolf <kwolf@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>

I will still suggest to rename it to

brdv_delete_all_snapshots()

or

bdrv_delete_snapshot_everywhere()

that makes is more clear what it does.


A big THANKS for removing this from the migration side of the equation
O:-)

Later, Juan.