From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39622)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZwnWY-0003vI-Dl
	for qemu-devel@nongnu.org; Thu, 12 Nov 2015 03:46:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZwnWV-00058w-67
	for qemu-devel@nongnu.org; Thu, 12 Nov 2015 03:46:30 -0500
Received: from mx1.redhat.com ([209.132.183.28]:43206)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZwnWV-00058m-1V
	for qemu-devel@nongnu.org; Thu, 12 Nov 2015 03:46:27 -0500
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	by mx1.redhat.com (Postfix) with ESMTPS id 9E7DE80081
	for <qemu-devel@nongnu.org>; Thu, 12 Nov 2015 08:46:26 +0000 (UTC)
From: Markus Armbruster <armbru@redhat.com>
References: <1447299376-21252-1-git-send-email-bsd@redhat.com>
	<1447299376-21252-3-git-send-email-bsd@redhat.com>
Date: Thu, 12 Nov 2015 09:46:24 +0100
In-Reply-To: <1447299376-21252-3-git-send-email-bsd@redhat.com> (Bandan Das's
	message of "Wed, 11 Nov 2015 22:36:16 -0500")
Message-ID: <87y4e3txjz.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 2/2] i440fx: print an error message if user
	tries to enable iommu
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Bandan Das <bsd@redhat.com>
Cc: qemu-devel@nongnu.org, mst@redhat.com

Bandan Das <bsd@redhat.com> writes:

> There's no indication of any sort that i440fx doesn't support
> "iommu=on""
>
> Signed-off-by: Bandan Das <bsd@redhat.com>
> ---
>  hw/pci-host/piix.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
> index 7b2fbf9..f12593a 100644
> --- a/hw/pci-host/piix.c
> +++ b/hw/pci-host/piix.c
> @@ -301,6 +301,10 @@ static void i440fx_pcihost_realize(DeviceState *dev, Error **errp)
>  static void i440fx_realize(PCIDevice *dev, Error **errp)
>  {
>      dev->config[I440FX_SMRAM] = 0x02;
> +
> +    if (object_property_get_bool(qdev_get_machine(), "iommu", NULL)) {
> +        fprintf(stderr, "i440fx doesn't support emulated iommu\n");
> +    }
>  }
>  
>  PCIBus *i440fx_init(const char *host_type, const char *pci_type,

error_report(), please.

If this is just a warning, please prefix the message with "warning: ".

If it isn't, exit(1).