All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Andrew Jones <drjones@redhat.com>,
	qemu-arm@nongnu.org, QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] hw/arm/virt: error_report cleanups
Date: Tue, 10 Nov 2015 10:39:44 +0100	[thread overview]
Message-ID: <87y4e6xkf3.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <CAFEAcA-z6NzyGkXqG27seP9G5c8qAL-MwY0QCPT1qZhfq6DZ+g@mail.gmail.com> (Peter Maydell's message of "Tue, 10 Nov 2015 09:31:15 +0000")

Peter Maydell <peter.maydell@linaro.org> writes:

> On 9 November 2015 at 18:52, Markus Armbruster <armbru@redhat.com> wrote:
>> Peter Maydell <peter.maydell@linaro.org> writes:
>>> Thanks, I had missed this useful improvement to the API.
>>> How does it work in cases like this where we don't have
>>> an Error* to fill in?
>>
>> You do what error_report_err() would do had you had an Error *err to
>> fill in:
>
>> In other words, you print the error message proper with error_report(),
>> and the additional information with error_printf().
>
> ...so in conclusion Andrew's patch is correct as it stands
> and I should just apply it? :-)

Yes.  It got my R-by :)

  reply	other threads:[~2015-11-10  9:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-07 15:25 [Qemu-devel] [PATCH] hw/arm/virt: error_report cleanups Andrew Jones
2015-11-07 16:56 ` Peter Maydell
2015-11-09  7:44   ` Markus Armbruster
2015-11-09 10:01     ` Peter Maydell
2015-11-09 10:21       ` Markus Armbruster
2015-11-09 15:47         ` Peter Maydell
2015-11-09 18:52           ` Markus Armbruster
2015-11-10  9:31             ` Peter Maydell
2015-11-10  9:39               ` Markus Armbruster [this message]
2015-11-10 11:55                 ` Peter Maydell
2015-11-10 13:02                   ` Andrew Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y4e6xkf3.fsf@blackfin.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=drjones@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.