From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35077) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4mTJ-0008BD-3m for qemu-devel@nongnu.org; Tue, 16 Jun 2015 04:43:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z4mTE-0003n0-S1 for qemu-devel@nongnu.org; Tue, 16 Jun 2015 04:43:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59786) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4mTE-0003mu-MZ for qemu-devel@nongnu.org; Tue, 16 Jun 2015 04:43:48 -0400 From: Markus Armbruster References: <1434120674-8122-1-git-send-email-armbru@redhat.com> <1434120674-8122-5-git-send-email-armbru@redhat.com> <557B6730.8050001@redhat.com> Date: Tue, 16 Jun 2015 10:43:46 +0200 In-Reply-To: <557B6730.8050001@redhat.com> (Eric Blake's message of "Fri, 12 Jun 2015 17:11:44 -0600") Message-ID: <87y4jkgi0t.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 04/16] qapi: Eliminate superfluous QAPISchema attribute include_hist List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com Eric Blake writes: > On 06/12/2015 08:51 AM, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster >> --- >> scripts/qapi.py | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> > > Ah, I see - you're changing it from an object member to a local variable > (because it didn't need to persist beyond the one function). Exactly. I could explain it the commit message, but I think I'll just squash it into PATCH 07. > Reviewed-by: Eric Blake Thanks!