All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/mtd: fix musl compile
Date: Fri, 24 Apr 2015 12:20:41 +0200	[thread overview]
Message-ID: <87y4lhrfnq.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1429830746-30309-1-git-send-email-joerg.krause@embedded.rocks> (=?utf-8?Q?=22J=C3=B6rg?= Krause"'s message of "Fri, 24 Apr 2015 01:12:26 +0200")

>>>>> "J?rg" == J?rg Krause <joerg.krause@embedded.rocks> writes:

 > Expand existing rpmatch() patch for uClibc to musl. Add another patch to
 > fix more compile issues with musl.

 > Patches sent upstream:
 > 1) "include/common.h: fix build against musl"
 >    [http://patchwork.ozlabs.org/patch/464074/]
 > 2) "Makefile: fix build against musl"
 >    [http://patchwork.ozlabs.org/patch/464072/]
 > 3) "lib/libfec.c: fix build against musl"
 >    [http://patchwork.ozlabs.org/patch/464073/]

Thanks, but something seems wrong:

> +uClibc defines both __UCLIBC__ and __GLIBC__. So first check for uCibc and its
 > +version and then for a non glibc implementation (like musl). Note, musl does
 > +not define __MUSL__.
 > +
 > +Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
 > +
 >  Cc: Mike Frysinger <vapier@gentoo.org>
 >  Signed-off-by: Baruch Siach <baruch@tkos.co.il>
 > +Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
 >  ---
 >   include/common.h | 14 ++++++++++++++
 >   1 file changed, 14 insertions(+)
 
 >  diff --git a/include/common.h b/include/common.h
 > -index 4ffccea17213..838dc757bdf1 100644
 > +index 4ffccea..d1be21e 100644
 >  --- a/include/common.h
 >  +++ b/include/common.h
 >  @@ -102,6 +102,20 @@ extern "C" {
 > - 	fprintf(stderr, "%s: warning!: " fmt "\n", PROGRAM_NAME, ##__VA_ARGS__); \
 > - } while(0)
 > - 
 > -+#if defined(__UCLIBC__)
 > -+/* uClibc versions before 0.9.34 don't have rpmatch() */
 > -+#if __UCLIBC_MAJOR__ == 0 && \
 > +	fprintf(stderr, "%s: warning!: " fmt "\n", PROGRAM_NAME, ##__VA_ARGS__); \
 > +} while(0)
 > +

This is not valid patch syntax (context lines should start with a
space). Perhaps you mailed corrupted the patch?

With that fixed, it still doesn't build for me:

  CC      recv_image.o
recv_image.c:7:19: fatal error: error.h: No such file or directory
 #include <error.h>
                   ^
compilation terminated.
common.mk:82: recipe for target '/home/peko/source/buildroot/output/build/mtd-1.5.1/recv_image.o' failed

Care to fix that and resend?

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2015-04-24 10:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-23 23:12 [Buildroot] [PATCH 1/1] package/mtd: fix musl compile Jörg Krause
2015-04-24 10:20 ` Peter Korsgaard [this message]
2015-04-24 19:29   ` Jörg Krause

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y4lhrfnq.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.