From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752488Ab3JGGPT (ORCPT ); Mon, 7 Oct 2013 02:15:19 -0400 Received: from out02.mta.xmission.com ([166.70.13.232]:44884 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751524Ab3JGGPR (ORCPT ); Mon, 7 Oct 2013 02:15:17 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: "Serge E. Hallyn" Cc: Miklos Szeredi , Al Viro , Linux-Fsdevel , Kernel Mailing List , Andy Lutomirski , Rob Landley , Linus Torvalds References: <87a9kkax0j.fsf@xmission.com> <8761v7h2pt.fsf@tw-ebiederman.twitter.com> <87li281wx6.fsf_-_@xmission.com> <87a9io1wu1.fsf_-_@xmission.com> <20131007042225.GA10284@mail.hallyn.com> Date: Sun, 06 Oct 2013 23:15:08 -0700 In-Reply-To: <20131007042225.GA10284@mail.hallyn.com> (Serge E. Hallyn's message of "Mon, 7 Oct 2013 04:22:26 +0000") Message-ID: <87y5658v4j.fsf@xmission.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-AID: U2FsdGVkX19DmRo4GxUu3CVQwCMhTA+otptkFUQViGE= X-SA-Exim-Connect-IP: 98.207.154.105 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 1.5 XMNoVowels Alpha-numberic number with no vowels * 1.5 TR_Symld_Words too many words that have symbols inside * 0.7 XMSubLong Long Subject * 0.0 T_TM2_M_HEADER_IN_MSG BODY: T_TM2_M_HEADER_IN_MSG * -3.0 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0028] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa05 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa05 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ;"Serge E. Hallyn" X-Spam-Relay-Country: Subject: Re: [RFC][PATCH 2/3] vfs: Add a function to lazily unmount all mounts from any dentry. X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Wed, 14 Nov 2012 14:26:46 -0700) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Serge E. Hallyn" writes: > Quoting Eric W. Biederman (ebiederm@xmission.com): >> >> Signed-off-by: Eric W. Biederman >> --- >> fs/mount.h | 1 + >> fs/namespace.c | 24 ++++++++++++++++++++++++ >> 2 files changed, 25 insertions(+), 0 deletions(-) >> >> diff --git a/fs/mount.h b/fs/mount.h >> index e4342b8dfab1..7a6a2bb3f290 100644 >> --- a/fs/mount.h >> +++ b/fs/mount.h >> @@ -79,6 +79,7 @@ static inline int is_mounted(struct vfsmount *mnt) >> } >> >> extern struct mount *__lookup_mnt(struct vfsmount *, struct dentry *, int); >> +extern void detach_mounts(struct dentry *dentry); >> >> static inline void get_mnt_ns(struct mnt_namespace *ns) >> { >> diff --git a/fs/namespace.c b/fs/namespace.c >> index d092964fe7f9..8eaee0c14fdb 100644 >> --- a/fs/namespace.c >> +++ b/fs/namespace.c >> @@ -1294,6 +1294,30 @@ static int do_umount(struct mount *mnt, int flags) >> return retval; >> } >> >> +void detach_mounts(struct dentry *dentry) >> +{ >> + struct mount *mnt, *next; >> + struct mountpoint *mp; >> + >> + namespace_lock(); >> + if (!d_mountpoint(dentry)) { >> + namespace_unlock(); >> + return; >> + } >> + mp = new_mountpoint(dentry); >> + if (IS_ERR(mp)) { > > namespace_unlock(); Good catch. Thank you. Eric