From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46490) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOTOY-0003Bl-Ew for qemu-devel@nongnu.org; Wed, 17 Oct 2012 09:10:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TOTOX-00017D-9s for qemu-devel@nongnu.org; Wed, 17 Oct 2012 09:10:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19602) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOTOW-000178-Qp for qemu-devel@nongnu.org; Wed, 17 Oct 2012 09:10:45 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9HDAigA030270 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 17 Oct 2012 09:10:44 -0400 From: Markus Armbruster References: <1349275025-5093-1-git-send-email-pbonzini@redhat.com> <1349275025-5093-3-git-send-email-pbonzini@redhat.com> <20121004131944.09750826@doriath.home> <506DBBAA.4070300@redhat.com> Date: Wed, 17 Oct 2012 15:10:42 +0200 In-Reply-To: <506DBBAA.4070300@redhat.com> (Paolo Bonzini's message of "Thu, 04 Oct 2012 18:39:06 +0200") Message-ID: <87y5j56y7h.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 02/18] qemu-sockets: add Error ** to all functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, Luiz Capitulino Paolo Bonzini writes: > Il 04/10/2012 18:19, Luiz Capitulino ha scritto: >>> > >>> > -int unix_listen_opts(QemuOpts *opts) >>> > +int unix_listen_opts(QemuOpts *opts, Error **errp) >>> > { >>> > - fprintf(stderr, "unix sockets are not available on windows\n"); >>> > + error_setg(errp, "unix sockets are not available on windows"); Just gave me a "review WTF", too. >> As we've discussed in a previous series, this breaks error reporting >> for unix_listen_opts() until errp is passed _and_ the error is routed >> to the right direction (in this case stderr). >> >> Is this fixed later in this series? If it's not, when do you plan to fix it? > > It is (which is why the single patch became 18), and I can move this > hunk at the end of the series. Note that is just for Windows code and > should really never run. Fair enough, but a note in the commit message is in order.