From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [PATCHv2 02/14] virtio ring: inline function to check for events Date: Sat, 21 May 2011 11:59:40 +0930 Message-ID: <87y620u6p7.fsf__1384.25568952716$1305945738$gmane$org@rustcorp.com.au> References: <16ce853af7a80d0f7cb0c1118ba8e19adc184ad0.1305846412.git.mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <16ce853af7a80d0f7cb0c1118ba8e19adc184ad0.1305846412.git.mst@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: "Michael S. Tsirkin" Cc: Krishna Kumar , Carsten Otte , lguest@lists.ozlabs.org, Shirley Ma , kvm@vger.kernel.org, linux-s390@vger.kernel.org, netdev@vger.kernel.org, habanero@linux.vnet.ibm.com, Heiko Carstens , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, steved@us.ibm.com, Christian Borntraeger , Tom Lendacky , Martin Schwidefsky , linux390@de.ibm.com List-Id: virtualization@lists.linuxfoundation.org On Fri, 20 May 2011 02:10:27 +0300, "Michael S. Tsirkin" wrote: > With the new used_event and avail_event and features, both > host and guest need similar logic to check whether events are > enabled, so it helps to put the common code in the header. > > Note that Xen has similar logic for notification hold-off > in include/xen/interface/io/ring.h with req_event and req_prod > corresponding to event_idx + 1 and new_idx respectively. > +1 comes from the fact that req_event and req_prod in Xen start at 1, > while event index in virtio starts at 0. > > Signed-off-by: Michael S. Tsirkin Applied. Thanks, Rusty.