Re: [PATCH v2 2/2] OMAP: omap_device: make all devices a child of a new parent device

[Kevin Hilman <khilman@deeprootsystems.com>]

Paul Walmsley <paul@pwsan.com> writes:

> Hi Kevin,
>
> On Tue, 14 Sep 2010, Kevin Hilman wrote:
>
>> From: Kevin Hilman <khilman@ti.com>
>> 
>> In order to help differentiate omap_devices from normal
>> platform_devices, make them all a parent of a new common parent
>> device.
>> 
>> Then, in order to determine if a platform_device is also an
>> omap_device, checking the parent is all that is needed.
>> 
>> Users of this feature are the runtime PM core for OMAP, where we need
>> to know if a device being passed in is an omap_device or not in order
>> to know whether to call the omap_device API with it.
>> 
>> In addition, all omap_devices will now show up under /sys/devices/omap
>> instead of /sys/devices/platform
>> 
>> Signed-off-by: Kevin Hilman <khilman@ti.com>
>
> At least with the current state of the Linux kernel codebase, I think it 
> would be better to have an omap_bus/omap_bus_type.  But as we've 
> discussed, that is a lot of work, and this solution seems to solve the 
> immediate problem -- how to determine if a device is really an omap_device 
> -- while being minimally invasive to the rest of the kernel code and 
> device model.  So, looks good to me for now,
>
> Acked-by: Paul Walmsley <paul@pwsan.com>
>
> and feel free to merge this and patch 1/2 through your tree...
>

OK, will do.

Thanks,

Kevin