All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org,  richard.henderson@linaro.org,
	pbonzini@redhat.com,  kwolf@redhat.com,  hreitz@redhat.com,
	imp@bsdimp.com,  kevans@freebsd.org,  berrange@redhat.com,
	groug@kaod.org,  qemu_oss@crudebyte.com,  mst@redhat.com,
	philmd@linaro.org,  peter.maydell@linaro.org,
	 alistair@alistair23.me, jasowang@redhat.com,
	 jonathan.cameron@huawei.com, kbastian@mail.uni-paderborn.de,
	 dgilbert@redhat.com, michael.roth@amd.com,  kkostiuk@redhat.com,
	 tsimpson@quicinc.com, palmer@dabbelt.com,
	 bin.meng@windriver.com,  qemu-block@nongnu.org,
	qemu-arm@nongnu.org,  qemu-riscv@nongnu.org
Subject: Re: [PATCH v5 04/20] scripts/clean-includes: Improve --git commit message
Date: Thu, 02 Feb 2023 11:54:54 +0100	[thread overview]
Message-ID: <87zg9ws5fl.fsf@secure.mitica> (raw)
In-Reply-To: <87k010phku.fsf@pond.sub.org> (Markus Armbruster's message of "Thu, 02 Feb 2023 10:00:49 +0100")

Markus Armbruster <armbru@redhat.com> wrote:

> It's less terse.  Fine with me.  The mix of passive and active voice
> feels a bit awkward, though.  Another try:
>
>   All .c should include qemu/osdep.h first.  This script performs three
>   related cleanups:
>
>   * Ensure .c files include qemu/osdep.h first.
>   * Including it in a .h is redundant, since the .c  already includes
>     it.  Drop such inclusions.
>   * Likewise, including headers qemu/osdep.h includes is redundant.
>     Drop these, too.

Perfect, thanks.

Reviewed-by: Juan Quintela <quintela@redhat.com>

or whatever you want it O:-)



  reply	other threads:[~2023-02-02 10:55 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-30 13:21 [PATCH v5 00/20] Clean up includes Markus Armbruster
2023-01-30 13:21 ` [PATCH v5 01/20] scripts/clean-includes: Fully skip / ignore files Markus Armbruster
2023-01-30 13:21 ` [PATCH v5 02/20] scripts/clean-includes: Don't claim duplicate headers found when not Markus Armbruster
2023-01-30 13:21 ` [PATCH v5 03/20] scripts/clean-includes: Skip symbolic links Markus Armbruster
2023-01-30 13:21 ` [PATCH v5 04/20] scripts/clean-includes: Improve --git commit message Markus Armbruster
2023-01-30 14:12   ` Juan Quintela
2023-02-01 12:49     ` Markus Armbruster
2023-02-01 13:14       ` Juan Quintela
2023-02-01 13:44         ` Markus Armbruster
2023-02-01 14:54           ` Juan Quintela
2023-02-02  9:00             ` Markus Armbruster
2023-02-02 10:54               ` Juan Quintela [this message]
2023-01-30 13:21 ` [PATCH v5 05/20] bsd-user: Clean up includes Markus Armbruster
2023-01-30 13:21 ` [PATCH v5 06/20] crypto: " Markus Armbruster
2023-01-30 13:21 ` [PATCH v5 07/20] hw/cxl: " Markus Armbruster
2023-01-30 13:21 ` [PATCH v5 08/20] hw/input: " Markus Armbruster
2023-01-30 13:21 ` [PATCH v5 09/20] hw/tricore: " Markus Armbruster
2023-01-30 13:21 ` [PATCH v5 10/20] qga: " Markus Armbruster
2023-01-30 13:21 ` [PATCH v5 11/20] migration: " Markus Armbruster
2023-01-30 13:21 ` [PATCH v5 12/20] net: " Markus Armbruster
2023-01-30 13:21 ` [PATCH v5 13/20] target/hexagon: " Markus Armbruster
2023-01-30 13:21 ` [PATCH v5 14/20] riscv: " Markus Armbruster
2023-01-30 13:21 ` [PATCH v5 15/20] block: " Markus Armbruster
2023-01-30 13:21 ` [PATCH v5 16/20] accel: " Markus Armbruster
2023-01-30 13:21 ` [PATCH v5 17/20] Fix non-first inclusions of qemu/osdep.h Markus Armbruster
2023-01-30 13:21 ` [PATCH v5 18/20] Don't include headers already included by qemu/osdep.h Markus Armbruster
2023-01-30 13:21 ` [PATCH v5 19/20] 9p: Drop superfluous include of linux/limits.h Markus Armbruster
2023-01-30 13:21 ` [PATCH v5 20/20] Drop duplicate #include Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zg9ws5fl.fsf@secure.mitica \
    --to=quintela@redhat.com \
    --cc=alistair@alistair23.me \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=bin.meng@windriver.com \
    --cc=dgilbert@redhat.com \
    --cc=groug@kaod.org \
    --cc=hreitz@redhat.com \
    --cc=imp@bsdimp.com \
    --cc=jasowang@redhat.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=kbastian@mail.uni-paderborn.de \
    --cc=kevans@freebsd.org \
    --cc=kkostiuk@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=michael.roth@amd.com \
    --cc=mst@redhat.com \
    --cc=palmer@dabbelt.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=qemu_oss@crudebyte.com \
    --cc=richard.henderson@linaro.org \
    --cc=tsimpson@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.