From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56236ECAAA1 for ; Thu, 27 Oct 2022 11:06:47 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id BE8C83062; Thu, 27 Oct 2022 13:05:55 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz BE8C83062 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1666868805; bh=YgHnWGtqOnyfkHuDwSPFyxeMUO6uhAX66aQx5koO/Qk=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=FybejreU+sUsjgUbgJRZyGmclGFLMi+3Z9uIK0zk4YIi8MaPPQ8JdrOLaxe3N44O7 9+JbLArl8qlYg69AMd3o6fbK10CCSYi5gP5uZswGtNLDgI35au1FnrIwoYIT34cXF5 MDKNRmSzVyL2vt4+BEy1KGxOQKZsvrmZ+DzV6miM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 5AAA0F8025A; Thu, 27 Oct 2022 13:05:55 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8FF16F8025E; Thu, 27 Oct 2022 13:05:54 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E9867F8016C for ; Thu, 27 Oct 2022 13:05:50 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E9867F8016C Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="CW3QqoKY"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="36oIg7CO" Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4C0161FD9E; Thu, 27 Oct 2022 11:05:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1666868750; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FseWLW0DY4ssJAGYvG19IPaHzcWC2y95WA6xRfJdRNs=; b=CW3QqoKYUxP6eOYpi3bo90FwNUzlN+WPgxi71M5FedkJPajGyedtwOzzO8LUoqEtc2zO6J gp4SkZ+9AdiuanOZXe31Q8gpOVHxQ/N9yOu6NkSHY2YWvQmnw50TJgnKBoQFDF+OOxEgxi RyGqCvlX6J6lhgjLLGP2cC48VXBP5rw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1666868750; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FseWLW0DY4ssJAGYvG19IPaHzcWC2y95WA6xRfJdRNs=; b=36oIg7COhdEB0/rLI+1XnS4E1u04/USvHo1iAWwJiPey2uSCUfnuSBjEhlkGd6eDBHfTxE WeSPEfii8cUJtECQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 23066134CA; Thu, 27 Oct 2022 11:05:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id lbesBQ5mWmO4FwAAMHmgww (envelope-from ); Thu, 27 Oct 2022 11:05:50 +0000 Date: Thu, 27 Oct 2022 13:05:49 +0200 Message-ID: <87zgdhmsqa.wl-tiwai@suse.de> From: Takashi Iwai To: Amadeusz =?ISO-8859-2?Q?S=B3awi=F1ski?= Subject: Re: [PATCH v3 3/9] ALSA: hda: Introduce snd_hdac_stream_wait_drsm() In-Reply-To: <3977c2b3-ead3-3904-820a-d602aa04c51b@linux.intel.com> References: <20221027082331.1561740-1-cezary.rojewski@intel.com> <20221027082331.1561740-4-cezary.rojewski@intel.com> <874jvpo9by.wl-tiwai@suse.de> <3977c2b3-ead3-3904-820a-d602aa04c51b@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: 8bit Cc: Cezary Rojewski , alsa-devel@alsa-project.org, tiwai@suse.com, pierre-louis.bossart@linux.intel.com, hdegoede@redhat.com, broonie@kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 27 Oct 2022 12:29:35 +0200, Amadeusz Sławiński wrote: > > On 10/27/2022 12:21 PM, Takashi Iwai wrote: > > On Thu, 27 Oct 2022 10:23:25 +0200, > > Cezary Rojewski wrote: > >> --- a/sound/hda/hdac_stream.c > >> +++ b/sound/hda/hdac_stream.c > >> @@ -821,6 +821,27 @@ void snd_hdac_stream_drsm_enable(struct hdac_bus *bus, > >> } > >> EXPORT_SYMBOL_GPL(snd_hdac_stream_drsm_enable); > >> +/* > >> + * snd_hdac_stream_wait_drsm - wait for HW to clear RSM for a stream > >> + * @azx_dev: HD-audio core stream to await RSM for > >> + * > >> + * Returns 0 on success and -ETIMEDOUT upon a timeout. > >> + */ > >> +int snd_hdac_stream_wait_drsm(struct hdac_stream *azx_dev) > >> +{ > >> + struct hdac_bus *bus = azx_dev->bus; > >> + u32 mask, reg; > >> + int ret; > >> + > >> + mask = 1 << azx_dev->index; > >> + > >> + ret = readb_poll_timeout(bus->drsmcap + AZX_REG_DRSM_CTL, reg, !(reg & mask), 250, 2000); > > > > Remember that HD-audio bus doesn't always allow readb(). Tegra > > requires the aligned access, for example. > > > > The readb_poll_timeout macro was updated to take care of that, > https://lore.kernel.org/all/20221007084856.1638302-1-amadeuszx.slawinski@linux.intel.com/ > so it should be fine? This patch doesn't use that macro... Takashi