From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0901C433FE for ; Mon, 14 Feb 2022 14:59:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355522AbiBNO7W (ORCPT ); Mon, 14 Feb 2022 09:59:22 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:60144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355520AbiBNO7V (ORCPT ); Mon, 14 Feb 2022 09:59:21 -0500 Received: from mslow1.mail.gandi.net (mslow1.mail.gandi.net [217.70.178.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 880F649278 for ; Mon, 14 Feb 2022 06:59:13 -0800 (PST) Received: from relay5-d.mail.gandi.net (unknown [IPv6:2001:4b98:dc4:8::225]) by mslow1.mail.gandi.net (Postfix) with ESMTP id 05D16C8635 for ; Mon, 14 Feb 2022 14:48:34 +0000 (UTC) Received: (Authenticated sender: gregory.clement@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 05AA41C0012; Mon, 14 Feb 2022 14:48:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1644850108; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PGDplxRGAMDfPdM5M9k+XloHcPThbWZzI8F7SByLk7s=; b=kKMzgCMVFAAzUo2AQLJFNHPV8wZ9DlEIxSqS2cA6OXU52d4lCZqnP4/aAkP76aupvBpxPH B3baTP8uWO9yT/GfID+n+BC2DxaVqJiMByFjFDKM/uFuToyio/kSU5nY8nc4mUbGaeXBV+ pyxeGMxOTGqFw+USlRkHm/CZLzGjdkhvpNBYGCtKHLtCZOQRzUJVDwWmM8ULbRwNmCA00u mPw8UjMx/6f27sbyVnJqmwEYiA1Io4LWAU44hJSuJUzheSOVBTWmlCCXGK6WolSVuJXXWY ZsEniWBeAXzORIImXW67+mthym9N/KBlrND6x2nR/kGvSusb0yWOfXASYSnRJQ== From: Gregory CLEMENT To: Marc Zyngier , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Cc: Linus Walleij , Bartosz Golaszewski , Matthias Brugger , Grygorii Strashko , Santosh Shilimkar , Kevin Hilman , Tony Lindgren , Thomas Gleixner , Vladimir Zapolskiy , Andrew Lunn , Sebastian Hesselbarth , Emil Renner Berthing , kernel-team@android.com Subject: Re: [PATCH 05/10] irqchip/mvebu-pic: Switch to dynamic chip name output In-Reply-To: <20220209162607.1118325-6-maz@kernel.org> References: <20220209162607.1118325-1-maz@kernel.org> <20220209162607.1118325-6-maz@kernel.org> Date: Mon, 14 Feb 2022 15:48:24 +0100 Message-ID: <87zgmtjyh3.fsf@BL-laptop> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hello Marc; > Instead of overriding the name field, track the corresponding device > and use the relevant callback to output its name. > > This allows us to make the irq_chip structure const. > > Signed-off-by: Marc Zyngier Reviewed-by: Gregory CLEMENT Thanks, Gregory > --- > drivers/irqchip/irq-mvebu-pic.c | 28 ++++++++++++++++++---------- > 1 file changed, 18 insertions(+), 10 deletions(-) > > diff --git a/drivers/irqchip/irq-mvebu-pic.c b/drivers/irqchip/irq-mvebu-pic.c > index 870f9866b8da..ef3d3646ccc2 100644 > --- a/drivers/irqchip/irq-mvebu-pic.c > +++ b/drivers/irqchip/irq-mvebu-pic.c > @@ -18,6 +18,7 @@ > #include > #include > #include > +#include > > #define PIC_CAUSE 0x0 > #define PIC_MASK 0x4 > @@ -29,7 +30,7 @@ struct mvebu_pic { > void __iomem *base; > u32 parent_irq; > struct irq_domain *domain; > - struct irq_chip irq_chip; > + struct platform_device *pdev; > }; > > static void mvebu_pic_reset(struct mvebu_pic *pic) > @@ -66,6 +67,20 @@ static void mvebu_pic_unmask_irq(struct irq_data *d) > writel(reg, pic->base + PIC_MASK); > } > > +static void mvebu_pic_print_chip(struct irq_data *d, struct seq_file *p) > +{ > + struct mvebu_pic *pic = irq_data_get_irq_chip_data(d); > + > + seq_printf(p, dev_name(&pic->pdev->dev)); > +} > + > +static const struct irq_chip mvebu_pic_chip = { > + .irq_mask = mvebu_pic_mask_irq, > + .irq_unmask = mvebu_pic_unmask_irq, > + .irq_eoi = mvebu_pic_eoi_irq, > + .irq_print_chip = mvebu_pic_print_chip, > +}; > + > static int mvebu_pic_irq_map(struct irq_domain *domain, unsigned int virq, > irq_hw_number_t hwirq) > { > @@ -73,8 +88,7 @@ static int mvebu_pic_irq_map(struct irq_domain *domain, unsigned int virq, > > irq_set_percpu_devid(virq); > irq_set_chip_data(virq, pic); > - irq_set_chip_and_handler(virq, &pic->irq_chip, > - handle_percpu_devid_irq); > + irq_set_chip_and_handler(virq, &mvebu_pic_chip, handle_percpu_devid_irq); > irq_set_status_flags(virq, IRQ_LEVEL); > irq_set_probe(virq); > > @@ -120,22 +134,16 @@ static int mvebu_pic_probe(struct platform_device *pdev) > { > struct device_node *node = pdev->dev.of_node; > struct mvebu_pic *pic; > - struct irq_chip *irq_chip; > > pic = devm_kzalloc(&pdev->dev, sizeof(struct mvebu_pic), GFP_KERNEL); > if (!pic) > return -ENOMEM; > > + pic->pdev = pdev; > pic->base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(pic->base)) > return PTR_ERR(pic->base); > > - irq_chip = &pic->irq_chip; > - irq_chip->name = dev_name(&pdev->dev); > - irq_chip->irq_mask = mvebu_pic_mask_irq; > - irq_chip->irq_unmask = mvebu_pic_unmask_irq; > - irq_chip->irq_eoi = mvebu_pic_eoi_irq; > - > pic->parent_irq = irq_of_parse_and_map(node, 0); > if (pic->parent_irq <= 0) { > dev_err(&pdev->dev, "Failed to parse parent interrupt\n"); > -- > 2.30.2 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com