From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8D19C433E0 for ; Fri, 26 Mar 2021 14:09:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A67A619BF for ; Fri, 26 Mar 2021 14:09:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230165AbhCZOJC (ORCPT ); Fri, 26 Mar 2021 10:09:02 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:36066 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229984AbhCZOIe (ORCPT ); Fri, 26 Mar 2021 10:08:34 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4F6P2d6PvWz1ryY1; Fri, 26 Mar 2021 15:08:25 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4F6P2d4qBqz1qqwS; Fri, 26 Mar 2021 15:08:25 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id onoyYkV_BZHU; Fri, 26 Mar 2021 15:08:24 +0100 (CET) X-Auth-Info: OEvAU2bUcvvTBFMfvWGLhYIW4WQnHRDFk1cZLlSNZz300DmBDLQfVXreztynDrlR Received: from igel.home (ppp-46-244-160-134.dynamic.mnet-online.de [46.244.160.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 26 Mar 2021 15:08:24 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id 998042C35E3; Fri, 26 Mar 2021 15:08:22 +0100 (CET) From: Andreas Schwab To: Christophe Leroy Cc: will@kernel.org, danielwa@cisco.com, robh@kernel.org, daniel@gimpelevich.san-francisco.ca.us, linux-arch@vger.kernel.org, devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, microblaze , linux-mips@vger.kernel.org, nios2 , openrisc@lists.librecores.org, linux-hexagon@vger.kernel.org, linux-riscv@lists.infradead.org, x86@kernel.org, linux-xtensa@linux-xtensa.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org Subject: Re: [PATCH v3 11/17] riscv: Convert to GENERIC_CMDLINE References: <46745e07b04139a22b5bd01dc37df97e6981e643.1616765870.git.christophe.leroy@csgroup.eu> X-Yow: I'd like some JUNK FOOD... and then I want to be ALONE -- Date: Fri, 26 Mar 2021 15:08:22 +0100 In-Reply-To: <46745e07b04139a22b5bd01dc37df97e6981e643.1616765870.git.christophe.leroy@csgroup.eu> (Christophe Leroy's message of "Fri, 26 Mar 2021 13:44:58 +0000 (UTC)") Message-ID: <87zgyqdn3d.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org On Mär 26 2021, Christophe Leroy wrote: > diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c > index f8f15332caa2..e7c91ee478d1 100644 > --- a/arch/riscv/kernel/setup.c > +++ b/arch/riscv/kernel/setup.c > @@ -20,6 +20,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -228,10 +229,8 @@ static void __init parse_dtb(void) > } > > pr_err("No DTB passed to the kernel\n"); > -#ifdef CONFIG_CMDLINE_FORCE > - strlcpy(boot_command_line, CONFIG_CMDLINE, COMMAND_LINE_SIZE); > + cmdline_build(boot_command_line, NULL, COMMAND_LINE_SIZE); > pr_info("Forcing kernel command line to: %s\n", boot_command_line); Shouldn't that message become conditional in some way? Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6C5DC433C1 for ; Fri, 26 Mar 2021 14:08:57 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5ABF6619A0 for ; Fri, 26 Mar 2021 14:08:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5ABF6619A0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To:Date:References: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=i14gTSC3ecNLdu4gy/1xA1LnzJY6dDplgd8t5/e97O4=; b=V3CBTW8vf3UQ5oQlkHh7cbPa4 9m3CAigmPMEp3k6sb4Mv+Ewj7cFIzIglB/axruzz72sjXipIUnkAi8hix8h56q7X/4DeUQqAyfepv bEipzLmbBUm/WcefeO3QcpuC96PlDkPSEG1xFAcxH5vxtVDacPTGLok9TXM3K7Qk/pyBRZ9EzQCR3 /p6mzi8HUZEBa0ZCdj8Wwp+QSzQimGar3vljQcOooNe0sTxu89n712nSBWVCV+eDCdhPVY3DhcOAK yJH8oZJegLNYOp2NkJiwEqaTp2rvSaZihMs0TU6y4ZGe45QCnu+LDbQugW6dOtXDzhzQGth0uIeOl R2WDGNz9Q==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lPn8j-003jln-VL; Fri, 26 Mar 2021 14:08:42 +0000 Received: from mail-out.m-online.net ([212.18.0.10]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lPn8Y-003jl0-Bk; Fri, 26 Mar 2021 14:08:32 +0000 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4F6P2d6PvWz1ryY1; Fri, 26 Mar 2021 15:08:25 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4F6P2d4qBqz1qqwS; Fri, 26 Mar 2021 15:08:25 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id onoyYkV_BZHU; Fri, 26 Mar 2021 15:08:24 +0100 (CET) X-Auth-Info: OEvAU2bUcvvTBFMfvWGLhYIW4WQnHRDFk1cZLlSNZz300DmBDLQfVXreztynDrlR Received: from igel.home (ppp-46-244-160-134.dynamic.mnet-online.de [46.244.160.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 26 Mar 2021 15:08:24 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id 998042C35E3; Fri, 26 Mar 2021 15:08:22 +0100 (CET) From: Andreas Schwab To: Christophe Leroy Cc: will@kernel.org, danielwa@cisco.com, robh@kernel.org, daniel@gimpelevich.san-francisco.ca.us, linux-arch@vger.kernel.org, devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, microblaze , linux-mips@vger.kernel.org, nios2 , openrisc@lists.librecores.org, linux-hexagon@vger.kernel.org, linux-riscv@lists.infradead.org, x86@kernel.org, linux-xtensa@linux-xtensa.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org Subject: Re: [PATCH v3 11/17] riscv: Convert to GENERIC_CMDLINE References: <46745e07b04139a22b5bd01dc37df97e6981e643.1616765870.git.christophe.leroy@csgroup.eu> X-Yow: I'd like some JUNK FOOD... and then I want to be ALONE -- Date: Fri, 26 Mar 2021 15:08:22 +0100 In-Reply-To: <46745e07b04139a22b5bd01dc37df97e6981e643.1616765870.git.christophe.leroy@csgroup.eu> (Christophe Leroy's message of "Fri, 26 Mar 2021 13:44:58 +0000 (UTC)") Message-ID: <87zgyqdn3d.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210326_140830_527210_DBAEC7B4 X-CRM114-Status: GOOD ( 12.62 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gTcOkciAyNiAyMDIxLCBDaHJpc3RvcGhlIExlcm95IHdyb3RlOgoKPiBkaWZmIC0tZ2l0IGEv YXJjaC9yaXNjdi9rZXJuZWwvc2V0dXAuYyBiL2FyY2gvcmlzY3Yva2VybmVsL3NldHVwLmMKPiBp bmRleCBmOGYxNTMzMmNhYTIuLmU3YzkxZWU0NzhkMSAxMDA2NDQKPiAtLS0gYS9hcmNoL3Jpc2N2 L2tlcm5lbC9zZXR1cC5jCj4gKysrIGIvYXJjaC9yaXNjdi9rZXJuZWwvc2V0dXAuYwo+IEBAIC0y MCw2ICsyMCw3IEBACj4gICNpbmNsdWRlIDxsaW51eC9zd2lvdGxiLmg+Cj4gICNpbmNsdWRlIDxs aW51eC9zbXAuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L2VmaS5oPgo+ICsjaW5jbHVkZSA8bGludXgv Y21kbGluZS5oPgo+ICAKPiAgI2luY2x1ZGUgPGFzbS9jcHVfb3BzLmg+Cj4gICNpbmNsdWRlIDxh c20vZWFybHlfaW9yZW1hcC5oPgo+IEBAIC0yMjgsMTAgKzIyOSw4IEBAIHN0YXRpYyB2b2lkIF9f aW5pdCBwYXJzZV9kdGIodm9pZCkKPiAgCX0KPiAgCj4gIAlwcl9lcnIoIk5vIERUQiBwYXNzZWQg dG8gdGhlIGtlcm5lbFxuIik7Cj4gLSNpZmRlZiBDT05GSUdfQ01ETElORV9GT1JDRQo+IC0Jc3Ry bGNweShib290X2NvbW1hbmRfbGluZSwgQ09ORklHX0NNRExJTkUsIENPTU1BTkRfTElORV9TSVpF KTsKPiArCWNtZGxpbmVfYnVpbGQoYm9vdF9jb21tYW5kX2xpbmUsIE5VTEwsIENPTU1BTkRfTElO RV9TSVpFKTsKPiAgCXByX2luZm8oIkZvcmNpbmcga2VybmVsIGNvbW1hbmQgbGluZSB0bzogJXNc biIsIGJvb3RfY29tbWFuZF9saW5lKTsKClNob3VsZG4ndCB0aGF0IG1lc3NhZ2UgYmVjb21lIGNv bmRpdGlvbmFsIGluIHNvbWUgd2F5PwoKQW5kcmVhcy4KCi0tIApBbmRyZWFzIFNjaHdhYiwgc2No d2FiQGxpbnV4LW02OGsub3JnCkdQRyBLZXkgZmluZ2VycHJpbnQgPSA3NTc4IEVCNDcgRDRFNSA0 RDY5IDI1MTAgIDI1NTIgREY3MyBFNzgwIEE5REEgQUVDMQoiQW5kIG5vdyBmb3Igc29tZXRoaW5n IGNvbXBsZXRlbHkgZGlmZmVyZW50LiIKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LXJpc2N2IG1haWxpbmcgbGlzdApsaW51eC1yaXNjdkBsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtcmlzY3YK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6815BC433DB for ; Fri, 26 Mar 2021 14:09:06 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3CA8A619A0 for ; Fri, 26 Mar 2021 14:09:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3CA8A619A0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4F6P3M6c8pz3cFm for ; Sat, 27 Mar 2021 01:09:03 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nefkom.net (client-ip=212.18.0.10; helo=mail-out.m-online.net; envelope-from=whitebox@nefkom.net; receiver=) Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4F6P302tYbz3bPH for ; Sat, 27 Mar 2021 01:08:44 +1100 (AEDT) Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4F6P2d6PvWz1ryY1; Fri, 26 Mar 2021 15:08:25 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4F6P2d4qBqz1qqwS; Fri, 26 Mar 2021 15:08:25 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id onoyYkV_BZHU; Fri, 26 Mar 2021 15:08:24 +0100 (CET) X-Auth-Info: OEvAU2bUcvvTBFMfvWGLhYIW4WQnHRDFk1cZLlSNZz300DmBDLQfVXreztynDrlR Received: from igel.home (ppp-46-244-160-134.dynamic.mnet-online.de [46.244.160.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 26 Mar 2021 15:08:24 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id 998042C35E3; Fri, 26 Mar 2021 15:08:22 +0100 (CET) From: Andreas Schwab To: Christophe Leroy Subject: Re: [PATCH v3 11/17] riscv: Convert to GENERIC_CMDLINE References: <46745e07b04139a22b5bd01dc37df97e6981e643.1616765870.git.christophe.leroy@csgroup.eu> X-Yow: I'd like some JUNK FOOD... and then I want to be ALONE -- Date: Fri, 26 Mar 2021 15:08:22 +0100 In-Reply-To: <46745e07b04139a22b5bd01dc37df97e6981e643.1616765870.git.christophe.leroy@csgroup.eu> (Christophe Leroy's message of "Fri, 26 Mar 2021 13:44:58 +0000 (UTC)") Message-ID: <87zgyqdn3d.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, robh@kernel.org, microblaze , daniel@gimpelevich.san-francisco.ca.us, devicetree@vger.kernel.org, linux-sh@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-xtensa@linux-xtensa.org, x86@kernel.org, linux-kernel@vger.kernel.org, nios2 , linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-hexagon@vger.kernel.org, sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, will@kernel.org, linux-arm-kernel@lists.infradead.org, danielwa@cisco.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mär 26 2021, Christophe Leroy wrote: > diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c > index f8f15332caa2..e7c91ee478d1 100644 > --- a/arch/riscv/kernel/setup.c > +++ b/arch/riscv/kernel/setup.c > @@ -20,6 +20,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -228,10 +229,8 @@ static void __init parse_dtb(void) > } > > pr_err("No DTB passed to the kernel\n"); > -#ifdef CONFIG_CMDLINE_FORCE > - strlcpy(boot_command_line, CONFIG_CMDLINE, COMMAND_LINE_SIZE); > + cmdline_build(boot_command_line, NULL, COMMAND_LINE_SIZE); > pr_info("Forcing kernel command line to: %s\n", boot_command_line); Shouldn't that message become conditional in some way? Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEDFAC433DB for ; Fri, 26 Mar 2021 14:10:12 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 57E98619EE for ; Fri, 26 Mar 2021 14:10:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 57E98619EE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To:Date:References: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=91zGI5pC+5yy/NcJIhYz4qfTF2cYsAdEMIWUHl/9JLI=; b=duU4mgJmmsVmHWBCJsvPm6ewi Cm0PG2TKOGiAr+q+Uiq5pWc57C3LUjcpnMsb7TdPo308oQMHcYEVCoI9tP/fN1PUUU6PAu/vkTr2h M5I99d7oNHBGO+ony6XF2SSttZiEWQ17nl+BOhGdV6m1aPKlaQKAP4P4eaYUFZndUeKn9TRKd4PVu 7hBbCCHTwwoDHzfVbDiuXC13fPmxHCwPj8KtOxNQr57aAUvvGzPOdcSqAJApNObW/dzun5BNXNuEI 7o0CvY4+YdI1q4NhPQi1qe/nDtos/ravmylmfMQpyGXXfKP/eIBUyys2ZMQ3zSGvBvdycpQp/b2h2 qaPOp/fKQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lPn8e-003jlS-2o; Fri, 26 Mar 2021 14:08:36 +0000 Received: from mail-out.m-online.net ([212.18.0.10]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lPn8Y-003jl0-Bk; Fri, 26 Mar 2021 14:08:32 +0000 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4F6P2d6PvWz1ryY1; Fri, 26 Mar 2021 15:08:25 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4F6P2d4qBqz1qqwS; Fri, 26 Mar 2021 15:08:25 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id onoyYkV_BZHU; Fri, 26 Mar 2021 15:08:24 +0100 (CET) X-Auth-Info: OEvAU2bUcvvTBFMfvWGLhYIW4WQnHRDFk1cZLlSNZz300DmBDLQfVXreztynDrlR Received: from igel.home (ppp-46-244-160-134.dynamic.mnet-online.de [46.244.160.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 26 Mar 2021 15:08:24 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id 998042C35E3; Fri, 26 Mar 2021 15:08:22 +0100 (CET) From: Andreas Schwab To: Christophe Leroy Cc: will@kernel.org, danielwa@cisco.com, robh@kernel.org, daniel@gimpelevich.san-francisco.ca.us, linux-arch@vger.kernel.org, devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, microblaze , linux-mips@vger.kernel.org, nios2 , openrisc@lists.librecores.org, linux-hexagon@vger.kernel.org, linux-riscv@lists.infradead.org, x86@kernel.org, linux-xtensa@linux-xtensa.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org Subject: Re: [PATCH v3 11/17] riscv: Convert to GENERIC_CMDLINE References: <46745e07b04139a22b5bd01dc37df97e6981e643.1616765870.git.christophe.leroy@csgroup.eu> X-Yow: I'd like some JUNK FOOD... and then I want to be ALONE -- Date: Fri, 26 Mar 2021 15:08:22 +0100 In-Reply-To: <46745e07b04139a22b5bd01dc37df97e6981e643.1616765870.git.christophe.leroy@csgroup.eu> (Christophe Leroy's message of "Fri, 26 Mar 2021 13:44:58 +0000 (UTC)") Message-ID: <87zgyqdn3d.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210326_140830_527210_DBAEC7B4 X-CRM114-Status: GOOD ( 12.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTcOkciAyNiAyMDIxLCBDaHJpc3RvcGhlIExlcm95IHdyb3RlOgoKPiBkaWZmIC0tZ2l0IGEv YXJjaC9yaXNjdi9rZXJuZWwvc2V0dXAuYyBiL2FyY2gvcmlzY3Yva2VybmVsL3NldHVwLmMKPiBp bmRleCBmOGYxNTMzMmNhYTIuLmU3YzkxZWU0NzhkMSAxMDA2NDQKPiAtLS0gYS9hcmNoL3Jpc2N2 L2tlcm5lbC9zZXR1cC5jCj4gKysrIGIvYXJjaC9yaXNjdi9rZXJuZWwvc2V0dXAuYwo+IEBAIC0y MCw2ICsyMCw3IEBACj4gICNpbmNsdWRlIDxsaW51eC9zd2lvdGxiLmg+Cj4gICNpbmNsdWRlIDxs aW51eC9zbXAuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L2VmaS5oPgo+ICsjaW5jbHVkZSA8bGludXgv Y21kbGluZS5oPgo+ICAKPiAgI2luY2x1ZGUgPGFzbS9jcHVfb3BzLmg+Cj4gICNpbmNsdWRlIDxh c20vZWFybHlfaW9yZW1hcC5oPgo+IEBAIC0yMjgsMTAgKzIyOSw4IEBAIHN0YXRpYyB2b2lkIF9f aW5pdCBwYXJzZV9kdGIodm9pZCkKPiAgCX0KPiAgCj4gIAlwcl9lcnIoIk5vIERUQiBwYXNzZWQg dG8gdGhlIGtlcm5lbFxuIik7Cj4gLSNpZmRlZiBDT05GSUdfQ01ETElORV9GT1JDRQo+IC0Jc3Ry bGNweShib290X2NvbW1hbmRfbGluZSwgQ09ORklHX0NNRExJTkUsIENPTU1BTkRfTElORV9TSVpF KTsKPiArCWNtZGxpbmVfYnVpbGQoYm9vdF9jb21tYW5kX2xpbmUsIE5VTEwsIENPTU1BTkRfTElO RV9TSVpFKTsKPiAgCXByX2luZm8oIkZvcmNpbmcga2VybmVsIGNvbW1hbmQgbGluZSB0bzogJXNc biIsIGJvb3RfY29tbWFuZF9saW5lKTsKClNob3VsZG4ndCB0aGF0IG1lc3NhZ2UgYmVjb21lIGNv bmRpdGlvbmFsIGluIHNvbWUgd2F5PwoKQW5kcmVhcy4KCi0tIApBbmRyZWFzIFNjaHdhYiwgc2No d2FiQGxpbnV4LW02OGsub3JnCkdQRyBLZXkgZmluZ2VycHJpbnQgPSA3NTc4IEVCNDcgRDRFNSA0 RDY5IDI1MTAgIDI1NTIgREY3MyBFNzgwIEE5REEgQUVDMQoiQW5kIG5vdyBmb3Igc29tZXRoaW5n IGNvbXBsZXRlbHkgZGlmZmVyZW50LiIKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Schwab Date: Fri, 26 Mar 2021 15:08:22 +0100 Subject: [OpenRISC] [PATCH v3 11/17] riscv: Convert to GENERIC_CMDLINE In-Reply-To: <46745e07b04139a22b5bd01dc37df97e6981e643.1616765870.git.christophe.leroy@csgroup.eu> (Christophe Leroy's message of "Fri, 26 Mar 2021 13:44:58 +0000 (UTC)") References: <46745e07b04139a22b5bd01dc37df97e6981e643.1616765870.git.christophe.leroy@csgroup.eu> Message-ID: <87zgyqdn3d.fsf@igel.home> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: openrisc@lists.librecores.org On Mär 26 2021, Christophe Leroy wrote: > diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c > index f8f15332caa2..e7c91ee478d1 100644 > --- a/arch/riscv/kernel/setup.c > +++ b/arch/riscv/kernel/setup.c > @@ -20,6 +20,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -228,10 +229,8 @@ static void __init parse_dtb(void) > } > > pr_err("No DTB passed to the kernel\n"); > -#ifdef CONFIG_CMDLINE_FORCE > - strlcpy(boot_command_line, CONFIG_CMDLINE, COMMAND_LINE_SIZE); > + cmdline_build(boot_command_line, NULL, COMMAND_LINE_SIZE); > pr_info("Forcing kernel command line to: %s\n", boot_command_line); Shouldn't that message become conditional in some way? Andreas. -- Andreas Schwab, schwab at linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Schwab Subject: Re: [PATCH v3 11/17] riscv: Convert to GENERIC_CMDLINE Date: Fri, 26 Mar 2021 15:08:22 +0100 Message-ID: <87zgyqdn3d.fsf@igel.home> References: <46745e07b04139a22b5bd01dc37df97e6981e643.1616765870.git.christophe.leroy@csgroup.eu> Mime-Version: 1.0 Content-Transfer-Encoding: base64 Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To:Date:References: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=i14gTSC3ecNLdu4gy/1xA1LnzJY6dDplgd8t5/e97O4=; b=V3CBTW8vf3UQ5oQlkHh7cbPa4 9m3CAigmPMEp3k6sb4Mv+Ewj7cFIzIglB/axruzz72sjXipIUnkAi8hix8h56q7X/4DeUQqAyfepv bEipzLmbBUm/WcefeO3QcpuC96PlDkPSEG1xFAcxH5vxtVDacPTGLok9TXM3K7Qk/pyBRZ9EzQCR3 /p6mzi8HUZEBa0ZCdj8Wwp+QSzQimGar3vljQcOooNe0sTxu89n712nSBWVCV+eDCdhPVY3DhcOAK yJH8oZJegLNYOp2NkJiwEqaTp2rvSaZihMs0TU6y4ZGe45QCnu+LDbQugW6dOtXDzhzQGth0uIeOl R2WDGNz9Q==; In-Reply-To: <46745e07b04139a22b5bd01dc37df97e6981e643.1616765870.git.christophe.leroy@csgroup.eu> (Christophe Leroy's message of "Fri, 26 Mar 2021 13:44:58 +0000 (UTC)") List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+glpr-linux-riscv=m.gmane-mx.org@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" To: Christophe Leroy Cc: will@kernel.org, danielwa@cisco.com, robh@kernel.org, daniel@gimpelevich.san-francisco.ca.us, linux-arch@vger.kernel.org, devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, microblaze , linux-mips@vger.kernel.org, nios2 , openrisc@lists.librecores.org, linux-hexagon@vger.kernel.org, linux-riscv@lists.infradead.org, x86@kernel.org, linux-xtensa@linux-xtensa.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org T24gTcOkciAyNiAyMDIxLCBDaHJpc3RvcGhlIExlcm95IHdyb3RlOgoKPiBkaWZmIC0tZ2l0IGEv YXJjaC9yaXNjdi9rZXJuZWwvc2V0dXAuYyBiL2FyY2gvcmlzY3Yva2VybmVsL3NldHVwLmMKPiBp bmRleCBmOGYxNTMzMmNhYTIuLmU3YzkxZWU0NzhkMSAxMDA2NDQKPiAtLS0gYS9hcmNoL3Jpc2N2 L2tlcm5lbC9zZXR1cC5jCj4gKysrIGIvYXJjaC9yaXNjdi9rZXJuZWwvc2V0dXAuYwo+IEBAIC0y MCw2ICsyMCw3IEBACj4gICNpbmNsdWRlIDxsaW51eC9zd2lvdGxiLmg+Cj4gICNpbmNsdWRlIDxs aW51eC9zbXAuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L2VmaS5oPgo+ICsjaW5jbHVkZSA8bGludXgv Y21kbGluZS5oPgo+ICAKPiAgI2luY2x1ZGUgPGFzbS9jcHVfb3BzLmg+Cj4gICNpbmNsdWRlIDxh c20vZWFybHlfaW9yZW1hcC5oPgo+IEBAIC0yMjgsMTAgKzIyOSw4IEBAIHN0YXRpYyB2b2lkIF9f aW5pdCBwYXJzZV9kdGIodm9pZCkKPiAgCX0KPiAgCj4gIAlwcl9lcnIoIk5vIERUQiBwYXNzZWQg dG8gdGhlIGtlcm5lbFxuIik7Cj4gLSNpZmRlZiBDT05GSUdfQ01ETElORV9GT1JDRQo+IC0Jc3Ry bGNweShib290X2NvbW1hbmRfbGluZSwgQ09ORklHX0NNRExJTkUsIENPTU1BTkRfTElORV9TSVpF KTsKPiArCWNtZGxpbmVfYnVpbGQoYm9vdF9jb21tYW5kX2xpbmUsIE5VTEwsIENPTU1BTkRfTElO RV9TSVpFKTsKPiAgCXByX2luZm8oIkZvcmNpbmcga2VybmVsIGNvbW1hbmQgbGluZSB0bzogJXNc biIsIGJvb3RfY29tbWFuZF9saW5lKTsKClNob3VsZG4ndCB0aGF0IG1lc3NhZ2UgYmVjb21lIGNv bmRpdGlvbmFsIGluIHNvbWUgd2F5PwoKQW5kcmVhcy4KCi0tIApBbmRyZWFzIFNjaHdhYiwgc2No d2FiQGxpbnV4LW02OGsub3JnCkdQRyBLZXkgZmluZ2VycHJpbnQgPSA3NTc4IEVCNDcgRDRFNSA0 RDY5IDI1MTAgIDI1NTIgREY3MyBFNzgwIEE5REEgQUVDMQoiQW5kIG5vdyBmb3Igc29tZXRoaW5n IGNvbXBsZXRlbHkgZGlmZmVyZW50LiIKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LXJpc2N2IG1haWxpbmcgbGlzdApsaW51eC1yaXNjdkBsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtcmlzY3YK