From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Emily Shaffer" <emilyshaffer@google.com>,
git@vger.kernel.org, "Robert Foss" <robert.foss@linaro.org>,
"Drew DeVault" <sir@cmpwn.com>,
"Rafael Aquini" <aquini@redhat.com>,
"Marcelo Arenas Belón" <carenas@gmail.com>
Subject: Re: [PATCH v3] git-send-email: Respect core.hooksPath setting
Date: Wed, 24 Mar 2021 01:44:27 +0100 [thread overview]
Message-ID: <87zgytpehg.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <xmqqeeg51ojs.fsf@gitster.g>
On Tue, Mar 23 2021, Junio C Hamano wrote:
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
>> From: Robert Foss <robert.foss@linaro.org>
>>
>> get-send-email currently makes the assumption that the
>> 'sendemail-validate' hook exists inside of the repository.
>>
>> Since the introduction of 'core.hooksPath' configuration option in
>> 867ad08a261 (hooks: allow customizing where the hook directory is,
>> 2016-05-04), this is no longer true.
>>
>> Instead of assuming a hardcoded repo relative path, query
>> git for the actual path of the hooks directory.
>>
>> Signed-off-by: Robert Foss <robert.foss@linaro.org>
>> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
>> ---
>>
>> Here's a v3 that fixes various issues with Robert's v2. Range-diff &
>> updated patch below.
>>
>> The advice I had in the v1 feedback about GetHooksPath was bad, just
>> having it be a new accessor is better. It's not like anyone is calling
>> this in a loop.
>
> How urgent is this "fix". I am wondering if Emily's "git hook"
> automatically fix this for us when it comes.
We've had iterations of that topic for almost a year now (since 2019
counting RFC discussions).
While I'd like to see it land I'm skeptical of parts of that approach[1]
and expect we'll have more re-rolls of it, and in any case the conflict
in send-email[2] will be trivial to resolve. So I think it makes sense
to queue up this narrow fix and not have this wait on the larger topic.
1. https://lore.kernel.org/git/87mtv8fww3.fsf@evledraar.gmail.com/
2. https://lore.kernel.org/git/20210311021037.3001235-36-emilyshaffer@google.com/
next prev parent reply other threads:[~2021-03-24 0:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 16:27 [PATCH v2] git-send-email: Respect core.hooksPath setting Robert Foss
2021-03-23 17:33 ` [PATCH v3] " Ævar Arnfjörð Bjarmason
2021-03-23 22:40 ` Junio C Hamano
2021-03-24 0:44 ` Ævar Arnfjörð Bjarmason [this message]
2021-03-24 1:17 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgytpehg.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=aquini@redhat.com \
--cc=carenas@gmail.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=robert.foss@linaro.org \
--cc=sir@cmpwn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.