From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D402C433DB for ; Wed, 3 Feb 2021 22:32:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EDE1164F60 for ; Wed, 3 Feb 2021 22:32:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232792AbhBCWcS (ORCPT ); Wed, 3 Feb 2021 17:32:18 -0500 Received: from relmlor1.renesas.com ([210.160.252.171]:29816 "EHLO relmlie5.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S232457AbhBCWcS (ORCPT ); Wed, 3 Feb 2021 17:32:18 -0500 Date: 04 Feb 2021 07:31:26 +0900 X-IronPort-AV: E=Sophos;i="5.79,399,1602514800"; d="scan'208";a="71248174" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie5.idc.renesas.com with ESMTP; 04 Feb 2021 07:31:26 +0900 Received: from mercury.renesas.com (unknown [10.166.252.133]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id 3003B40083EA; Thu, 4 Feb 2021 07:31:26 +0900 (JST) Message-ID: <87zh0k94eo.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Sameer Pujar Cc: , , , , , , Subject: Re: [PATCH 1/2] ASoC: audio-graph: Export graph_remove() function In-Reply-To: <1612368575-25991-2-git-send-email-spujar@nvidia.com> References: <1612368575-25991-1-git-send-email-spujar@nvidia.com> <1612368575-25991-2-git-send-email-spujar@nvidia.com> User-Agent: Wanderlust/2.15.9 Emacs/26.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org Hi Sameer > Audio graph based sound card drivers can call graph_remove() function > for cleanups during driver removal. To facilitate this export above > mentioned function. > > Signed-off-by: Sameer Pujar > Cc: Kuninori Morimoto (snip) > -static int graph_remove(struct platform_device *pdev) > +int graph_remove(struct platform_device *pdev) > { > struct snd_soc_card *card = platform_get_drvdata(pdev); > > return asoc_simple_clean_reference(card); > } > +EXPORT_SYMBOL_GPL(graph_remove); Not a big deal, but it is just calling asoc_simple_clean_reference() which is already global function. Thank you for your help !! Best regards --- Kuninori Morimoto From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88317C433E9 for ; Wed, 3 Feb 2021 22:32:37 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD85B64F64 for ; Wed, 3 Feb 2021 22:32:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD85B64F64 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=renesas.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 67BD516F6; Wed, 3 Feb 2021 23:31:43 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 67BD516F6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1612391553; bh=dmesqs3cJuAKQXniAZ10kcQL21wTOUvxoahGtT+P9Iw=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=QrjzBu1p+yP6S0ydlSJXgvB+y4BhsGaUVFlNGgurdsJ1tgpNnh0dZErL9StkG640W BaIi6BR8qG4mrCPAMNelk1ELwtU018Utkh2RZhED1UU3/A1m3w3J7KFXGENK569K2q cPYR+M1U7JklSEBwJXJ1yCgAl3GpDC07EX8Q1tog= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id CE12CF80154; Wed, 3 Feb 2021 23:31:42 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7DB41F8015A; Wed, 3 Feb 2021 23:31:40 +0100 (CET) Received: from relmlie5.idc.renesas.com (relmlor1.renesas.com [210.160.252.171]) by alsa1.perex.cz (Postfix) with ESMTP id 2536EF80154 for ; Wed, 3 Feb 2021 23:31:31 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 2536EF80154 Date: 04 Feb 2021 07:31:26 +0900 X-IronPort-AV: E=Sophos;i="5.79,399,1602514800"; d="scan'208";a="71248174" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie5.idc.renesas.com with ESMTP; 04 Feb 2021 07:31:26 +0900 Received: from mercury.renesas.com (unknown [10.166.252.133]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id 3003B40083EA; Thu, 4 Feb 2021 07:31:26 +0900 (JST) Message-ID: <87zh0k94eo.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Sameer Pujar Subject: Re: [PATCH 1/2] ASoC: audio-graph: Export graph_remove() function In-Reply-To: <1612368575-25991-2-git-send-email-spujar@nvidia.com> References: <1612368575-25991-1-git-send-email-spujar@nvidia.com> <1612368575-25991-2-git-send-email-spujar@nvidia.com> User-Agent: Wanderlust/2.15.9 Emacs/26.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, jonathanh@nvidia.com, sharadg@nvidia.com, broonie@kernel.org, thierry.reding@gmail.com, linux-tegra@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Sameer > Audio graph based sound card drivers can call graph_remove() function > for cleanups during driver removal. To facilitate this export above > mentioned function. > > Signed-off-by: Sameer Pujar > Cc: Kuninori Morimoto (snip) > -static int graph_remove(struct platform_device *pdev) > +int graph_remove(struct platform_device *pdev) > { > struct snd_soc_card *card = platform_get_drvdata(pdev); > > return asoc_simple_clean_reference(card); > } > +EXPORT_SYMBOL_GPL(graph_remove); Not a big deal, but it is just calling asoc_simple_clean_reference() which is already global function. Thank you for your help !! Best regards --- Kuninori Morimoto