From: Kalle Valo <kvalo@codeaurora.org>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Michal Kazior <michal.kazior@tieto.com>,
"David S. Miller" <davem@davemloft.net>,
Wen Gong <wgong@codeaurora.org>,
Erik Stromdahl <erik.stromdahl@gmail.com>,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] ath10k: fix gcc-10 zero-length-bounds warnings
Date: Mon, 11 May 2020 15:02:38 +0300 [thread overview]
Message-ID: <87zhae4r35.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20200509154818.GB27779@embeddedor> (Gustavo A. R. Silva's message of "Sat, 9 May 2020 10:48:18 -0500")
"Gustavo A. R. Silva" <gustavoars@kernel.org> writes:
> Arnd,
>
> On Sat, May 09, 2020 at 02:06:32PM +0200, Arnd Bergmann wrote:
>> gcc-10 started warning about out-of-bounds access for zero-length
>> arrays:
>>
>> In file included from drivers/net/wireless/ath/ath10k/core.h:18,
>> from drivers/net/wireless/ath/ath10k/htt_rx.c:8:
>> drivers/net/wireless/ath/ath10k/htt_rx.c: In function 'ath10k_htt_rx_tx_fetch_ind':
>> drivers/net/wireless/ath/ath10k/htt.h:1683:17: warning: array subscript 65535 is outside the bounds of an interior zero-length array 'struct htt_tx_fetch_record[0]' [-Wzero-length-bounds]
>> 1683 | return (void *)&ind->records[le16_to_cpu(ind->num_records)];
>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/wireless/ath/ath10k/htt.h:1676:29: note: while referencing 'records'
>> 1676 | struct htt_tx_fetch_record records[0];
>> | ^~~~~~~
>>
>> Make records[] a flexible array member to allow this, moving it behind
>> the other zero-length member that is not accessed in a way that gcc
>> warns about.
>>
>> Fixes: 3ba225b506a2 ("treewide: Replace zero-length array with
>> flexible-array member")
>
> This treewide patch no longer contains changes for ath10k. I removed them
> since Monday (05/04/2020). So, this "Fixes" tag does not apply.
Ok, I'll remove it. Also I'll take these to my ath.git tree, not to
net-next.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Erik Stromdahl <erik.stromdahl@gmail.com>,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, ath10k@lists.infradead.org,
Michal Kazior <michal.kazior@tieto.com>,
Wen Gong <wgong@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next 1/2] ath10k: fix gcc-10 zero-length-bounds warnings
Date: Mon, 11 May 2020 15:02:38 +0300 [thread overview]
Message-ID: <87zhae4r35.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20200509154818.GB27779@embeddedor> (Gustavo A. R. Silva's message of "Sat, 9 May 2020 10:48:18 -0500")
"Gustavo A. R. Silva" <gustavoars@kernel.org> writes:
> Arnd,
>
> On Sat, May 09, 2020 at 02:06:32PM +0200, Arnd Bergmann wrote:
>> gcc-10 started warning about out-of-bounds access for zero-length
>> arrays:
>>
>> In file included from drivers/net/wireless/ath/ath10k/core.h:18,
>> from drivers/net/wireless/ath/ath10k/htt_rx.c:8:
>> drivers/net/wireless/ath/ath10k/htt_rx.c: In function 'ath10k_htt_rx_tx_fetch_ind':
>> drivers/net/wireless/ath/ath10k/htt.h:1683:17: warning: array subscript 65535 is outside the bounds of an interior zero-length array 'struct htt_tx_fetch_record[0]' [-Wzero-length-bounds]
>> 1683 | return (void *)&ind->records[le16_to_cpu(ind->num_records)];
>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/wireless/ath/ath10k/htt.h:1676:29: note: while referencing 'records'
>> 1676 | struct htt_tx_fetch_record records[0];
>> | ^~~~~~~
>>
>> Make records[] a flexible array member to allow this, moving it behind
>> the other zero-length member that is not accessed in a way that gcc
>> warns about.
>>
>> Fixes: 3ba225b506a2 ("treewide: Replace zero-length array with
>> flexible-array member")
>
> This treewide patch no longer contains changes for ath10k. I removed them
> since Monday (05/04/2020). So, this "Fixes" tag does not apply.
Ok, I'll remove it. Also I'll take these to my ath.git tree, not to
net-next.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2020-05-11 12:03 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 12:06 [PATCH net-next 1/2] ath10k: fix gcc-10 zero-length-bounds warnings Arnd Bergmann
2020-05-09 12:06 ` Arnd Bergmann
2020-05-09 12:06 ` [PATCH net-next 2/2] ath10k: fix ath10k_pci struct layout Arnd Bergmann
2020-05-09 12:06 ` Arnd Bergmann
2020-05-11 12:05 ` Kalle Valo
2020-05-11 12:05 ` Kalle Valo
2020-05-11 12:17 ` Kalle Valo
2020-05-11 12:17 ` Kalle Valo
2020-05-11 12:39 ` Arnd Bergmann
2020-05-11 12:39 ` Arnd Bergmann
2020-05-13 6:50 ` gcc-10: kernel stack is corrupted and fails to boot Kalle Valo
2020-05-13 8:49 ` Arnd Bergmann
2020-05-13 12:45 ` Kalle Valo
2020-05-13 13:45 ` Arnd Bergmann
2020-05-13 15:31 ` Kalle Valo
2020-05-13 16:00 ` Arnd Bergmann
2020-05-13 16:07 ` David Laight
2020-05-14 9:13 ` Harald Arnesen
2020-05-13 15:48 ` Arvind Sankar
2020-05-13 21:28 ` Arnd Bergmann
2020-05-13 21:41 ` Borislav Petkov
2020-05-13 21:49 ` Arnd Bergmann
2020-05-13 22:20 ` Borislav Petkov
2020-05-13 22:51 ` Arvind Sankar
2020-05-13 23:13 ` Linus Torvalds
2020-05-13 23:36 ` Borislav Petkov
2020-05-14 0:11 ` Linus Torvalds
2020-05-14 0:51 ` Nick Desaulniers
2020-05-14 2:20 ` Linus Torvalds
2020-05-14 3:50 ` Andy Lutomirski
[not found] ` <CAHk-=wgiGxRgJGS-zyer1C_x2MQUVo6iZn0=aJyuFTqJWk-mpA@mail.gmail.com>
2020-05-14 5:22 ` Arvind Sankar
2020-05-14 8:40 ` Arnd Bergmann
2020-05-14 13:27 ` [PATCH] x86: Fix early boot crash on gcc-10, third try Borislav Petkov
2020-05-14 14:45 ` Kalle Valo
2020-05-14 15:50 ` gcc-10: kernel stack is corrupted and fails to boot Arvind Sankar
2020-05-14 8:11 ` David Laight
2020-05-13 23:07 ` Linus Torvalds
2020-05-09 15:48 ` [PATCH net-next 1/2] ath10k: fix gcc-10 zero-length-bounds warnings Gustavo A. R. Silva
2020-05-09 15:48 ` Gustavo A. R. Silva
2020-05-11 12:02 ` Kalle Valo [this message]
2020-05-11 12:02 ` Kalle Valo
2020-05-11 12:46 ` Arnd Bergmann
2020-05-11 12:46 ` Arnd Bergmann
2020-05-11 13:09 ` Kalle Valo
2020-05-11 13:09 ` Kalle Valo
2020-05-11 13:47 ` Arnd Bergmann
2020-05-11 13:47 ` Arnd Bergmann
2020-05-12 7:33 ` Kalle Valo
2020-05-12 7:33 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhae4r35.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=arnd@arndb.de \
--cc=ath10k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=erik.stromdahl@gmail.com \
--cc=gustavo@embeddedor.com \
--cc=gustavoars@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
--cc=netdev@vger.kernel.org \
--cc=wgong@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.