From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DA2AC47255 for ; Mon, 11 May 2020 12:03:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4FFBD206D5 for ; Mon, 11 May 2020 12:03:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="qmd7ij14" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729790AbgEKMDf (ORCPT ); Mon, 11 May 2020 08:03:35 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:32296 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729666AbgEKMDf (ORCPT ); Mon, 11 May 2020 08:03:35 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1589198615; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=HLhZMaOCv1O1jz47tTVuggCyPQt8joEJFRzbgN2Z4oQ=; b=qmd7ij14v1XtOB4T0eObL1QA5+k3soqpTyl0kYo1Dm2Pv5poFKmH158aEF04y6y3cZs+IFsf aquECsZqr6W0Iz3NBmwVKr0aRAQwRvkwyIfMlzjSyE7UKBGH1edU4hoRho+SQlAy3UuZlTxv xS3qet8/wncUvbGEARnu4n5gMc4= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-east-1.postgun.com with SMTP id 5eb93ee5d84a535c3ec10ef9 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 11 May 2020 12:02:45 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id C6E2EC433BA; Mon, 11 May 2020 12:02:44 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 642A5C433F2; Mon, 11 May 2020 12:02:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 642A5C433F2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: "Gustavo A. R. Silva" Cc: Arnd Bergmann , "Gustavo A. R. Silva" , Michal Kazior , "David S. Miller" , Wen Gong , Erik Stromdahl , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/2] ath10k: fix gcc-10 zero-length-bounds warnings References: <20200509120707.188595-1-arnd@arndb.de> <20200509154818.GB27779@embeddedor> Date: Mon, 11 May 2020 15:02:38 +0300 In-Reply-To: <20200509154818.GB27779@embeddedor> (Gustavo A. R. Silva's message of "Sat, 9 May 2020 10:48:18 -0500") Message-ID: <87zhae4r35.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org "Gustavo A. R. Silva" writes: > Arnd, > > On Sat, May 09, 2020 at 02:06:32PM +0200, Arnd Bergmann wrote: >> gcc-10 started warning about out-of-bounds access for zero-length >> arrays: >> >> In file included from drivers/net/wireless/ath/ath10k/core.h:18, >> from drivers/net/wireless/ath/ath10k/htt_rx.c:8: >> drivers/net/wireless/ath/ath10k/htt_rx.c: In function 'ath10k_htt_rx_tx_fetch_ind': >> drivers/net/wireless/ath/ath10k/htt.h:1683:17: warning: array subscript 65535 is outside the bounds of an interior zero-length array 'struct htt_tx_fetch_record[0]' [-Wzero-length-bounds] >> 1683 | return (void *)&ind->records[le16_to_cpu(ind->num_records)]; >> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/net/wireless/ath/ath10k/htt.h:1676:29: note: while referencing 'records' >> 1676 | struct htt_tx_fetch_record records[0]; >> | ^~~~~~~ >> >> Make records[] a flexible array member to allow this, moving it behind >> the other zero-length member that is not accessed in a way that gcc >> warns about. >> >> Fixes: 3ba225b506a2 ("treewide: Replace zero-length array with >> flexible-array member") > > This treewide patch no longer contains changes for ath10k. I removed them > since Monday (05/04/2020). So, this "Fixes" tag does not apply. Ok, I'll remove it. Also I'll take these to my ath.git tree, not to net-next. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail26.static.mailgun.info ([104.130.122.26]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jY79u-00036x-6y for ath10k@lists.infradead.org; Mon, 11 May 2020 12:03:51 +0000 From: Kalle Valo Subject: Re: [PATCH net-next 1/2] ath10k: fix gcc-10 zero-length-bounds warnings References: <20200509120707.188595-1-arnd@arndb.de> <20200509154818.GB27779@embeddedor> Date: Mon, 11 May 2020 15:02:38 +0300 In-Reply-To: <20200509154818.GB27779@embeddedor> (Gustavo A. R. Silva's message of "Sat, 9 May 2020 10:48:18 -0500") Message-ID: <87zhae4r35.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: "Gustavo A. R. Silva" Cc: Arnd Bergmann , "Gustavo A. R. Silva" , Erik Stromdahl , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, Michal Kazior , Wen Gong , "David S. Miller" "Gustavo A. R. Silva" writes: > Arnd, > > On Sat, May 09, 2020 at 02:06:32PM +0200, Arnd Bergmann wrote: >> gcc-10 started warning about out-of-bounds access for zero-length >> arrays: >> >> In file included from drivers/net/wireless/ath/ath10k/core.h:18, >> from drivers/net/wireless/ath/ath10k/htt_rx.c:8: >> drivers/net/wireless/ath/ath10k/htt_rx.c: In function 'ath10k_htt_rx_tx_fetch_ind': >> drivers/net/wireless/ath/ath10k/htt.h:1683:17: warning: array subscript 65535 is outside the bounds of an interior zero-length array 'struct htt_tx_fetch_record[0]' [-Wzero-length-bounds] >> 1683 | return (void *)&ind->records[le16_to_cpu(ind->num_records)]; >> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/net/wireless/ath/ath10k/htt.h:1676:29: note: while referencing 'records' >> 1676 | struct htt_tx_fetch_record records[0]; >> | ^~~~~~~ >> >> Make records[] a flexible array member to allow this, moving it behind >> the other zero-length member that is not accessed in a way that gcc >> warns about. >> >> Fixes: 3ba225b506a2 ("treewide: Replace zero-length array with >> flexible-array member") > > This treewide patch no longer contains changes for ath10k. I removed them > since Monday (05/04/2020). So, this "Fixes" tag does not apply. Ok, I'll remove it. Also I'll take these to my ath.git tree, not to net-next. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k