From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B99FC2BA19 for ; Sun, 5 Apr 2020 09:14:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 13DD92054F for ; Sun, 5 Apr 2020 09:14:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="GbrH2OrB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726485AbgDEJOp (ORCPT ); Sun, 5 Apr 2020 05:14:45 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:45650 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726380AbgDEJOp (ORCPT ); Sun, 5 Apr 2020 05:14:45 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1586078084; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=6/9MibweBRdexKNq6gs4nfntQ4hl08uFrMqjxWvBPlM=; b=GbrH2OrBe5qxu9dN3zBhvArSYuvWWlYOr3YqMeypOFbwVtY91BDQH+56n+45TH//6ASAhy+Z e3EnaGq5zYtlrgQcbdoz7ehbBtvNnhBOea1jgVnM8idLeFlj3liR9a4qexrrueZCmDHcA8F8 qQKOvQNsW6n9NLyzEr7VaLuNnK4= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e89a179.7f1fa20ed2d0-smtp-out-n05; Sun, 05 Apr 2020 09:14:33 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 1A7E1C433D2; Sun, 5 Apr 2020 09:14:33 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 79925C433D2; Sun, 5 Apr 2020 09:14:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 79925C433D2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Luca Coelho Cc: Chris Rorvick , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Johannes Berg , Emmanuel Grumbach , Intel Linux Wireless , "David S. Miller" Subject: Re: [PATCH] iwlwifi: actually check allocated conf_tlv pointer References: <20200402050219.4842-1-chris@rorvick.com> <87mu7qfhiy.fsf@codeaurora.org> Date: Sun, 05 Apr 2020 12:13:55 +0300 In-Reply-To: (Luca Coelho's message of "Sun, 05 Apr 2020 11:51:53 +0300") Message-ID: <87zhbqz44s.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Luca Coelho writes: > On Sun, 2020-04-05 at 11:44 +0300, Kalle Valo wrote: >> Chris Rorvick writes: >> >> > Commit 71bc0334a637 ("iwlwifi: check allocated pointer when allocating >> > conf_tlvs") attempted to fix a typoe introduced by commit 17b809c9b22e >> > ("iwlwifi: dbg: move debug data to a struct") but does not implement the >> > check correctly. >> > >> > Tweeted-by: @grsecurity >> > Signed-off-by: Chris Rorvick >> >> I'll add: >> >> Fixes: 71bc0334a637 ("iwlwifi: check allocated pointer when allocating conf_tlvs") >> >> > --- >> > In this wasn't picked up? >> >> Luca, can I take this directly? > > Yes, please take it directly. Ok, assigned it to me in patchwork. > This can happen in OOM situations and, when it does, we will > potentially try to dereference a NULL pointer. I'll add this to the commit log. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches