From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D198DC4BA2D for ; Thu, 27 Feb 2020 00:05:35 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C72824672 for ; Thu, 27 Feb 2020 00:05:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="oLxsMoJL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C72824672 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=renesas.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id AD0A21660; Thu, 27 Feb 2020 01:04:43 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz AD0A21660 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1582761933; bh=lukajCbr6wV28E2GefAbURhU6wNT/Y9XK/d3dbY+DFY=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=oLxsMoJLT5AJrEa8VjEVV4Vj/Rz2oLYIhmt6IW13LNMK5DLGLjsRGrUDrqOY+0roq h3ttz2CHg5s+a1+mfCkwwjIM1f0b4hj+YORRq5hk/C3kxlEix/F2SqmFaMaIKAXy+9 kRBUJRCbLHP3FJLQiLRckd3LTSVrG+ljB8Vay40Y= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3125AF8014D; Thu, 27 Feb 2020 01:04:43 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 47EC4F8014E; Thu, 27 Feb 2020 01:04:41 +0100 (CET) Received: from relmlie6.idc.renesas.com (relmlor2.renesas.com [210.160.252.172]) by alsa1.perex.cz (Postfix) with ESMTP id 9B827F80089 for ; Thu, 27 Feb 2020 01:04:35 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 9B827F80089 Date: 27 Feb 2020 09:04:31 +0900 X-IronPort-AV: E=Sophos;i="5.70,490,1574089200"; d="scan'208";a="40132722" Received: from unknown (HELO relmlir6.idc.renesas.com) ([10.200.68.152]) by relmlie6.idc.renesas.com with ESMTP; 27 Feb 2020 09:04:31 +0900 Received: from mercury.renesas.com (unknown [10.166.252.133]) by relmlir6.idc.renesas.com (Postfix) with ESMTP id D04954111664; Thu, 27 Feb 2020 09:04:31 +0900 (JST) Message-ID: <87zhd47v5c.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Pierre-Louis Bossart Subject: Re: [PATCH 8/8] ASoC: soc-pcm: tidyup dulicate handing at dpcm_fe_dai_startup() In-Reply-To: <1e91e2da-2e86-abfb-19fe-7924c92350a8@linux.intel.com> References: <87eeuh97k4.wl-kuninori.morimoto.gx@renesas.com> <8736ax97hm.wl-kuninori.morimoto.gx@renesas.com> <1e91e2da-2e86-abfb-19fe-7924c92350a8@linux.intel.com> User-Agent: Wanderlust/2.15.9 Emacs/25.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: Linux-ALSA , Mark Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Pierre-Louis > > diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c > > index 1f7a86c4bc02..2fdd90437a6f 100644 > > --- a/sound/soc/soc-pcm.c > > +++ b/sound/soc/soc-pcm.c > > @@ -2165,11 +2165,9 @@ static int dpcm_fe_dai_startup(struct snd_pcm_substream *fe_substream) > > goto unwind; > > } > > nit-pick: since the two lines below are removed, the 'goto unwind' > above becomes unnecessary. I don't mind if you leave it for symmetry > with the rest of the error handling flow. Oops ? Indeed. Thank you for your review Will fixup it in v2 Thank you for your help !! Best regards --- Kuninori Morimoto