From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61BCEC3F68F for ; Fri, 10 Jan 2020 19:13:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 404982051A for ; Fri, 10 Jan 2020 19:13:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728617AbgAJTNt (ORCPT ); Fri, 10 Jan 2020 14:13:49 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:59519 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727831AbgAJTNt (ORCPT ); Fri, 10 Jan 2020 14:13:49 -0500 Received: from p5b06da22.dip0.t-ipconnect.de ([91.6.218.34] helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1ipzif-0003It-LL; Fri, 10 Jan 2020 20:13:17 +0100 Received: by nanos.tec.linutronix.de (Postfix, from userid 1000) id 067A6105BDB; Fri, 10 Jan 2020 20:13:16 +0100 (CET) From: Thomas Gleixner To: Anchal Agarwal Cc: mingo@redhat.com, bp@alien8.de, hpa@zytor.com, x86@kernel.org, boris.ostrovsky@oracle.com, jgross@suse.com, linux-pm@vger.kernel.org, linux-mm@kvack.org, kamatam@amazon.com, sstabellini@kernel.org, konrad.wilk@oracle.co, roger.pau@citrix.com, axboe@kernel.dk, davem@davemloft.net, rjw@rjwysocki.net, len.brown@intel.com, pavel@ucw.cz, peterz@infradead.org, eduval@amazon.com, sblbir@amazon.com, xen-devel@lists.xenproject.org, vkuznets@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, dwmw@amazon.co.uk, fllinden@amazon.com, anchalag@amazon.com Subject: Re: [RFC PATCH V2 09/11] xen: Clear IRQD_IRQ_STARTED flag during shutdown PIRQs In-Reply-To: <20200109234050.GA26381@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> Date: Fri, 10 Jan 2020 20:13:16 +0100 Message-ID: <87zhevrupf.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Anchal, Anchal Agarwal writes: > On Thu, Jan 09, 2020 at 01:07:27PM +0100, Thomas Gleixner wrote: >> Anchal Agarwal writes: >> So either you can handle it purely on the XEN side without touching any >> core state or you need to come up with some way of letting the core code >> know that it should invoke shutdown instead of disable. >> >> Something like the completely untested patch below. > > Understandable. Really appreciate the patch suggestion below and i will test it > for sure and see if things can be fixed properly in irq core if thats the only > option. In the meanwhile, I tried to fix it on xen side unless it gives you the > same feeling as above? MSI-x are just fine, just ioapic ones don't get any event > channel asssigned hence enable_dynirq does nothing. Those needs to be restarted. > > diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c > index 1bb0b522d004..2ed152f35816 100644 > --- a/drivers/xen/events/events_base.c > +++ b/drivers/xen/events/events_base.c > @@ -575,6 +575,11 @@ static void shutdown_pirq(struct irq_data *data) > > static void enable_pirq(struct irq_data *data) > { > +/*ioapic interrupts don't get event channel assigned > + * after being explicitly shutdown during guest > + * hibernation. They need to be restarted*/ > + if(!evtchn_from_irq(data->irq)) > + startup_pirq(data); > enable_dynirq(data); > } Interesting patch format :) Doing the shutdown from syscore_ops and the startup conditionally in a totaly unrelated function is not really intuitive. So either you do it symmetrically in XEN via syscore_ops callbacks or you let the irq core code help you out with the patch I provided Thanks, tglx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 145D1C33CA4 for ; Fri, 10 Jan 2020 19:14:02 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E3E022051A for ; Fri, 10 Jan 2020 19:14:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E3E022051A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ipzj2-0001MF-Ew; Fri, 10 Jan 2020 19:13:40 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ipzj1-0001MA-NN for xen-devel@lists.xenproject.org; Fri, 10 Jan 2020 19:13:39 +0000 X-Inumbo-ID: 4e31f074-33dd-11ea-a985-bc764e2007e4 Received: from Galois.linutronix.de (unknown [2a0a:51c0:0:12e:550::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4e31f074-33dd-11ea-a985-bc764e2007e4; Fri, 10 Jan 2020 19:13:38 +0000 (UTC) Received: from p5b06da22.dip0.t-ipconnect.de ([91.6.218.34] helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1ipzif-0003It-LL; Fri, 10 Jan 2020 20:13:17 +0100 Received: by nanos.tec.linutronix.de (Postfix, from userid 1000) id 067A6105BDB; Fri, 10 Jan 2020 20:13:16 +0100 (CET) From: Thomas Gleixner To: Anchal Agarwal In-Reply-To: <20200109234050.GA26381@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> Date: Fri, 10 Jan 2020 20:13:16 +0100 Message-ID: <87zhevrupf.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1, SHORTCIRCUIT=-0.0001 Subject: Re: [Xen-devel] [RFC PATCH V2 09/11] xen: Clear IRQD_IRQ_STARTED flag during shutdown PIRQs X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: konrad.wilk@oracle.co, eduval@amazon.com, peterz@infradead.org, x86@kernel.org, linux-mm@kvack.org, axboe@kernel.dk, pavel@ucw.cz, hpa@zytor.com, sstabellini@kernel.org, kamatam@amazon.com, mingo@redhat.com, xen-devel@lists.xenproject.org, sblbir@amazon.com, len.brown@intel.com, linux-pm@vger.kernel.org, anchalag@amazon.com, bp@alien8.de, boris.ostrovsky@oracle.com, jgross@suse.com, netdev@vger.kernel.org, fllinden@amazon.com, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, vkuznets@redhat.com, davem@davemloft.net, dwmw@amazon.co.uk, roger.pau@citrix.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" QW5jaGFsLAoKQW5jaGFsIEFnYXJ3YWwgPGFuY2hhbGFnQGFtYXpvbi5jb20+IHdyaXRlczoKPiBP biBUaHUsIEphbiAwOSwgMjAyMCBhdCAwMTowNzoyN1BNICswMTAwLCBUaG9tYXMgR2xlaXhuZXIg d3JvdGU6Cj4+IEFuY2hhbCBBZ2Fyd2FsIDxhbmNoYWxhZ0BhbWF6b24uY29tPiB3cml0ZXM6Cj4+ IFNvIGVpdGhlciB5b3UgY2FuIGhhbmRsZSBpdCBwdXJlbHkgb24gdGhlIFhFTiBzaWRlIHdpdGhv dXQgdG91Y2hpbmcgYW55Cj4+IGNvcmUgc3RhdGUgb3IgeW91IG5lZWQgdG8gY29tZSB1cCB3aXRo IHNvbWUgd2F5IG9mIGxldHRpbmcgdGhlIGNvcmUgY29kZQo+PiBrbm93IHRoYXQgaXQgc2hvdWxk IGludm9rZSBzaHV0ZG93biBpbnN0ZWFkIG9mIGRpc2FibGUuCj4+IAo+PiBTb21ldGhpbmcgbGlr ZSB0aGUgY29tcGxldGVseSB1bnRlc3RlZCBwYXRjaCBiZWxvdy4KPgo+IFVuZGVyc3RhbmRhYmxl LiBSZWFsbHkgYXBwcmVjaWF0ZSB0aGUgcGF0Y2ggc3VnZ2VzdGlvbiBiZWxvdyBhbmQgaSB3aWxs IHRlc3QgaXQKPiBmb3Igc3VyZSBhbmQgc2VlIGlmIHRoaW5ncyBjYW4gYmUgZml4ZWQgcHJvcGVy bHkgaW4gaXJxIGNvcmUgaWYgdGhhdHMgdGhlIG9ubHkKPiBvcHRpb24uIEluIHRoZSBtZWFud2hp bGUsIEkgdHJpZWQgdG8gZml4IGl0IG9uIHhlbiBzaWRlIHVubGVzcyBpdCBnaXZlcyB5b3UgdGhl IAo+IHNhbWUgZmVlbGluZyBhcyBhYm92ZT8gTVNJLXggYXJlIGp1c3QgZmluZSwganVzdCBpb2Fw aWMgb25lcyBkb24ndCBnZXQgYW55IGV2ZW50Cj4gY2hhbm5lbCBhc3NzaWduZWQgaGVuY2UgZW5h YmxlX2R5bmlycSBkb2VzIG5vdGhpbmcuIFRob3NlIG5lZWRzIHRvIGJlIHJlc3RhcnRlZC4KPgo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL3hlbi9ldmVudHMvZXZlbnRzX2Jhc2UuYyBiL2RyaXZlcnMv eGVuL2V2ZW50cy9ldmVudHNfYmFzZS5jCj4gaW5kZXggMWJiMGI1MjJkMDA0Li4yZWQxNTJmMzU4 MTYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy94ZW4vZXZlbnRzL2V2ZW50c19iYXNlLmMKPiAgICAg KysrIGIvZHJpdmVycy94ZW4vZXZlbnRzL2V2ZW50c19iYXNlLmMKPiBAQCAtNTc1LDYgKzU3NSwx MSBAQCBzdGF0aWMgdm9pZCBzaHV0ZG93bl9waXJxKHN0cnVjdCBpcnFfZGF0YSAqZGF0YSkKPgo+ IHN0YXRpYyB2b2lkIGVuYWJsZV9waXJxKHN0cnVjdCBpcnFfZGF0YSAqZGF0YSkKPiB7Cj4gICAg ICsvKmlvYXBpYyBpbnRlcnJ1cHRzIGRvbid0IGdldCBldmVudCBjaGFubmVsIGFzc2lnbmVkCj4g ICAgICAgICsgKiBhZnRlciBiZWluZyBleHBsaWNpdGx5IHNodXRkb3duIGR1cmluZyBndWVzdAo+ ICAgICAgICArICogaGliZXJuYXRpb24uIFRoZXkgbmVlZCB0byBiZSByZXN0YXJ0ZWQqLwo+ICAg ICAgICAgKyAgICAgICBpZighZXZ0Y2huX2Zyb21faXJxKGRhdGEtPmlycSkpCj4gICAgICAgICAr ICAgICAgICAgICAgICAgc3RhcnR1cF9waXJxKGRhdGEpOwo+ICAgICBlbmFibGVfZHluaXJxKGRh dGEpOwo+ICB9CgpJbnRlcmVzdGluZyBwYXRjaCBmb3JtYXQgOikKCkRvaW5nIHRoZSBzaHV0ZG93 biBmcm9tIHN5c2NvcmVfb3BzIGFuZCB0aGUgc3RhcnR1cCBjb25kaXRpb25hbGx5IGluIGEKdG90 YWx5IHVucmVsYXRlZCBmdW5jdGlvbiBpcyBub3QgcmVhbGx5IGludHVpdGl2ZS4KClNvIGVpdGhl ciB5b3UgZG8gaXQgc3ltbWV0cmljYWxseSBpbiBYRU4gdmlhIHN5c2NvcmVfb3BzIGNhbGxiYWNr cyBvcgp5b3UgbGV0IHRoZSBpcnEgY29yZSBjb2RlIGhlbHAgeW91IG91dCB3aXRoIHRoZSBwYXRj aCBJIHByb3ZpZGVkCgpUaGFua3MsCgogICAgICAgIHRnbHgKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRl dmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFp bG1hbi9saXN0aW5mby94ZW4tZGV2ZWw=