From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4C63C33C99 for ; Wed, 8 Jan 2020 02:58:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8E7A22075A for ; Wed, 8 Jan 2020 02:58:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726411AbgAHC6P (ORCPT ); Tue, 7 Jan 2020 21:58:15 -0500 Received: from mga02.intel.com ([134.134.136.20]:28679 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725812AbgAHC6P (ORCPT ); Tue, 7 Jan 2020 21:58:15 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jan 2020 18:58:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,408,1571727600"; d="scan'208";a="271711507" Received: from njagann1-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.254.67.66]) by FMSMGA003.fm.intel.com with ESMTP; 07 Jan 2020 18:58:14 -0800 Date: Tue, 07 Jan 2020 18:58:13 -0800 Message-ID: <87zheyu01m.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Xu Wang CC: , , , Subject: Re: [PATCH] mic: Remove unneeded NULL check In-Reply-To: <1578391235-603-1-git-send-email-vulab@iscas.ac.cn> References: <1578391235-603-1-git-send-email-vulab@iscas.ac.cn> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/26 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Reviewed-by: Ashutosh Dixit On Tue, 07 Jan 2020 02:00:35 -0800, Xu Wang wrote: > > debugfs_remove_recursive will do NULL check, so remove > the redundant null check. > > Signed-off-by: Xu Wang > --- > drivers/misc/mic/card/mic_debugfs.c | 3 --- > drivers/misc/mic/cosm/cosm_debugfs.c | 3 --- > drivers/misc/mic/host/mic_debugfs.c | 3 --- > 3 files changed, 9 deletions(-) > > diff --git a/drivers/misc/mic/card/mic_debugfs.c b/drivers/misc/mic/card/mic_debugfs.c > index 3ee3d24..b586088 100644 > --- a/drivers/misc/mic/card/mic_debugfs.c > +++ b/drivers/misc/mic/card/mic_debugfs.c > @@ -65,9 +65,6 @@ void __init mic_create_card_debug_dir(struct mic_driver *mdrv) > */ > void mic_delete_card_debug_dir(struct mic_driver *mdrv) > { > - if (!mdrv->dbg_dir) > - return; > - > debugfs_remove_recursive(mdrv->dbg_dir); > } > > diff --git a/drivers/misc/mic/cosm/cosm_debugfs.c b/drivers/misc/mic/cosm/cosm_debugfs.c > index 2fc9f4b..68a731f 100644 > --- a/drivers/misc/mic/cosm/cosm_debugfs.c > +++ b/drivers/misc/mic/cosm/cosm_debugfs.c > @@ -102,9 +102,6 @@ void cosm_create_debug_dir(struct cosm_device *cdev) > > void cosm_delete_debug_dir(struct cosm_device *cdev) > { > - if (!cdev->dbg_dir) > - return; > - > debugfs_remove_recursive(cdev->dbg_dir); > } > > diff --git a/drivers/misc/mic/host/mic_debugfs.c b/drivers/misc/mic/host/mic_debugfs.c > index 8a8e416..ab0db7a 100644 > --- a/drivers/misc/mic/host/mic_debugfs.c > +++ b/drivers/misc/mic/host/mic_debugfs.c > @@ -129,9 +129,6 @@ void mic_create_debug_dir(struct mic_device *mdev) > */ > void mic_delete_debug_dir(struct mic_device *mdev) > { > - if (!mdev->dbg_dir) > - return; > - > debugfs_remove_recursive(mdev->dbg_dir); > } > > -- > 2.7.4 >