From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD6C9C3A5A1 for ; Wed, 28 Aug 2019 16:45:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B9A31208C2 for ; Wed, 28 Aug 2019 16:45:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726711AbfH1Qpz (ORCPT ); Wed, 28 Aug 2019 12:45:55 -0400 Received: from mga14.intel.com ([192.55.52.115]:18621 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726513AbfH1Qpy (ORCPT ); Wed, 28 Aug 2019 12:45:54 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Aug 2019 09:45:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,441,1559545200"; d="scan'208";a="381342017" Received: from unknown (HELO ellie) ([10.24.12.211]) by fmsmga006.fm.intel.com with ESMTP; 28 Aug 2019 09:45:54 -0700 From: Vinicius Costa Gomes To: Vladimir Oltean , jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net, vedang.patel@intel.com, leandro.maciel.dorileo@intel.com Cc: netdev@vger.kernel.org, Vladimir Oltean Subject: Re: [PATCH net 3/3] net/sched: cbs: Set default link speed to 10 Mbps in cbs_set_port_rate In-Reply-To: <20190828144829.32570-4-olteanv@gmail.com> References: <20190828144829.32570-1-olteanv@gmail.com> <20190828144829.32570-4-olteanv@gmail.com> Date: Wed, 28 Aug 2019 09:45:53 -0700 Message-ID: <87zhjtp7b2.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Vladimir Oltean writes: > The discussion to be made is absolutely the same as in the case of > previous patch ("taprio: Set default link speed to 10 Mbps in > taprio_set_picos_per_byte"). Nothing is lost when setting a default. > > Cc: Leandro Dorileo > Fixes: e0a7683d30e9 ("net/sched: cbs: fix port_rate miscalculation") > Signed-off-by: Vladimir Oltean > --- Hm, taking another look at cbs it has a similar problem than the problem your patch 1/3 solves for taprio, I will propose a patch in a few moments. For this one: Acked-by: Vinicius Costa Gomes Cheers, -- Vinicius