All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stewart Smith <stewart@linux.ibm.com>
To: "jianchao.wang" <jianchao.w.wang@oracle.com>,
	Bart Van Assche <bvanassche@acm.org>,
	Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	Christoph Hellwig <hch@infradead.org>,
	Ming Lei <ming.lei@redhat.com>, Hannes Reinecke <hare@suse.com>,
	Johannes Thumshirn <jthumshirn@suse.de>,
	James Smart <james.smart@broadcom.com>,
	Dongli Zhang <dongli.zhang@oracle.com>,
	Laurence Oberman <loberman@redhat.com>,
	stable@vger.kernel.org, Joel Stanley <joel@jms.id.au>
Subject: Re: [PATCH] block: Revert v5.0 blk_mq_request_issue_directly() changes
Date: Wed, 17 Apr 2019 18:02:13 +1000	[thread overview]
Message-ID: <87zhoprrei.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <300563e5-ebf4-ed62-bbaf-207d3ab5d067@oracle.com>

"jianchao.wang" <jianchao.w.wang@oracle.com> writes:
> On 4/9/19 1:13 PM, Stewart Smith wrote:
>> cpu 0x4a: Vector: 400 (Instruction Access) at [c000203ff398b100]
>>     pc: c0000000021fe700
>>     lr: c0000000002001d8: blk_mq_complete_request+0x34/0x138
>
> Would you please figure out what is the source code here with gdb ?
>
> From the backtrace, it seems not the same issue, because no dm-mpath
> is involved here.

It turns out it's not the same issue, we just managed to hit it at the
same time as the original issue.

It's actually a bug in the STRICT_KERNEL_RWX=y code on ppc64le with
CONFIG_HUGETLB_PAGE=n that manifests as corrupting random kernel memory
and we just happen to hit it in this codepath and only once we brought
in "Revert v5.0 blk_mq_request_issue_directly".

More details over at https://github.com/linuxppc/issues/issues/237 and
there should be a fix for STRICT_KERNEL_RWX coming at some point.

-- 
Stewart Smith
OPAL Architect, IBM.


  reply	other threads:[~2019-04-17  8:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-04 17:08 [PATCH] block: Revert v5.0 blk_mq_request_issue_directly() changes Bart Van Assche
2019-04-04 21:43 ` Ming Lei
2019-04-04 22:02   ` Bart Van Assche
2019-04-04 23:49   ` Laurence Oberman
2019-04-05  6:06 ` Christoph Hellwig
2019-04-05 12:43   ` Laurence Oberman
2019-04-05 13:58     ` Bart Van Assche
2019-04-05 14:00   ` Bart Van Assche
2019-04-05 17:59     ` Jens Axboe
2019-04-09  5:13 ` Stewart Smith
2019-04-09  5:59   ` jianchao.wang
2019-04-17  8:02     ` Stewart Smith [this message]
2019-04-09 13:51   ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zhoprrei.fsf@linux.vnet.ibm.com \
    --to=stewart@linux.ibm.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=dongli.zhang@oracle.com \
    --cc=hare@suse.com \
    --cc=hch@infradead.org \
    --cc=hch@lst.de \
    --cc=james.smart@broadcom.com \
    --cc=jianchao.w.wang@oracle.com \
    --cc=joel@jms.id.au \
    --cc=jthumshirn@suse.de \
    --cc=linux-block@vger.kernel.org \
    --cc=loberman@redhat.com \
    --cc=ming.lei@redhat.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.