All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: Junio C Hamano <gitster@pobox.com>
Cc: Joe Perches <joe@perches.com>,
	Rasmus Villemoes <rv@rasmusvillemoes.dk>,
	git@vger.kernel.org
Subject: Re: [PATCH] send-email: don't cc *-by lines with '-' prefix
Date: Thu, 04 Apr 2019 12:27:11 +0300	[thread overview]
Message-ID: <87zhp6jf2o.fsf@tarshish> (raw)
In-Reply-To: <xmqqk1gaf7oe.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Thu, Apr 04 2019, Junio C. Hamano wrote:
> Baruch Siach <baruch@tkos.co.il> writes:
>
>>> Independently, I think it makes sense to do something like
>>>
>>> 	/^([a-z][a-z-]*-by|Cc): (.*)/i
>>>
>>> to tighten the match to exclude a non-trailer; that would have been
>>> sufficient for the original case that triggered this thread.
>>
>> Is there anything I need to do more to get this fix applied for the next
>> git release?
>
> Get "this" fix applied?  I think we should tighten the regexp to
> exclude a non-trailer, which would have been sufficient for the
> original case without anything else in "this" fix.  So in short, I
> do not think "this" fix won't be applied without further tweaking
> ;-)

This is exactly what "this" patch (referenced in the title of "this"
thread) is doing:

  https://public-inbox.org/git/eec56beab016182fb78fbd367fcfa97f2ca6a5ff.1552764410.git.baruch@tkos.co.il/

Am I missing something?

baruch

--
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

  reply	other threads:[~2019-04-04  9:27 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-16 19:26 [PATCH] send-email: don't cc *-by lines with '-' prefix Baruch Siach
2019-03-16 19:30 ` Joe Perches
2019-03-16 19:49   ` Baruch Siach
2019-03-16 19:59     ` Joe Perches
2019-03-16 20:14       ` Baruch Siach
2019-03-16 20:23         ` Joe Perches
2019-03-17 19:27 ` Rasmus Villemoes
2019-03-18  1:56   ` Joe Perches
2019-03-18  6:28     ` Junio C Hamano
2019-03-18  7:02       ` Joe Perches
2019-04-04  7:38       ` Baruch Siach
2019-04-04  9:20         ` Junio C Hamano
2019-04-04  9:27           ` Baruch Siach [this message]
2019-04-04  9:41             ` Junio C Hamano
2019-04-04  9:42             ` Rasmus Villemoes
2019-04-04  9:47               ` Junio C Hamano
2019-04-04 12:14               ` Jeff King
2019-04-04  9:49 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zhp6jf2o.fsf@tarshish \
    --to=baruch@tkos.co.il \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=joe@perches.com \
    --cc=rv@rasmusvillemoes.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.