All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] qmi_wwan: Added support for Fibocom NL668 series
@ 2018-12-09 22:57 Jörgen Storvist
  2018-12-10 13:52 ` Bjørn Mork
  0 siblings, 1 reply; 8+ messages in thread
From: Jörgen Storvist @ 2018-12-09 22:57 UTC (permalink / raw)
  To: netdev; +Cc: bjorn

Added support for Fibocom NL668 series QMI WWAN interface in default USB mode: AT+GTUSBMODE=17. 
Using QMI_QUIRK_SET_DTR required by Qualcomm MDM9x07 chipsets.

Signed-off-by: Jörgen Storvist <jorgen.storvist@gmail.com>

drivers/net/usb/qmi_wwan.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index 72a55b6..820081e 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -1263,6 +1263,7 @@ static const struct usb_device_id products[] = {
 	{QMI_QUIRK_SET_DTR(0x2c7c, 0x0121, 4)},	/* Quectel EC21 Mini PCIe */
 	{QMI_QUIRK_SET_DTR(0x2c7c, 0x0191, 4)},	/* Quectel EG91 */
 	{QMI_FIXED_INTF(0x2c7c, 0x0296, 4)},	/* Quectel BG96 */
+	{QMI_QUIRK_SET_DTR(0x1508, 0x1001, 4)},	/* Fibocom NL668 series */
 
 	/* 4. Gobi 1000 devices */
 	{QMI_GOBI1K_DEVICE(0x05c6, 0x9212)},	/* Acer Gobi Modem Device */

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH] qmi_wwan: Added support for Fibocom NL668 series
  2018-12-09 22:57 [PATCH] qmi_wwan: Added support for Fibocom NL668 series Jörgen Storvist
@ 2018-12-10 13:52 ` Bjørn Mork
  2018-12-11 13:49   ` [PATCH v2] " Jörgen Storvist
  2018-12-11 15:49   ` [PATCH v3] " Jörgen Storvist
  0 siblings, 2 replies; 8+ messages in thread
From: Bjørn Mork @ 2018-12-10 13:52 UTC (permalink / raw)
  To: Jörgen Storvist; +Cc: netdev

Jörgen Storvist <jorgen.storvist@gmail.com> writes:

> Added support for Fibocom NL668 series QMI WWAN interface in default USB mode: AT+GTUSBMODE=17. 
> Using QMI_QUIRK_SET_DTR required by Qualcomm MDM9x07 chipsets.
>
> Signed-off-by: Jörgen Storvist <jorgen.storvist@gmail.com>
>
> drivers/net/usb/qmi_wwan.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index 72a55b6..820081e 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -1263,6 +1263,7 @@ static const struct usb_device_id products[] = {
>  	{QMI_QUIRK_SET_DTR(0x2c7c, 0x0121, 4)},	/* Quectel EC21 Mini PCIe */
>  	{QMI_QUIRK_SET_DTR(0x2c7c, 0x0191, 4)},	/* Quectel EG91 */
>  	{QMI_FIXED_INTF(0x2c7c, 0x0296, 4)},	/* Quectel BG96 */
> +	{QMI_QUIRK_SET_DTR(0x1508, 0x1001, 4)},	/* Fibocom NL668 series */
>  
>  	/* 4. Gobi 1000 devices */
>  	{QMI_GOBI1K_DEVICE(0x05c6, 0x9212)},	/* Acer Gobi Modem Device */

Looks good, but could you please try to add it in a semi-numeric order?
Yes, I know it's far from perfect from before.  But I'm hoping to avoid
it growing worse ;-)


Bjørn

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2] qmi_wwan: Added support for Fibocom NL668 series
  2018-12-10 13:52 ` Bjørn Mork
@ 2018-12-11 13:49   ` Jörgen Storvist
  2018-12-11 14:12     ` Bjørn Mork
  2018-12-11 15:49   ` [PATCH v3] " Jörgen Storvist
  1 sibling, 1 reply; 8+ messages in thread
From: Jörgen Storvist @ 2018-12-11 13:49 UTC (permalink / raw)
  To: Bjørn Mork; +Cc: netdev


Added support for Fibocom NL668 series QMI WWAN interface in default USB mode: AT+GTUSBMODE=17. 
Using QMI_QUIRK_SET_DTR required by Qualcomm MDM9x07 chipsets.

Signed-off-by: Jörgen Storvist <jorgen.storvist@gmail.com> 
---
Changes:
Changed list order to correpond to USB VID/PID values. 

drivers/net/usb/qmi_wwan.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index 72a55b6..dada68f 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -1117,6 +1117,7 @@ static const struct usb_device_id products[] = {
 	{QMI_FIXED_INTF(0x1435, 0xd181, 4)},	/* Wistron NeWeb D18Q1 */
 	{QMI_FIXED_INTF(0x1435, 0xd181, 5)},	/* Wistron NeWeb D18Q1 */
 	{QMI_FIXED_INTF(0x1435, 0xd191, 4)},	/* Wistron NeWeb D19Q1 */
+	{QMI_QUIRK_SET_DTR(0x1508, 0x1001, 4)},	/* Fibocom NL668 series */
 	{QMI_FIXED_INTF(0x16d8, 0x6003, 0)},	/* CMOTech 6003 */
 	{QMI_FIXED_INTF(0x16d8, 0x6007, 0)},	/* CMOTech CHE-628S */
 	{QMI_FIXED_INTF(0x16d8, 0x6008, 0)},	/* CMOTech CMU-301 */

Thanks for the feedback Björn! 
Should be correct now as above if I understood you correctly.
//Jörgen

Den Mon, 10 Dec 2018 14:52:35 +0100
skrev Re: [PATCH] qmi_wwan: Added support for Fibocom NL668 series:

> Jörgen Storvist <jorgen.storvist@gmail.com> writes:
> 
> > Added support for Fibocom NL668 series QMI WWAN interface in default USB mode: AT+GTUSBMODE=17. 
> > Using QMI_QUIRK_SET_DTR required by Qualcomm MDM9x07 chipsets.
> >
> > Signed-off-by: Jörgen Storvist <jorgen.storvist@gmail.com>
> >
> > drivers/net/usb/qmi_wwan.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> > index 72a55b6..820081e 100644
> > --- a/drivers/net/usb/qmi_wwan.c
> > +++ b/drivers/net/usb/qmi_wwan.c
> > @@ -1263,6 +1263,7 @@ static const struct usb_device_id products[] = {
> >  	{QMI_QUIRK_SET_DTR(0x2c7c, 0x0121, 4)},	/* Quectel EC21 Mini PCIe */
> >  	{QMI_QUIRK_SET_DTR(0x2c7c, 0x0191, 4)},	/* Quectel EG91 */
> >  	{QMI_FIXED_INTF(0x2c7c, 0x0296, 4)},	/* Quectel BG96 */
> > +	{QMI_QUIRK_SET_DTR(0x1508, 0x1001, 4)},	/* Fibocom NL668 series */
> >  
> >  	/* 4. Gobi 1000 devices */
> >  	{QMI_GOBI1K_DEVICE(0x05c6, 0x9212)},	/* Acer Gobi Modem Device */  
> 
> Looks good, but could you please try to add it in a semi-numeric order?
> Yes, I know it's far from perfect from before.  But I'm hoping to avoid
> it growing worse ;-)
> 
> 
> Bjørn

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH v2] qmi_wwan: Added support for Fibocom NL668 series
  2018-12-11 13:49   ` [PATCH v2] " Jörgen Storvist
@ 2018-12-11 14:12     ` Bjørn Mork
  0 siblings, 0 replies; 8+ messages in thread
From: Bjørn Mork @ 2018-12-11 14:12 UTC (permalink / raw)
  To: Jörgen Storvist; +Cc: netdev

Jörgen Storvist <jorgen.storvist@gmail.com> writes:

> Should be correct now as above if I understood you correctly.

Yup, the sorting part looks fine.  But you need to drop the additional
text below the patch. It will mess up the result.  Any extra text which
isn't part of the patch or the commit message should go inside the ---
markers, like you correctly did with the changelog.

It's also possible to use "scissors" to separate extra text from the
patch, but this is rarely used. Ref https://kernelnewbies.org/PatchTipsAndTricks



Bjørn

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH v3] qmi_wwan: Added support for Fibocom NL668 series
  2018-12-10 13:52 ` Bjørn Mork
  2018-12-11 13:49   ` [PATCH v2] " Jörgen Storvist
@ 2018-12-11 15:49   ` Jörgen Storvist
  2018-12-11 20:56     ` Bjørn Mork
  1 sibling, 1 reply; 8+ messages in thread
From: Jörgen Storvist @ 2018-12-11 15:49 UTC (permalink / raw)
  To: Bjørn Mork; +Cc: netdev


Added support for Fibocom NL668 series QMI WWAN interface in default USB mode: AT+GTUSBMODE=17. 
Using QMI_QUIRK_SET_DTR required by Qualcomm MDM9x07 chipsets.

Signed-off-by: Jörgen Storvist <jorgen.storvist@gmail.com> 
---

Changelog:
v2: list order to correpond to USB VID/PID values. 
v3: Fixed Patch formatting.

Thanks Bjørn for the inputs! 
Hopefully I managed to get it somewhat okay this time. 

drivers/net/usb/qmi_wwan.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index 72a55b6..dada68f 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -1117,6 +1117,7 @@ static const struct usb_device_id products[] = {
 	{QMI_FIXED_INTF(0x1435, 0xd181, 4)},	/* Wistron NeWeb D18Q1 */
 	{QMI_FIXED_INTF(0x1435, 0xd181, 5)},	/* Wistron NeWeb D18Q1 */
 	{QMI_FIXED_INTF(0x1435, 0xd191, 4)},	/* Wistron NeWeb D19Q1 */
+	{QMI_QUIRK_SET_DTR(0x1508, 0x1001, 4)},	/* Fibocom NL668 series */
 	{QMI_FIXED_INTF(0x16d8, 0x6003, 0)},	/* CMOTech 6003 */
 	{QMI_FIXED_INTF(0x16d8, 0x6007, 0)},	/* CMOTech CHE-628S */
 	{QMI_FIXED_INTF(0x16d8, 0x6008, 0)},	/* CMOTech CMU-301 */

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH v3] qmi_wwan: Added support for Fibocom NL668 series
  2018-12-11 15:49   ` [PATCH v3] " Jörgen Storvist
@ 2018-12-11 20:56     ` Bjørn Mork
  0 siblings, 0 replies; 8+ messages in thread
From: Bjørn Mork @ 2018-12-11 20:56 UTC (permalink / raw)
  To: Jörgen Storvist; +Cc: netdev

Jörgen Storvist <jorgen.storvist@gmail.com> writes:

> Added support for Fibocom NL668 series QMI WWAN interface in default USB mode: AT+GTUSBMODE=17. 
> Using QMI_QUIRK_SET_DTR required by Qualcomm MDM9x07 chipsets.
>
> Signed-off-by: Jörgen Storvist <jorgen.storvist@gmail.com> 
> ---
>
> Changelog:
> v2: list order to correpond to USB VID/PID values. 
> v3: Fixed Patch formatting.
>
> Thanks Bjørn for the inputs! 
> Hopefully I managed to get it somewhat okay this time. 
>
> drivers/net/usb/qmi_wwan.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index 72a55b6..dada68f 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -1117,6 +1117,7 @@ static const struct usb_device_id products[] = {
>  	{QMI_FIXED_INTF(0x1435, 0xd181, 4)},	/* Wistron NeWeb D18Q1 */
>  	{QMI_FIXED_INTF(0x1435, 0xd181, 5)},	/* Wistron NeWeb D18Q1 */
>  	{QMI_FIXED_INTF(0x1435, 0xd191, 4)},	/* Wistron NeWeb D19Q1 */
> +	{QMI_QUIRK_SET_DTR(0x1508, 0x1001, 4)},	/* Fibocom NL668 series */
>  	{QMI_FIXED_INTF(0x16d8, 0x6003, 0)},	/* CMOTech 6003 */
>  	{QMI_FIXED_INTF(0x16d8, 0x6007, 0)},	/* CMOTech CHE-628S */
>  	{QMI_FIXED_INTF(0x16d8, 0x6008, 0)},	/* CMOTech CMU-301 */


Looks good.  Only minor thing is this warning I got from git, due to
your latin1 email:

 Warning: commit message did not conform to UTF-8.
 You may want to amend it after fixing the message, or set the config
 variable i18n.commitencoding to the encoding your project uses.

Don't know if that matters though.  The commit message still looks fine
in utf8, so I guess not.

Acked-by: Bjørn Mork <bjorn@mork.no>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] qmi_wwan: Added support for Fibocom NL668 series
  2018-12-09 15:35 [PATCH] " Jörgen Storvist
@ 2018-12-09 19:50 ` David Miller
  0 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2018-12-09 19:50 UTC (permalink / raw)
  To: jorgen.storvist; +Cc: bjorn, netdev

From: Jörgen Storvist <jorgen.storvist@gmail.com>
Date: Sun, 9 Dec 2018 16:35:48 +0100

> Added support for Fibocom NL668 series exposing QMI WWAN interface in
> USB mode: AT+GTUSBMODE=17.
> QMI_QUIRK_SET_DTR for Fibocom VID and PID required by Qualcomm MDM9x07 chipsets.
> 
> Signed-off-by: Jörgen Storvist <jorgen.storvist@gmail.com>
> 
>  drivers/net/usb/qmi_wwan.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index 72a55b6..820081e 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -1263,6 +1263,7 @@ static const struct usb_device_id products[] = {
>   {QMI_QUIRK_SET_DTR(0x2c7c, 0x0121, 4)}, /* Quectel EC21 Mini PCIe */
>   {QMI_QUIRK_SET_DTR(0x2c7c, 0x0191, 4)}, /* Quectel EG91 */
>   {QMI_FIXED_INTF(0x2c7c, 0x0296, 4)}, /* Quectel BG96 */
> + {QMI_QUIRK_SET_DTR(0x1508, 0x1001, 4)}, /* Fibocom NL668 series
> (AT+GTUSBMODE=17) */

Your email client corrupted the patch, it broke up this long line.

Please fix this, email a test patch to yourself, and do not repost your
patch to the list until you can successfully apply the patch in that
test email.

Thank you.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH] qmi_wwan: Added support for Fibocom NL668 series
@ 2018-12-09 15:35 Jörgen Storvist
  2018-12-09 19:50 ` David Miller
  0 siblings, 1 reply; 8+ messages in thread
From: Jörgen Storvist @ 2018-12-09 15:35 UTC (permalink / raw)
  To: bjorn, netdev

Added support for Fibocom NL668 series exposing QMI WWAN interface in
USB mode: AT+GTUSBMODE=17.
QMI_QUIRK_SET_DTR for Fibocom VID and PID required by Qualcomm MDM9x07 chipsets.

Signed-off-by: Jörgen Storvist <jorgen.storvist@gmail.com>

 drivers/net/usb/qmi_wwan.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index 72a55b6..820081e 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -1263,6 +1263,7 @@ static const struct usb_device_id products[] = {
  {QMI_QUIRK_SET_DTR(0x2c7c, 0x0121, 4)}, /* Quectel EC21 Mini PCIe */
  {QMI_QUIRK_SET_DTR(0x2c7c, 0x0191, 4)}, /* Quectel EG91 */
  {QMI_FIXED_INTF(0x2c7c, 0x0296, 4)}, /* Quectel BG96 */
+ {QMI_QUIRK_SET_DTR(0x1508, 0x1001, 4)}, /* Fibocom NL668 series
(AT+GTUSBMODE=17) */

  /* 4. Gobi 1000 devices */
  {QMI_GOBI1K_DEVICE(0x05c6, 0x9212)}, /* Acer Gobi Modem Device */

^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2018-12-11 20:56 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-09 22:57 [PATCH] qmi_wwan: Added support for Fibocom NL668 series Jörgen Storvist
2018-12-10 13:52 ` Bjørn Mork
2018-12-11 13:49   ` [PATCH v2] " Jörgen Storvist
2018-12-11 14:12     ` Bjørn Mork
2018-12-11 15:49   ` [PATCH v3] " Jörgen Storvist
2018-12-11 20:56     ` Bjørn Mork
  -- strict thread matches above, loose matches on Subject: below --
2018-12-09 15:35 [PATCH] " Jörgen Storvist
2018-12-09 19:50 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.