From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6553BC43441 for ; Sun, 25 Nov 2018 15:41:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 04F832084E for ; Sun, 25 Nov 2018 15:41:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mork.no header.i=@mork.no header.b="Am0S+l0v" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 04F832084E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mork.no Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726532AbeKZCdL (ORCPT ); Sun, 25 Nov 2018 21:33:11 -0500 Received: from canardo.mork.no ([148.122.252.1]:42755 "EHLO canardo.mork.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726226AbeKZCdL (ORCPT ); Sun, 25 Nov 2018 21:33:11 -0500 Received: from miraculix.mork.no (miraculix.mork.no [IPv6:2001:4641:0:2:7627:374e:db74:e353]) (authenticated bits=0) by canardo.mork.no (8.15.2/8.15.2) with ESMTPSA id wAPFfG7N010168 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 25 Nov 2018 16:41:16 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mork.no; s=b; t=1543160478; bh=2KAkplTJhGzzvyoPKCDSLroA5gHvmKhAYlkFOqKCpWk=; h=From:To:Cc:Subject:References:Date:Message-ID:From; b=Am0S+l0vYCmOLrFi3IMRBWwJaJLTmcztdJIdTr3VPPrYwc0x7wjC8wERgXajK6Y+0 Yui4jEzJOZxyeziKGVQx0S3WdffI8FtQUXx/227Ert5ajUugni6td1CcL2b88tCVyF n/56jZCocZ1mncBuLas/AfSAH/mZfhB1pAQnmP+U= Received: from bjorn by miraculix.mork.no with local (Exim 4.89) (envelope-from ) id 1gQwX5-0003Ie-TH; Sun, 25 Nov 2018 16:41:15 +0100 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= To: Eric Wong Cc: Henrique de Moraes Holschuh , Shuduo Sang , Darren Hart , Andy Shevchenko , linux-kernel@vger.kernel.org, ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH] platform/x86: thinkpad_acpi: add adaptive_kbd_modes parameter Organization: m References: <20181115073429.z44czywrf7f65ndb@dcvr> <20181124232327.t3awc6dnjqdtvzwu@dcvr> <87in0l31b9.fsf@miraculix.mork.no> <20181125144441.xpwuov2i7lab3agh@dcvr> Date: Sun, 25 Nov 2018 16:41:15 +0100 In-Reply-To: <20181125144441.xpwuov2i7lab3agh@dcvr> (Eric Wong's message of "Sun, 25 Nov 2018 14:44:41 +0000") Message-ID: <87zhtx17xg.fsf@miraculix.mork.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Virus-Scanned: clamav-milter 0.100.2 at canardo X-Virus-Status: Clean Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eric Wong writes: > Bj=C3=B8rn Mork wrote: > >> And then I believe you have a busy loop here: >>=20 >> > @@ -3815,20 +3838,20 @@ static int adaptive_keyboard_set_mode(int new_= mode) >> >=20=20 >> > static int adaptive_keyboard_get_next_mode(int mode) >> > { >> > - size_t i; >> > - size_t max_mode =3D ARRAY_SIZE(adaptive_keyboard_modes) - 1; >> > - >> > - for (i =3D 0; i <=3D max_mode; i++) { >> > - if (adaptive_keyboard_modes[i] =3D=3D mode) >> > - break; >> > - } >> > + int max_mode =3D fls(adaptive_kbd_modes); >> > + int new_mode =3D mode >=3D max_mode ? HOME_MODE : mode + 1; >> >=20=20 >> > - if (i >=3D max_mode) >> > - i =3D 0; >> > - else >> > - i++; >> > + /* make sure the new mode is allowed by the user */ >> > + while (!(adaptive_kbd_modes & (1 << new_mode))) { >> > + new_mode++; >> > + if (new_mode > max_mode) >> > + new_mode =3D HOME_MODE; >> >=20=20 >> > - return adaptive_keyboard_modes[i]; >> > + /* maybe the user disabled all other modes: */ >> > + if (new_mode =3D=3D mode) >> > + return mode; >> > + } >> > + return new_mode; >> > } > > Not a busy loop, since new_mode will reset at HOME_MODE (0) > and then it'll hit "new_mode =3D=3D mode" and remain locked in > to the current mode. Right. I see it now. Thanks for explaining. I guess I was expecting a complete loop bypass ala if (!max_mode) return mode: but your solution will of course work just as fine. Bj=C3=B8rn From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= Subject: Re: [PATCH] platform/x86: thinkpad_acpi: add adaptive_kbd_modes parameter Date: Sun, 25 Nov 2018 16:41:15 +0100 Message-ID: <87zhtx17xg.fsf@miraculix.mork.no> References: <20181115073429.z44czywrf7f65ndb@dcvr> <20181124232327.t3awc6dnjqdtvzwu@dcvr> <87in0l31b9.fsf@miraculix.mork.no> <20181125144441.xpwuov2i7lab3agh@dcvr> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20181125144441.xpwuov2i7lab3agh@dcvr> (Eric Wong's message of "Sun, 25 Nov 2018 14:44:41 +0000") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ibm-acpi-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Eric Wong Cc: Henrique de Moraes Holschuh , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, platform-driver-x86-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, ibm-acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Shuduo Sang , Darren Hart , Andy Shevchenko List-Id: platform-driver-x86.vger.kernel.org RXJpYyBXb25nIDxlQDgweDI0Lm9yZz4gd3JpdGVzOgo+IEJqw7hybiBNb3JrIDxiam9ybkBtb3Jr Lm5vPiB3cm90ZToKPgo+PiBBbmQgdGhlbiBJIGJlbGlldmUgeW91IGhhdmUgYSBidXN5IGxvb3Ag aGVyZToKPj4gCj4+ID4gQEAgLTM4MTUsMjAgKzM4MzgsMjAgQEAgc3RhdGljIGludCBhZGFwdGl2 ZV9rZXlib2FyZF9zZXRfbW9kZShpbnQgbmV3X21vZGUpCj4+ID4gIAo+PiA+ICBzdGF0aWMgaW50 IGFkYXB0aXZlX2tleWJvYXJkX2dldF9uZXh0X21vZGUoaW50IG1vZGUpCj4+ID4gIHsKPj4gPiAt CXNpemVfdCBpOwo+PiA+IC0Jc2l6ZV90IG1heF9tb2RlID0gQVJSQVlfU0laRShhZGFwdGl2ZV9r ZXlib2FyZF9tb2RlcykgLSAxOwo+PiA+IC0KPj4gPiAtCWZvciAoaSA9IDA7IGkgPD0gbWF4X21v ZGU7IGkrKykgewo+PiA+IC0JCWlmIChhZGFwdGl2ZV9rZXlib2FyZF9tb2Rlc1tpXSA9PSBtb2Rl KQo+PiA+IC0JCQlicmVhazsKPj4gPiAtCX0KPj4gPiArCWludCBtYXhfbW9kZSA9IGZscyhhZGFw dGl2ZV9rYmRfbW9kZXMpOwo+PiA+ICsJaW50IG5ld19tb2RlID0gbW9kZSA+PSBtYXhfbW9kZSA/ IEhPTUVfTU9ERSA6IG1vZGUgKyAxOwo+PiA+ICAKPj4gPiAtCWlmIChpID49IG1heF9tb2RlKQo+ PiA+IC0JCWkgPSAwOwo+PiA+IC0JZWxzZQo+PiA+IC0JCWkrKzsKPj4gPiArCS8qIG1ha2Ugc3Vy ZSB0aGUgbmV3IG1vZGUgaXMgYWxsb3dlZCBieSB0aGUgdXNlciAqLwo+PiA+ICsJd2hpbGUgKCEo YWRhcHRpdmVfa2JkX21vZGVzICYgKDEgPDwgbmV3X21vZGUpKSkgewo+PiA+ICsJCW5ld19tb2Rl Kys7Cj4+ID4gKwkJaWYgKG5ld19tb2RlID4gbWF4X21vZGUpCj4+ID4gKwkJCW5ld19tb2RlID0g SE9NRV9NT0RFOwo+PiA+ICAKPj4gPiAtCXJldHVybiBhZGFwdGl2ZV9rZXlib2FyZF9tb2Rlc1tp XTsKPj4gPiArCQkvKiBtYXliZSB0aGUgdXNlciBkaXNhYmxlZCBhbGwgb3RoZXIgbW9kZXM6ICov Cj4+ID4gKwkJaWYgKG5ld19tb2RlID09IG1vZGUpCj4+ID4gKwkJCXJldHVybiBtb2RlOwo+PiA+ ICsJfQo+PiA+ICsJcmV0dXJuIG5ld19tb2RlOwo+PiA+ICB9Cj4KPiBOb3QgYSBidXN5IGxvb3As IHNpbmNlIG5ld19tb2RlIHdpbGwgcmVzZXQgYXQgSE9NRV9NT0RFICgwKQo+IGFuZCB0aGVuIGl0 J2xsIGhpdCAibmV3X21vZGUgPT0gbW9kZSIgYW5kIHJlbWFpbiBsb2NrZWQgaW4KPiB0byB0aGUg Y3VycmVudCBtb2RlLgoKUmlnaHQuICBJIHNlZSBpdCBub3cuICBUaGFua3MgZm9yIGV4cGxhaW5p bmcuCgpJIGd1ZXNzIEkgd2FzIGV4cGVjdGluZyBhIGNvbXBsZXRlIGxvb3AgYnlwYXNzIGFsYQoK ICBpZiAoIW1heF9tb2RlKQogICAgIHJldHVybiBtb2RlOgoKYnV0IHlvdXIgc29sdXRpb24gd2ls bCBvZiBjb3Vyc2Ugd29yayBqdXN0IGFzIGZpbmUuCgoKCkJqw7hybgoKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmlibS1hY3BpLWRldmVsIG1haWxpbmcg bGlzdAppYm0tYWNwaS1kZXZlbEBsaXN0cy5zb3VyY2Vmb3JnZS5uZXQKaHR0cHM6Ly9saXN0cy5z b3VyY2Vmb3JnZS5uZXQvbGlzdHMvbGlzdGluZm8vaWJtLWFjcGktZGV2ZWwK