From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3008BC0044C for ; Thu, 1 Nov 2018 10:18:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DE1EB2084A for ; Thu, 1 Nov 2018 10:18:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DE1EB2084A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727953AbeKATU4 (ORCPT ); Thu, 1 Nov 2018 15:20:56 -0400 Received: from ozlabs.org ([203.11.71.1]:42331 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726320AbeKATU4 (ORCPT ); Thu, 1 Nov 2018 15:20:56 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPSA id 42m1Pf2BxFz9sTc; Thu, 1 Nov 2018 21:18:30 +1100 (AEDT) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au From: Michael Ellerman To: Mark Brown , Rob Herring Cc: Linus Torvalds , kirill@shutemov.name, Linus Walleij , boris.brezillon@bootlin.com, Catalin Marinas , Christoph Hellwig , Guenter Roeck , jacek.anaszewski@gmail.com, axboe@kernel.dk, Ulf Hansson , Greg Kroah-Hartman , Linux Kernel Mailing List Subject: Re: Git pull ack emails.. In-Reply-To: <20181026211504.GG27137@sirena.org.uk> References: <20181023093521.dm3l5oen2j7etsot@kshutemo-mobl1> <20181023200408.GA13179@chatter.qube.local> <20181026211504.GG27137@sirena.org.uk> Date: Thu, 01 Nov 2018 21:18:28 +1100 Message-ID: <87zhutdrt7.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mark Brown writes: > On Fri, Oct 26, 2018 at 12:36:14PM -0500, Rob Herring wrote: >> On Thu, Oct 25, 2018 at 9:14 AM Linus Torvalds >> wrote: > >> > Are there other situations where you might want to track something >> > _outside_ of a pull request? Maybe. I can't really think of a lot of >> > them, though. Patches etc don't have commit ID's to track, but it > > patchwork gives them IDs and lets you do lookups using them, that's what > I'm doing. You can get the ID from a git commit by piping the output of > git show into parser.py from the patchwork source, it works a lot of the > time but things like editing the commit message will break it (this is a > theme with my scripting around the mail stuff...). > >> submissions. For example, with Greg and Mark B you can expect an >> automated replies. Mark's reply gets threaded with the original, but >> Greg's do not. For networking, you may or may not get a manual reply, > > Mine *mostly* gets threaded, it's relying on being able to talk to > patchwork to figure out the message ID at the minute so if the patchwork > lookup fails for whatever reason it'll just use on what's in the commit > for the CC list and not thread. That isn't ideal, especially when I'm > travelling and my network connection isn't the best, I keep meaning to > try to figure out a better way which would probably be based on git > notes as discussed earlier. Yeah I use git notes for this. When I apply a patch I record the patchwork id in a git note, I have a custom hacked pwclient that does it automatically. I also download the full mbox from patchwork and stash it in .git/patchwork/. Then I have everything I need to generate a properly threaded reply to the original mail. The git notes work well, if you add the following to your .git/config: [notes] rewriteRef = refs/notes/* displayRef = refs/notes/* Then all notes are copied when you rewrite a commit (rebase), and also displayed by eg. git show. Every now and then if you do extensive rebasing/splitting you get commits with the wrong or no patchwork ids. But that's pretty rare and not that hard to fixup when it happens. There's a slightly sanitised version of some of my scripts here: https://github.com/mpe/patchwork-scripts cheers