From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: Re: [PATCH 1/3] ALSA: add snd_card_disconnect_sync()
Date: Wed, 11 Oct 2017 07:51:31 +0000
Message-ID: <87zi8ynn8b.wl%kuninori.morimoto.gx@renesas.com>
References: <87fuaqp5e7.wl%kuninori.morimoto.gx@renesas.com>
 <87d15up5ac.wl%kuninori.morimoto.gx@renesas.com>
 <s5hfuaqi1f5.wl-tiwai@suse.de>
Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from relmlie1.idc.renesas.com (relmlor2.renesas.com
 [210.160.252.172])
 by alsa0.perex.cz (Postfix) with ESMTP id A041F26735C
 for <alsa-devel@alsa-project.org>; Wed, 11 Oct 2017 09:51:36 +0200 (CEST)
In-Reply-To: <s5hfuaqi1f5.wl-tiwai@suse.de>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Takashi Iwai <tiwai@suse.de>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>, Mark Brown <broonie@kernel.org>, Simon <horms@verge.net.au>
List-Id: alsa-devel@alsa-project.org


Hi Takashi

> > Takashi-san
> > 
> > I created this patch and its git-log, but please fixup it
> > if needed.
> 
> I would split this again to two patches, one for adding
> snd_card_disconnect_sync(), and another for adding snd_pcm_stop() call
> at snd_pcm_dev_disconnect().
> 
> Basically the latter is for the drivers that don't handle the PCM stop
> at disconnection explicitly, and it's not mandatory when the driver's
> pcm dev_disconnect callback handles it.
> 
> Also, since these changes are about ALSA core, and at least the
> PCM-stop one is intrusive and may have influences on the behavior of
> other drivers, I'd like to test with usb-audio before landing to ASoC
> world.  Once when confirmed, I'll publish a persistent branch
> containing these API changes and let Mark pull it.

Thanks.
I will re-post [2/3] [3/3] part patch on top of your persistent branch.

Best regards
---
Kuninori Morimoto