* [PATCH v2] rtlwifi: Replace hardcode value with macro
@ 2017-06-22 12:00 Souptick Joarder
2017-06-22 13:35 ` Larry Finger
2017-06-28 16:17 ` Kalle Valo
0 siblings, 2 replies; 5+ messages in thread
From: Souptick Joarder @ 2017-06-22 12:00 UTC (permalink / raw)
To: Larry.Finger, chaoming_li; +Cc: linux-wireless
In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval
and hw->max_rate_tries are replaced by macro.
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
Changes in v2:
- Signed-off was missing in previous one.
drivers/net/wireless/realtek/rtlwifi/base.c | 6 +++---
drivers/net/wireless/realtek/rtlwifi/base.h | 2 ++
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c b/drivers/net/wireless/realtek/rtlwifi/base.c
index bdc3791..f45d093 100644
--- a/drivers/net/wireless/realtek/rtlwifi/base.c
+++ b/drivers/net/wireless/realtek/rtlwifi/base.c
@@ -422,9 +422,9 @@ static void _rtl_init_mac80211(struct ieee80211_hw *hw)
hw->extra_tx_headroom = RTL_TX_HEADER_SIZE;
/* TODO: Correct this value for our hw */
- /* TODO: define these hard code value */
- hw->max_listen_interval = 10;
- hw->max_rate_tries = 4;
+ /* defined these hard code values */
+ hw->max_listen_interval = MAX_LISTEN_INTERVAL;
+ hw->max_rate_tries = MAX_RATE_TRIES;
/* hw->max_rates = 1; */
hw->sta_data_size = sizeof(struct rtl_sta_info);
diff --git a/drivers/net/wireless/realtek/rtlwifi/base.h b/drivers/net/wireless/realtek/rtlwifi/base.h
index 02ff0c5..d03e198 100644
--- a/drivers/net/wireless/realtek/rtlwifi/base.h
+++ b/drivers/net/wireless/realtek/rtlwifi/base.h
@@ -65,6 +65,8 @@ enum ap_peer {
#define FRAME_OFFSET_ADDRESS3 16
#define FRAME_OFFSET_SEQUENCE 22
#define FRAME_OFFSET_ADDRESS4 24
+#define MAX_LISTEN_INTERVAL 10
+#define MAX_RATE_TRIES 4
#define SET_80211_HDR_FRAME_CONTROL(_hdr, _val) \
WRITEEF2BYTE(_hdr, _val)
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] rtlwifi: Replace hardcode value with macro
2017-06-22 12:00 [PATCH v2] rtlwifi: Replace hardcode value with macro Souptick Joarder
@ 2017-06-22 13:35 ` Larry Finger
2017-06-28 4:29 ` Souptick Joarder
2017-06-28 16:17 ` Kalle Valo
1 sibling, 1 reply; 5+ messages in thread
From: Larry Finger @ 2017-06-22 13:35 UTC (permalink / raw)
To: Souptick Joarder, chaoming_li; +Cc: linux-wireless
On 06/22/2017 07:00 AM, Souptick Joarder wrote:
> In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval
> and hw->max_rate_tries are replaced by macro.
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> ---
> Changes in v2:
> - Signed-off was missing in previous one.
This patch includes a comment that is not needed, but it is OK.
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry
>
> drivers/net/wireless/realtek/rtlwifi/base.c | 6 +++---
> drivers/net/wireless/realtek/rtlwifi/base.h | 2 ++
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c b/drivers/net/wireless/realtek/rtlwifi/base.c
> index bdc3791..f45d093 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/base.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/base.c
> @@ -422,9 +422,9 @@ static void _rtl_init_mac80211(struct ieee80211_hw *hw)
> hw->extra_tx_headroom = RTL_TX_HEADER_SIZE;
>
> /* TODO: Correct this value for our hw */
> - /* TODO: define these hard code value */
> - hw->max_listen_interval = 10;
> - hw->max_rate_tries = 4;
> + /* defined these hard code values */
> + hw->max_listen_interval = MAX_LISTEN_INTERVAL;
> + hw->max_rate_tries = MAX_RATE_TRIES;
> /* hw->max_rates = 1; */
> hw->sta_data_size = sizeof(struct rtl_sta_info);
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/base.h b/drivers/net/wireless/realtek/rtlwifi/base.h
> index 02ff0c5..d03e198 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/base.h
> +++ b/drivers/net/wireless/realtek/rtlwifi/base.h
> @@ -65,6 +65,8 @@ enum ap_peer {
> #define FRAME_OFFSET_ADDRESS3 16
> #define FRAME_OFFSET_SEQUENCE 22
> #define FRAME_OFFSET_ADDRESS4 24
> +#define MAX_LISTEN_INTERVAL 10
> +#define MAX_RATE_TRIES 4
>
> #define SET_80211_HDR_FRAME_CONTROL(_hdr, _val) \
> WRITEEF2BYTE(_hdr, _val)
> --
> 1.9.1
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] rtlwifi: Replace hardcode value with macro
2017-06-22 13:35 ` Larry Finger
@ 2017-06-28 4:29 ` Souptick Joarder
0 siblings, 0 replies; 5+ messages in thread
From: Souptick Joarder @ 2017-06-28 4:29 UTC (permalink / raw)
To: Larry Finger; +Cc: Chaoming Li, linux-wireless
Hi Larry,
On Thu, Jun 22, 2017 at 7:05 PM, Larry Finger <Larry.Finger@lwfinger.net> wrote:
> On 06/22/2017 07:00 AM, Souptick Joarder wrote:
>>
>> In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval
>> and hw->max_rate_tries are replaced by macro.
>>
>> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
>> ---
>> Changes in v2:
>> - Signed-off was missing in previous one.
>
>
> This patch includes a comment that is not needed, but it is OK.
>
> Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
>
> Larry
Any further review is required for this patch or it will be merged to
maintainer tree ?
>
>
>>
>> drivers/net/wireless/realtek/rtlwifi/base.c | 6 +++---
>> drivers/net/wireless/realtek/rtlwifi/base.h | 2 ++
>> 2 files changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c
>> b/drivers/net/wireless/realtek/rtlwifi/base.c
>> index bdc3791..f45d093 100644
>> --- a/drivers/net/wireless/realtek/rtlwifi/base.c
>> +++ b/drivers/net/wireless/realtek/rtlwifi/base.c
>> @@ -422,9 +422,9 @@ static void _rtl_init_mac80211(struct ieee80211_hw
>> *hw)
>> hw->extra_tx_headroom = RTL_TX_HEADER_SIZE;
>>
>> /* TODO: Correct this value for our hw */
>> - /* TODO: define these hard code value */
>> - hw->max_listen_interval = 10;
>> - hw->max_rate_tries = 4;
>> + /* defined these hard code values */
>> + hw->max_listen_interval = MAX_LISTEN_INTERVAL;
>> + hw->max_rate_tries = MAX_RATE_TRIES;
>> /* hw->max_rates = 1; */
>> hw->sta_data_size = sizeof(struct rtl_sta_info);
>>
>> diff --git a/drivers/net/wireless/realtek/rtlwifi/base.h
>> b/drivers/net/wireless/realtek/rtlwifi/base.h
>> index 02ff0c5..d03e198 100644
>> --- a/drivers/net/wireless/realtek/rtlwifi/base.h
>> +++ b/drivers/net/wireless/realtek/rtlwifi/base.h
>> @@ -65,6 +65,8 @@ enum ap_peer {
>> #define FRAME_OFFSET_ADDRESS3 16
>> #define FRAME_OFFSET_SEQUENCE 22
>> #define FRAME_OFFSET_ADDRESS4 24
>> +#define MAX_LISTEN_INTERVAL 10
>> +#define MAX_RATE_TRIES 4
>>
>> #define SET_80211_HDR_FRAME_CONTROL(_hdr, _val) \
>> WRITEEF2BYTE(_hdr, _val)
>> --
>> 1.9.1
>>
>>
>
-Souptick
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] rtlwifi: Replace hardcode value with macro
2017-06-22 12:00 [PATCH v2] rtlwifi: Replace hardcode value with macro Souptick Joarder
2017-06-22 13:35 ` Larry Finger
@ 2017-06-28 16:17 ` Kalle Valo
2017-06-29 4:13 ` Souptick Joarder
1 sibling, 1 reply; 5+ messages in thread
From: Kalle Valo @ 2017-06-28 16:17 UTC (permalink / raw)
To: Souptick Joarder; +Cc: Larry.Finger, chaoming_li, linux-wireless
Souptick Joarder <jrdr.linux@gmail.com> writes:
> In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval
> and hw->max_rate_tries are replaced by macro.
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> ---
> Changes in v2:
> - Signed-off was missing in previous one.
>
> drivers/net/wireless/realtek/rtlwifi/base.c | 6 +++---
> drivers/net/wireless/realtek/rtlwifi/base.h | 2 ++
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c b/drivers/net/wireless/realtek/rtlwifi/base.c
> index bdc3791..f45d093 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/base.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/base.c
> @@ -422,9 +422,9 @@ static void _rtl_init_mac80211(struct ieee80211_hw *hw)
> hw->extra_tx_headroom = RTL_TX_HEADER_SIZE;
>
> /* TODO: Correct this value for our hw */
> - /* TODO: define these hard code value */
> - hw->max_listen_interval = 10;
> - hw->max_rate_tries = 4;
> + /* defined these hard code values */
> + hw->max_listen_interval = MAX_LISTEN_INTERVAL;
> + hw->max_rate_tries = MAX_RATE_TRIES;
Like Larry said, the comment does not make any sense. Please remove it
and send v3.
--
Kalle Valo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] rtlwifi: Replace hardcode value with macro
2017-06-28 16:17 ` Kalle Valo
@ 2017-06-29 4:13 ` Souptick Joarder
0 siblings, 0 replies; 5+ messages in thread
From: Souptick Joarder @ 2017-06-29 4:13 UTC (permalink / raw)
To: Kalle Valo; +Cc: Larry Finger, Chaoming Li, linux-wireless
Hi Kalle,
On Wed, Jun 28, 2017 at 9:47 PM, Kalle Valo <kvalo@codeaurora.org> wrote:
> Souptick Joarder <jrdr.linux@gmail.com> writes:
>
>> In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval
>> and hw->max_rate_tries are replaced by macro.
>>
>> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
>> ---
>> Changes in v2:
>> - Signed-off was missing in previous one.
As Signed-off was missing in first patch, so I send v2 with change
logs mentioned the same.
Just for clarification, shall I replace the comment mentioned in
change log with "no change"?
>>
>> drivers/net/wireless/realtek/rtlwifi/base.c | 6 +++---
>> drivers/net/wireless/realtek/rtlwifi/base.h | 2 ++
>> 2 files changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c b/drivers/net/wireless/realtek/rtlwifi/base.c
>> index bdc3791..f45d093 100644
>> --- a/drivers/net/wireless/realtek/rtlwifi/base.c
>> +++ b/drivers/net/wireless/realtek/rtlwifi/base.c
>> @@ -422,9 +422,9 @@ static void _rtl_init_mac80211(struct ieee80211_hw *hw)
>> hw->extra_tx_headroom = RTL_TX_HEADER_SIZE;
>>
>> /* TODO: Correct this value for our hw */
>> - /* TODO: define these hard code value */
>> - hw->max_listen_interval = 10;
>> - hw->max_rate_tries = 4;
>> + /* defined these hard code values */
>> + hw->max_listen_interval = MAX_LISTEN_INTERVAL;
>> + hw->max_rate_tries = MAX_RATE_TRIES;
>
> Like Larry said, the comment does not make any sense. Please remove it
> and send v3.
>
> --
> Kalle Valo
Souptick
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-06-29 4:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-22 12:00 [PATCH v2] rtlwifi: Replace hardcode value with macro Souptick Joarder
2017-06-22 13:35 ` Larry Finger
2017-06-28 4:29 ` Souptick Joarder
2017-06-28 16:17 ` Kalle Valo
2017-06-29 4:13 ` Souptick Joarder
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.