From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com ([134.134.136.65]:62488 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752903AbdDKHAQ (ORCPT ); Tue, 11 Apr 2017 03:00:16 -0400 From: Felipe Balbi To: Manish Narani , git-dev@xilinx.com Cc: anirudh@xilinx.com, Roger Quadros , stable@vger.kernel.org Subject: Re: [PATCH] Revert "usb: gadget: uvc: Add missing call for additional setup data" In-Reply-To: <1491891125-25721-1-git-send-email-mnarani@xilinx.com> References: <1491891125-25721-1-git-send-email-mnarani@xilinx.com> Date: Tue, 11 Apr 2017 09:59:49 +0300 Message-ID: <87zifnctui.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: stable-owner@vger.kernel.org List-ID: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Manish Narani writes: > From: Roger Quadros > > This reverts commit 4fbac5206afd01b717d4bdc58793d471f3391b4b. > > This commit breaks g_webcam when used with uvc-gadget [1]. > > The user space application (e.g. uvc-gadget) is responsible for > sending response to UVC class specific requests on control endpoint > in uvc_send_response() in uvc_v4l2.c. > > The bad commit was causing a duplicate response to be sent with > incorrect response data thus causing UVC probe to fail at the host > and broken control transfer endpoint at the gadget. > > [1] - git://git.ideasonboard.org/uvc-gadget.git > > Cc: # v4.9+ > Acked-by: Laurent Pinchart > Signed-off-by: Roger Quadros > Signed-off-by: Felipe Balbi this is not how you send patches to stable. Please read stable-kernel-rules.rst =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAljsfuUACgkQzL64meEa mQaetA//dNm6CxLwa4d7ACvzTDmWw+SmdwjQ3IiemPJfjMasD3r728MFdMynRsgM RbCWpm1DCghddvMlZGfvyVCkffBX8HB4NNMgNdC2Tg9nsyLaPO847g8jAQY7eVEQ F8AZIXXKvEGpJbF/AqNsYMqVoljZngWLqxqbUJZztuj9NwejCNXbX5VW+XNwvuzg NqroSnepk/WUslKe0hSFDPoAt/5oMD3Y66lOucA9D0TB7VGhJuQqlKNyBfNst8Tf QzDiVXQ74Mwqe3aNUsFVF3RP30Yw9tRhlM1gbimSxrlQZ2+j+yUbmhclbrc3HCpP VX7i0gBi+k9E1TdDEKzzbWDXA261xn8y7hcQWZwoqKfXlVorVU9Z0jJ3Uz3nWtZ3 ufDZcH1A5HgXOtb0fC8z+vQQ2+uRUn6KdvMzcGVr6cOvqho8HtdMP+1PYHA/zj2s wdrxk+zgrQnfqQ6/9KfiJg1vv5Snj40qqB8fPts6ErAhmrYP89T8P+vEwgEBpXUs gfNSxeAs/qkf9RgwOYUI6+eC2qVttk2G+mwA45m6+wVT+D/M2LF+A9L/s3H/qUtj CkWJTMzZuvjrRn+Ic0WGsnsHmc9W66ywjfpmJorv7PnQ6vF4cTonQmkrQIScx2Kz NN2e5mnRH/Lyp7tuTwf7tMRzo3lcFYAlppU4a2HAAbQP0uAlW0o= =fPEz -----END PGP SIGNATURE----- --=-=-=--