From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juan Quintela Subject: Re: [qemu patch 2/2] kvmclock: reduce kvmclock difference on migration Date: Mon, 14 Nov 2016 15:11:44 +0100 Message-ID: <87zil2ducf.fsf@emacs.mitica> References: <20161114123628.703911091@redhat.com> <20161114123700.158592605@redhat.com> Reply-To: quintela@redhat.com Mime-Version: 1.0 Content-Type: text/plain Cc: Marcelo Tosatti , kvm@vger.kernel.org, qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , Radim Krcmar , Eduardo Habkost To: Paolo Bonzini Return-path: Received: from mx1.redhat.com ([209.132.183.28]:52600 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752232AbcKNOLr (ORCPT ); Mon, 14 Nov 2016 09:11:47 -0500 In-Reply-To: (Paolo Bonzini's message of "Mon, 14 Nov 2016 14:54:38 +0100") Sender: kvm-owner@vger.kernel.org List-ID: Paolo Bonzini wrote: > On 14/11/2016 13:36, Marcelo Tosatti wrote: >> + /* local (running VM) restore */ >> + if (s->clock_valid) { >> + /* >> + * if host does not support reliable KVM_GET_CLOCK, >> + * read kvmclock value from memory >> + */ >> + if (!kvm_has_adjust_clock_stable()) { >> + time_at_migration = kvmclock_current_nsec(s); > > Just assign to s->clock here... Agreed, I just wanted to make so many changes. > Also, just another small nit: please make your scripts use the "-p" > option on diff. :) YESSSS I was searching what functions the code belonged for :p Thanks, Juan. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37971) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6HzC-0001nG-Jo for qemu-devel@nongnu.org; Mon, 14 Nov 2016 09:11:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c6Hz9-0001hp-VE for qemu-devel@nongnu.org; Mon, 14 Nov 2016 09:11:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40544) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c6Hz9-0001hd-Pd for qemu-devel@nongnu.org; Mon, 14 Nov 2016 09:11:47 -0500 From: Juan Quintela In-Reply-To: (Paolo Bonzini's message of "Mon, 14 Nov 2016 14:54:38 +0100") References: <20161114123628.703911091@redhat.com> <20161114123700.158592605@redhat.com> Reply-To: quintela@redhat.com Date: Mon, 14 Nov 2016 15:11:44 +0100 Message-ID: <87zil2ducf.fsf@emacs.mitica> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [qemu patch 2/2] kvmclock: reduce kvmclock difference on migration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Marcelo Tosatti , kvm@vger.kernel.org, qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , Radim Krcmar , Eduardo Habkost Paolo Bonzini wrote: > On 14/11/2016 13:36, Marcelo Tosatti wrote: >> + /* local (running VM) restore */ >> + if (s->clock_valid) { >> + /* >> + * if host does not support reliable KVM_GET_CLOCK, >> + * read kvmclock value from memory >> + */ >> + if (!kvm_has_adjust_clock_stable()) { >> + time_at_migration = kvmclock_current_nsec(s); > > Just assign to s->clock here... Agreed, I just wanted to make so many changes. > Also, just another small nit: please make your scripts use the "-p" > option on diff. :) YESSSS I was searching what functions the code belonged for :p Thanks, Juan.