From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753585AbcJKQHO (ORCPT ); Tue, 11 Oct 2016 12:07:14 -0400 Received: from out02.mta.xmission.com ([166.70.13.232]:45745 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753104AbcJKQHK (ORCPT ); Tue, 11 Oct 2016 12:07:10 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: Ian Kent Cc: Andrew Morton , autofs mailing list , Kernel Mailing List , linux-fsdevel , Omar Sandoval , Al Viro References: <20161011053352.27645.83962.stgit@pluto.themaw.net> Date: Tue, 11 Oct 2016 11:04:03 -0500 In-Reply-To: <20161011053352.27645.83962.stgit@pluto.themaw.net> (Ian Kent's message of "Tue, 11 Oct 2016 13:33:52 +0800") Message-ID: <87zimazxcc.fsf@x220.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1btzZZ-0003kJ-B1;;;mid=<87zimazxcc.fsf@x220.int.ebiederm.org>;;;hst=in01.mta.xmission.com;;;ip=75.170.125.99;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX19HdDnlTR2rAFiDeqMucdwGS40Iox81HuY= X-SA-Exim-Connect-IP: 75.170.125.99 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.0 TVD_RCVD_IP Message was received from an IP address * 0.7 XMSubLong Long Subject * 1.5 XMNoVowels Alpha-numberic number with no vowels * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.4996] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa02 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_03 6+ unique symbols in subject * 0.0 T_TooManySym_02 5+ unique symbols in subject * 0.0 T_TooManySym_01 4+ unique symbols in subject * 0.0 T_TooManySym_04 7+ unique symbols in subject X-Spam-DCC: XMission; sa02 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: **;Ian Kent X-Spam-Relay-Country: X-Spam-Timing: total 433 ms - load_scoreonly_sql: 0.06 (0.0%), signal_user_changed: 10 (2.2%), b_tie_ro: 8 (1.9%), parse: 1.15 (0.3%), extract_message_metadata: 24 (5.5%), get_uri_detail_list: 1.47 (0.3%), tests_pri_-1000: 8 (2.0%), tests_pri_-950: 2.1 (0.5%), tests_pri_-900: 1.69 (0.4%), tests_pri_-400: 25 (5.9%), check_bayes: 23 (5.4%), b_tokenize: 8 (1.9%), b_tok_get_all: 6 (1.3%), b_comp_prob: 3.0 (0.7%), b_tok_touch_all: 2.7 (0.6%), b_finish: 1.00 (0.2%), tests_pri_0: 345 (79.7%), check_dkim_signature: 0.84 (0.2%), check_dkim_adsp: 5.0 (1.1%), tests_pri_500: 10 (2.2%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH 1/8] vfs - change d_manage() to take a struct path X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ian Kent writes: > For the autofs module to be able to reliably check if a dentry is a > mountpoint in a multiple namespace environment the ->d_manage() dentry > operation will need to take a path argument instead of a dentry. Taking a quick look overall I see no issues with this series. Overall it seems straight forward. On the nit side I expect saying const struct path * in the functions that now take a struct path would be useful. I suspect it would also be useful to say const struct path *path; path = &file->f_path; In the one part of the code where you do that. Instead of copying the path out of the struct file. Overall I expect that will keep down bugs at no reduction in usability. Just a statement that the struct path won't change when it is passed to various functions. Eric From mboxrd@z Thu Jan 1 00:00:00 1970 From: ebiederm@xmission.com (Eric W. Biederman) Subject: Re: [PATCH 1/8] vfs - change d_manage() to take a struct path Date: Tue, 11 Oct 2016 11:04:03 -0500 Message-ID: <87zimazxcc.fsf@x220.int.ebiederm.org> References: <20161011053352.27645.83962.stgit@pluto.themaw.net> Mime-Version: 1.0 Return-path: In-Reply-To: <20161011053352.27645.83962.stgit@pluto.themaw.net> (Ian Kent's message of "Tue, 11 Oct 2016 13:33:52 +0800") Sender: autofs-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Ian Kent Cc: Andrew Morton , autofs mailing list , Kernel Mailing List , linux-fsdevel , Omar Sandoval , Al Viro Ian Kent writes: > For the autofs module to be able to reliably check if a dentry is a > mountpoint in a multiple namespace environment the ->d_manage() dentry > operation will need to take a path argument instead of a dentry. Taking a quick look overall I see no issues with this series. Overall it seems straight forward. On the nit side I expect saying const struct path * in the functions that now take a struct path would be useful. I suspect it would also be useful to say const struct path *path; path = &file->f_path; In the one part of the code where you do that. Instead of copying the path out of the struct file. Overall I expect that will keep down bugs at no reduction in usability. Just a statement that the struct path won't change when it is passed to various functions. Eric -- To unsubscribe from this list: send the line "unsubscribe autofs" in