From mboxrd@z Thu Jan 1 00:00:00 1970 From: Francisco Jerez Subject: Re: [PATCH v2 14/15] drm/i2c/ch7006: Use helper to turn off CRTC Date: Sat, 11 Jun 2016 14:57:58 -0700 Message-ID: <87ziqrtml5.fsf@riseup.net> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1313232009==" Return-path: Received: from mx1.riseup.net (mx1.riseup.net [198.252.153.129]) by gabe.freedesktop.org (Postfix) with ESMTPS id DF0F66E27C for ; Sat, 11 Jun 2016 21:58:41 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Lukas Wunner , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1313232009== Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Lukas Wunner writes: > Use shiny new drm_crtc_force_disable() instead of open coding the same. > No functional change intended. > > Cc: Francisco Jerez > Signed-off-by: Lukas Wunner Reviewed-by: Francisco Jerez > --- > drivers/gpu/drm/i2c/ch7006_drv.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/i2c/ch7006_drv.c b/drivers/gpu/drm/i2c/ch700= 6_drv.c > index 0594c45..e9e8ae2 100644 > --- a/drivers/gpu/drm/i2c/ch7006_drv.c > +++ b/drivers/gpu/drm/i2c/ch7006_drv.c > @@ -361,13 +361,8 @@ static int ch7006_encoder_set_property(struct drm_en= coder *encoder, >=20=20 > /* Disable the crtc to ensure a full modeset is > * performed whenever it's turned on again. */ > - if (crtc) { > - struct drm_mode_set modeset =3D { > - .crtc =3D crtc, > - }; > - > - drm_mode_set_config_internal(&modeset); > - } > + if (crtc) > + drm_crtc_force_disable(crtc); > } >=20=20 > return 0; > --=20 > 2.8.1 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iF4EAREIAAYFAldciWYACgkQg5k4nX1Sv1s9NwD+MBV4TlGZYPzi6yFAu5SIEsmR YrD7WGEScPh4MfiShZsA+waJ83TxIY1ICWS2bhxVhnUW+HHNMxveKi5JpVS4P0Ui =HoHK -----END PGP SIGNATURE----- --==-=-=-- --===============1313232009== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1313232009==--